8:24 p.m.
Plugins should be .jar's not directories for efficency sake
-----------------------------------------------------------
Key: JBIDE-3628
URL: https://jira.jboss.org/jira/browse/JBIDE-3628
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Build/Releng
Reporter: Max Rydahl Andersen
Priority: Critical
Fix For: 3.1.0
65 of our plugins are bundled exploded instead of a .jar
Some are probably just mistakes and can easily be packed others are because of legacy code
assuming it can access the files directly and even store data in the plugins - that should
be fixed.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:04 a.m.
New subject: [JBoss JIRA] Assigned: (JBIDE-3628) Plugins should be .jar's not directories for efficency sake
[
https://jira.jboss.org/jira/browse/JBIDE-3628?page=com.atlassian.jira.plu...
]
Denis Golovin reassigned JBIDE-3628:
------------------------------------
Assignee: Denis Golovin
Plugins should be .jar's not directories for efficency sake
-----------------------------------------------------------
Key: JBIDE-3628
URL: https://jira.jboss.org/jira/browse/JBIDE-3628
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Build/Releng
Reporter: Max Rydahl Andersen
Assignee: Denis Golovin
Priority: Critical
Fix For: 3.1.0.M1
65 of our plugins are bundled exploded instead of a .jar
Some are probably just mistakes and can easily be packed others are because of legacy
code assuming it can access the files directly and even store data in the plugins - that
should be fixed.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:50 a.m.
New subject: [JBoss JIRA] Updated: (JBIDE-3628) Plugins should be .jar's not directories for efficency sake
[
https://jira.jboss.org/jira/browse/JBIDE-3628?page=com.atlassian.jira.plu...
]
Denis Golovin updated JBIDE-3628:
---------------------------------
What should be fixed:
1. The way how plug-ins use images in plugin.xml, in java code and in .meta xmodel files
2. Plug-ins that loads resources should be aware that they are in jar now (VPE should be
able to load templates from plugin jar files)
3. TBD
Plugins should be .jar's not directories for efficency sake
-----------------------------------------------------------
Key: JBIDE-3628
URL: https://jira.jboss.org/jira/browse/JBIDE-3628
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Build/Releng
Reporter: Max Rydahl Andersen
Assignee: Denis Golovin
Priority: Critical
Fix For: 3.1.0.M2
65 of our plugins are bundled exploded instead of a .jar
Some are probably just mistakes and can easily be packed others are because of legacy
code assuming it can access the files directly and even store data in the plugins - that
should be fixed.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:51 a.m.
New subject: [JBoss JIRA] Commented: (JBIDE-3628) Plugins should be .jar's not directories for efficency sake
[
https://jira.jboss.org/jira/browse/JBIDE-3628?page=com.atlassian.jira.plu...
]
Denis Golovin commented on JBIDE-3628:
--------------------------------------
I'm converting all plug-ins that is not using resources as it explained in
description, then we'll see what needs to be done for particular plug-ins
Plugins should be .jar's not directories for efficency sake
-----------------------------------------------------------
Key: JBIDE-3628
URL: https://jira.jboss.org/jira/browse/JBIDE-3628
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Build/Releng
Reporter: Max Rydahl Andersen
Assignee: Denis Golovin
Priority: Critical
Fix For: 3.1.0.M2
65 of our plugins are bundled exploded instead of a .jar
Some are probably just mistakes and can easily be packed others are because of legacy
code assuming it can access the files directly and even store data in the plugins - that
should be fixed.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:53 a.m.
New subject: [JBoss JIRA] Commented: (JBIDE-3628) Plugins should be .jar's not directories for efficency sake
[
https://jira.jboss.org/jira/browse/JBIDE-3628?page=com.atlassian.jira.plu...
]
Denis Golovin commented on JBIDE-3628:
--------------------------------------
Question is does that worth to commit something for M2 or do it after branch for m2 is
created?
Plugins should be .jar's not directories for efficency sake
-----------------------------------------------------------
Key: JBIDE-3628
URL: https://jira.jboss.org/jira/browse/JBIDE-3628
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Build/Releng
Reporter: Max Rydahl Andersen
Assignee: Denis Golovin
Priority: Critical
Fix For: 3.1.0.M2
65 of our plugins are bundled exploded instead of a .jar
Some are probably just mistakes and can easily be packed others are because of legacy
code assuming it can access the files directly and even store data in the plugins - that
should be fixed.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:02 a.m.
New subject: [JBoss JIRA] Updated: (JBIDE-3628) Plugins should be .jar's not directories for efficency sake
[
https://jira.jboss.org/jira/browse/JBIDE-3628?page=com.atlassian.jira.plu...
]
Denis Golovin updated JBIDE-3628:
---------------------------------
Description:
65 of our plugins are bundled exploded instead of a .jar
Some are probably just mistakes and can easily be packed others are because of legacy code
assuming it can access the files directly and even store data in the plugins - that should
be fixed.
What should be fixed:
1. The way how plug-ins use images in plugin.xml, in java code and in .meta xmodel files
2. Plug-ins that loads resources should be aware that they are in jar now (VPE should be
able to load templates from plugin jar files)
3. Some plug-ins contain resources registered in XML catalog
4. TBD
was:
65 of our plugins are bundled exploded instead of a .jar
Some are probably just mistakes and can easily be packed others are because of legacy code
assuming it can access the files directly and even store data in the plugins - that should
be fixed.
Plugins should be .jar's not directories for efficency sake
-----------------------------------------------------------
Key: JBIDE-3628
URL: https://jira.jboss.org/jira/browse/JBIDE-3628
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Build/Releng
Reporter: Max Rydahl Andersen
Assignee: Denis Golovin
Priority: Critical
Fix For: 3.1.0.M2
65 of our plugins are bundled exploded instead of a .jar
Some are probably just mistakes and can easily be packed others are because of legacy
code assuming it can access the files directly and even store data in the plugins - that
should be fixed.
What should be fixed:
1. The way how plug-ins use images in plugin.xml, in java code and in .meta xmodel files
2. Plug-ins that loads resources should be aware that they are in jar now (VPE should be
able to load templates from plugin jar files)
3. Some plug-ins contain resources registered in XML catalog
4. TBD
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:02 a.m.
New subject: [JBoss JIRA] Updated: (JBIDE-3628) Plugins should be .jar's not directories for efficency sake
[
https://jira.jboss.org/jira/browse/JBIDE-3628?page=com.atlassian.jira.plu...
]
Denis Golovin updated JBIDE-3628:
---------------------------------
Comment: was deleted
Plugins should be .jar's not directories for efficency sake
-----------------------------------------------------------
Key: JBIDE-3628
URL: https://jira.jboss.org/jira/browse/JBIDE-3628
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Build/Releng
Reporter: Max Rydahl Andersen
Assignee: Denis Golovin
Priority: Critical
Fix For: 3.1.0.M2
65 of our plugins are bundled exploded instead of a .jar
Some are probably just mistakes and can easily be packed others are because of legacy
code assuming it can access the files directly and even store data in the plugins - that
should be fixed.
What should be fixed:
1. The way how plug-ins use images in plugin.xml, in java code and in .meta xmodel files
2. Plug-ins that loads resources should be aware that they are in jar now (VPE should be
able to load templates from plugin jar files)
3. Some plug-ins contain resources registered in XML catalog
4. TBD
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:20 a.m.
New subject: [JBoss JIRA] Updated: (JBIDE-3628) Plugins should be .jar's not directories for efficency sake
[
https://jira.jboss.org/jira/browse/JBIDE-3628?page=com.atlassian.jira.plu...
]
Denis Golovin updated JBIDE-3628:
---------------------------------
Description:
65 of our plugins are bundled exploded instead of a .jar
Some are probably just mistakes and can easily be packed others are because of legacy code
assuming it can access the files directly and even store data in the plugins - that should
be fixed.
What should be fixed:
1. The way how plug-ins use images in plugin.xml, in java code and in .meta xmodel files
2. Plug-ins that loads resources should be aware that they are in jar now (VPE should be
able to load templates from plugin jar files)
3. Some plug-ins contain resources registered in XML catalog
4. common.projecttemplates contains resources that is used as template for new projects
5. TBD
was:
65 of our plugins are bundled exploded instead of a .jar
Some are probably just mistakes and can easily be packed others are because of legacy code
assuming it can access the files directly and even store data in the plugins - that should
be fixed.
What should be fixed:
1. The way how plug-ins use images in plugin.xml, in java code and in .meta xmodel files
2. Plug-ins that loads resources should be aware that they are in jar now (VPE should be
able to load templates from plugin jar files)
3. Some plug-ins contain resources registered in XML catalog
4. TBD
Plugins should be .jar's not directories for efficency sake
-----------------------------------------------------------
Key: JBIDE-3628
URL: https://jira.jboss.org/jira/browse/JBIDE-3628
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Build/Releng
Reporter: Max Rydahl Andersen
Assignee: Denis Golovin
Priority: Critical
Fix For: 3.1.0.M2
65 of our plugins are bundled exploded instead of a .jar
Some are probably just mistakes and can easily be packed others are because of legacy
code assuming it can access the files directly and even store data in the plugins - that
should be fixed.
What should be fixed:
1. The way how plug-ins use images in plugin.xml, in java code and in .meta xmodel files
2. Plug-ins that loads resources should be aware that they are in jar now (VPE should be
able to load templates from plugin jar files)
3. Some plug-ins contain resources registered in XML catalog
4. common.projecttemplates contains resources that is used as template for new projects
5. TBD
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:40 a.m.
New subject: [JBoss JIRA] Commented: (JBIDE-3628) Plugins should be .jar's not directories for efficency sake
[
https://jira.jboss.org/jira/browse/JBIDE-3628?page=com.atlassian.jira.plu...
]
Max Rydahl Andersen commented on JBIDE-3628:
--------------------------------------------
I say, get these in as early as possible to catch any subtle issues as soon as possible.
Plugins should be .jar's not directories for efficency sake
-----------------------------------------------------------
Key: JBIDE-3628
URL: https://jira.jboss.org/jira/browse/JBIDE-3628
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Build/Releng
Reporter: Max Rydahl Andersen
Assignee: Denis Golovin
Priority: Critical
Fix For: 3.1.0.M2
65 of our plugins are bundled exploded instead of a .jar
Some are probably just mistakes and can easily be packed others are because of legacy
code assuming it can access the files directly and even store data in the plugins - that
should be fixed.
What should be fixed:
1. The way how plug-ins use images in plugin.xml, in java code and in .meta xmodel files
2. Plug-ins that loads resources should be aware that they are in jar now (VPE should be
able to load templates from plugin jar files)
3. Some plug-ins contain resources registered in XML catalog
4. common.projecttemplates contains resources that is used as template for new projects
5. TBD
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:56 p.m.
New subject: [JBoss JIRA] Commented: (JBIDE-3628) Plugins should be .jar's not directories for efficency sake
[
https://jira.jboss.org/jira/browse/JBIDE-3628?page=com.atlassian.jira.plu...
]
Max Rydahl Andersen commented on JBIDE-3628:
--------------------------------------------
Last 2 builds failed after this got committed:
https://hudson.jboss.org/hudson/job/jbosstools-nightly-3.1.0.M2/277/ and
https://hudson.jboss.org/hudson/job/jbosstools-nightly-3.1.0.M2/278
I couldnt spot anything obvious in the console log but maybe we need to clean the
workspace since there might be traces of the unzipped result or something ?
Plugins should be .jar's not directories for efficency sake
-----------------------------------------------------------
Key: JBIDE-3628
URL: https://jira.jboss.org/jira/browse/JBIDE-3628
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Build/Releng
Reporter: Max Rydahl Andersen
Assignee: Denis Golovin
Priority: Critical
Fix For: 3.1.0.M2
65 of our plugins are bundled exploded instead of a .jar
Some are probably just mistakes and can easily be packed others are because of legacy
code assuming it can access the files directly and even store data in the plugins - that
should be fixed.
What should be fixed:
1. The way how plug-ins use images in plugin.xml, in java code and in .meta xmodel files
2. Plug-ins that loads resources should be aware that they are in jar now (VPE should be
able to load templates from plugin jar files)
3. Some plug-ins contain resources registered in XML catalog
4. common.projecttemplates contains resources that is used as template for new projects
5. TBD
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:16 a.m.
New subject: [JBoss JIRA] Commented: (JBIDE-3628) Plugins should be .jar's not directories for efficency sake
[
https://jira.jboss.org/jira/browse/JBIDE-3628?page=com.atlassian.jira.plu...
]
Denis Golovin commented on JBIDE-3628:
--------------------------------------
I'll check it again on local build, I must miss all those errors :(
Plugins should be .jar's not directories for efficency sake
-----------------------------------------------------------
Key: JBIDE-3628
URL: https://jira.jboss.org/jira/browse/JBIDE-3628
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Build/Releng
Reporter: Max Rydahl Andersen
Assignee: Denis Golovin
Priority: Critical
Fix For: 3.1.0.M2
65 of our plugins are bundled exploded instead of a .jar
Some are probably just mistakes and can easily be packed others are because of legacy
code assuming it can access the files directly and even store data in the plugins - that
should be fixed.
What should be fixed:
1. The way how plug-ins use images in plugin.xml, in java code and in .meta xmodel files
2. Plug-ins that loads resources should be aware that they are in jar now (VPE should be
able to load templates from plugin jar files)
3. Some plug-ins contain resources registered in XML catalog
4. common.projecttemplates contains resources that is used as template for new projects
5. TBD
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:44 a.m.
New subject: [JBoss JIRA] Updated: (JBIDE-3628) Plugins should be .jar's not directories for efficency sake
[
https://jira.jboss.org/jira/browse/JBIDE-3628?page=com.atlassian.jira.plu...
]
Denis Golovin updated JBIDE-3628:
---------------------------------
Fix Version/s: 3.1.0.M3
(was: 3.1.0.M2)
I fixed compilation errors and test errors. It seems to dangerous continue this task for
M2. Moved to M3.
Plugins should be .jar's not directories for efficency sake
-----------------------------------------------------------
Key: JBIDE-3628
URL: https://jira.jboss.org/jira/browse/JBIDE-3628
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Build/Releng
Reporter: Max Rydahl Andersen
Assignee: Denis Golovin
Priority: Critical
Fix For: 3.1.0.M3
65 of our plugins are bundled exploded instead of a .jar
Some are probably just mistakes and can easily be packed others are because of legacy
code assuming it can access the files directly and even store data in the plugins - that
should be fixed.
What should be fixed:
1. The way how plug-ins use images in plugin.xml, in java code and in .meta xmodel files
2. Plug-ins that loads resources should be aware that they are in jar now (VPE should be
able to load templates from plugin jar files)
3. Some plug-ins contain resources registered in XML catalog
4. common.projecttemplates contains resources that is used as template for new projects
5. TBD
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:02 a.m.
New subject: [JBoss JIRA] Updated: (JBIDE-3628) Plugins should be .jar's not directories for efficency sake
[
https://jira.jboss.org/jira/browse/JBIDE-3628?page=com.atlassian.jira.plu...
]
Maxim Areshkau updated JBIDE-3628:
----------------------------------
Attachment: exception.log
When VPE opens the following exception appears in console log.
Plugins should be .jar's not directories for efficency sake
-----------------------------------------------------------
Key: JBIDE-3628
URL: https://jira.jboss.org/jira/browse/JBIDE-3628
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Build/Releng
Reporter: Max Rydahl Andersen
Assignee: Denis Golovin
Priority: Critical
Fix For: 3.1.0.M3
Attachments: exception.log
65 of our plugins are bundled exploded instead of a .jar
Some are probably just mistakes and can easily be packed others are because of legacy
code assuming it can access the files directly and even store data in the plugins - that
should be fixed.
What should be fixed:
1. The way how plug-ins use images in plugin.xml, in java code and in .meta xmodel files
2. Plug-ins that loads resources should be aware that they are in jar now (VPE should be
able to load templates from plugin jar files)
3. Some plug-ins contain resources registered in XML catalog
4. common.projecttemplates contains resources that is used as template for new projects
5. TBD
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:42 a.m.
New subject: [JBoss JIRA] Updated: (JBIDE-3628) Plugins should be .jar's not directories for efficency sake
[
https://jira.jboss.org/jira/browse/JBIDE-3628?page=com.atlassian.jira.plu...
]
Denis Golovin updated JBIDE-3628:
---------------------------------
Fix Version/s: 3.1.0.M4
(was: 3.1.0.M3)
Plugins should be .jar's not directories for efficency sake
-----------------------------------------------------------
Key: JBIDE-3628
URL: https://jira.jboss.org/jira/browse/JBIDE-3628
Project: JBoss Tools
Issue Type: Feature Request
Components: Build/Releng
Reporter: Max Rydahl Andersen
Assignee: Denis Golovin
Priority: Critical
Fix For: 3.1.0.M4
Attachments: exception.log
65 of our plugins are bundled exploded instead of a .jar
Some are probably just mistakes and can easily be packed others are because of legacy
code assuming it can access the files directly and even store data in the plugins - that
should be fixed.
What should be fixed:
1. The way how plug-ins use images in plugin.xml, in java code and in .meta xmodel files
2. Plug-ins that loads resources should be aware that they are in jar now (VPE should be
able to load templates from plugin jar files)
3. Some plug-ins contain resources registered in XML catalog
4. common.projecttemplates contains resources that is used as template for new projects
5. TBD
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:46 a.m.
New subject: [JBoss JIRA] Updated: (JBIDE-3628) Plugins should be .jar's not directories for efficiency sake
[
https://jira.jboss.org/jira/browse/JBIDE-3628?page=com.atlassian.jira.plu...
]
Denis Golovin updated JBIDE-3628:
---------------------------------
Summary: Plugins should be .jar's not directories for efficiency sake (was:
Plugins should be .jar's not directories for efficency sake)
Plugins should be .jar's not directories for efficiency sake
------------------------------------------------------------
Key: JBIDE-3628
URL: https://jira.jboss.org/jira/browse/JBIDE-3628
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Build/Releng
Reporter: Max Rydahl Andersen
Assignee: Denis Golovin
Priority: Critical
Fix For: 3.1.0.M4
Attachments: exception.log
65 of our plugins are bundled exploded instead of a .jar
Some are probably just mistakes and can easily be packed others are because of legacy
code assuming it can access the files directly and even store data in the plugins - that
should be fixed.
What should be fixed:
1. The way how plug-ins use images in plugin.xml, in java code and in .meta xmodel files
2. Plug-ins that loads resources should be aware that they are in jar now (VPE should be
able to load templates from plugin jar files)
3. Some plug-ins contain resources registered in XML catalog
4. common.projecttemplates contains resources that is used as template for new projects
5. TBD
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:41 a.m.
New subject: [JBoss JIRA] Commented: (JBIDE-3628) Plugins should be .jar's not directories for efficiency sake
[
https://jira.jboss.org/jira/browse/JBIDE-3628?page=com.atlassian.jira.plu...
]
Denis Golovin commented on JBIDE-3628:
--------------------------------------
32 left out of 138.
Plugins should be .jar's not directories for efficiency sake
------------------------------------------------------------
Key: JBIDE-3628
URL: https://jira.jboss.org/jira/browse/JBIDE-3628
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Build/Releng
Reporter: Max Rydahl Andersen
Assignee: Denis Golovin
Priority: Critical
Fix For: 3.1.0.M4
Attachments: exception.log
65 of our plugins are bundled exploded instead of a .jar
Some are probably just mistakes and can easily be packed others are because of legacy
code assuming it can access the files directly and even store data in the plugins - that
should be fixed.
What should be fixed:
1. The way how plug-ins use images in plugin.xml, in java code and in .meta xmodel files
2. Plug-ins that loads resources should be aware that they are in jar now (VPE should be
able to load templates from plugin jar files)
3. Some plug-ins contain resources registered in XML catalog
4. common.projecttemplates contains resources that is used as template for new projects
5. TBD
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:29 a.m.
New subject: [JBoss JIRA] Commented: (JBIDE-3628) Plugins should be .jar's not directories for efficiency sake
[
https://jira.jboss.org/jira/browse/JBIDE-3628?page=com.atlassian.jira.plu...
]
Rob Stryker commented on JBIDE-3628:
------------------------------------
Changes on this issue added $nl$/ to my plugin.xml for my image locations and then my
images didn't work anymore. I had to fix them myself. Why is this bug modifying the
image path?
Plugins should be .jar's not directories for efficiency sake
------------------------------------------------------------
Key: JBIDE-3628
URL: https://jira.jboss.org/jira/browse/JBIDE-3628
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Build/Releng
Reporter: Max Rydahl Andersen
Assignee: Denis Golovin
Priority: Critical
Fix For: 3.1.0.M4
Attachments: exception.log
65 of our plugins are bundled exploded instead of a .jar
Some are probably just mistakes and can easily be packed others are because of legacy
code assuming it can access the files directly and even store data in the plugins - that
should be fixed.
What should be fixed:
1. The way how plug-ins use images in plugin.xml, in java code and in .meta xmodel files
2. Plug-ins that loads resources should be aware that they are in jar now (VPE should be
able to load templates from plugin jar files)
3. Some plug-ins contain resources registered in XML catalog
4. common.projecttemplates contains resources that is used as template for new projects
5. TBD
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:53 a.m.
New subject: [JBoss JIRA] Updated: (JBIDE-3628) Plugins should be .jar's not directories for efficiency sake
[
https://jira.jboss.org/jira/browse/JBIDE-3628?page=com.atlassian.jira.plu...
]
Denis Golovin updated JBIDE-3628:
---------------------------------
Fix Version/s: 3.1.0.CR1
(was: 3.1.0.M4)
Plugins should be .jar's not directories for efficiency sake
------------------------------------------------------------
Key: JBIDE-3628
URL: https://jira.jboss.org/jira/browse/JBIDE-3628
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Build/Releng
Reporter: Max Rydahl Andersen
Assignee: Denis Golovin
Priority: Critical
Fix For: 3.1.0.CR1
Attachments: exception.log
65 of our plugins are bundled exploded instead of a .jar
Some are probably just mistakes and can easily be packed others are because of legacy
code assuming it can access the files directly and even store data in the plugins - that
should be fixed.
What should be fixed:
1. The way how plug-ins use images in plugin.xml, in java code and in .meta xmodel files
2. Plug-ins that loads resources should be aware that they are in jar now (VPE should be
able to load templates from plugin jar files)
3. Some plug-ins contain resources registered in XML catalog
4. common.projecttemplates contains resources that is used as template for new projects
5. TBD
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:59 a.m.
New subject: [JBoss JIRA] Commented: (JBIDE-3628) Plugins should be .jar's not directories for efficiency sake
[
https://jira.jboss.org/jira/browse/JBIDE-3628?page=com.atlassian.jira.plu...
]
Denis Golovin commented on JBIDE-3628:
--------------------------------------
That happens not because $nl$ but because you have a glaring error in NoideContribution:
54 URL iconURL = iconPath == null ? null : FileLocator.find(bundle, new Path(iconPath),
null);
55 if (iconURL != null) {
56 iconURL = bundle.getEntry(iconPath);
57 icon = ImageDescriptor.createFromURL(iconURL);
58 }
why do you ask for twice for for icon URL here?
If path is "icons/file.gif" it init iconURL variable twice because
FileLocator.find returns it and then it goes inside if and bundle.getEntry does the same.
But if path is "$nl$/icon/file.gif" FileLocator.find returns url to icon and it
is not null because it aware of $nl$ variable (as Javadoc says) and then it goes to
bundle.getEntry which is oblivious to any $XX$ variables. The result is an overriding
correct URL in iconURL with null.
Plugins should be .jar's not directories for efficiency sake
------------------------------------------------------------
Key: JBIDE-3628
URL: https://jira.jboss.org/jira/browse/JBIDE-3628
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Build/Releng
Reporter: Max Rydahl Andersen
Assignee: Denis Golovin
Priority: Critical
Fix For: 3.1.0.CR1
Attachments: exception.log
65 of our plugins are bundled exploded instead of a .jar
Some are probably just mistakes and can easily be packed others are because of legacy
code assuming it can access the files directly and even store data in the plugins - that
should be fixed.
What should be fixed:
1. The way how plug-ins use images in plugin.xml, in java code and in .meta xmodel files
2. Plug-ins that loads resources should be aware that they are in jar now (VPE should be
able to load templates from plugin jar files)
3. Some plug-ins contain resources registered in XML catalog
4. common.projecttemplates contains resources that is used as template for new projects
5. TBD
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:22 a.m.
New subject: [JBoss JIRA] Updated: (JBIDE-3628) Plugins should be .jar's not directories for efficiency sake
[
https://jira.jboss.org/jira/browse/JBIDE-3628?page=com.atlassian.jira.plu...
]
Denis Golovin updated JBIDE-3628:
---------------------------------
Fix Version/s: 3.1.0.GA
(was: 3.1.0.CR1)
Plugins should be .jar's not directories for efficiency sake
------------------------------------------------------------
Key: JBIDE-3628
URL: https://jira.jboss.org/jira/browse/JBIDE-3628
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Build/Releng
Reporter: Max Rydahl Andersen
Assignee: Denis Golovin
Priority: Critical
Fix For: 3.1.0.GA
Attachments: exception.log
65 of our plugins are bundled exploded instead of a .jar
Some are probably just mistakes and can easily be packed others are because of legacy
code assuming it can access the files directly and even store data in the plugins - that
should be fixed.
What should be fixed:
1. The way how plug-ins use images in plugin.xml, in java code and in .meta xmodel files
2. Plug-ins that loads resources should be aware that they are in jar now (VPE should be
able to load templates from plugin jar files)
3. Some plug-ins contain resources registered in XML catalog
4. common.projecttemplates contains resources that is used as template for new projects
5. TBD
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:41 a.m.
New subject: [JBoss JIRA] Updated: (JBIDE-3628) Plugins should be .jar's not directories for efficiency sake
[
https://jira.jboss.org/jira/browse/JBIDE-3628?page=com.atlassian.jira.plu...
]
Denis Golovin updated JBIDE-3628:
---------------------------------
Fix Version/s: 3.2.next
(was: 3.1.0.CR2)
Plugins should be .jar's not directories for efficiency sake
------------------------------------------------------------
Key: JBIDE-3628
URL: https://jira.jboss.org/jira/browse/JBIDE-3628
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Build/Releng
Reporter: Max Rydahl Andersen
Assignee: Denis Golovin
Priority: Critical
Fix For: 3.2.next
Attachments: exception.log
65 of our plugins are bundled exploded instead of a .jar
Some are probably just mistakes and can easily be packed others are because of legacy
code assuming it can access the files directly and even store data in the plugins - that
should be fixed.
What should be fixed:
1. The way how plug-ins use images in plugin.xml, in java code and in .meta xmodel files
2. Plug-ins that loads resources should be aware that they are in jar now (VPE should be
able to load templates from plugin jar files)
3. Some plug-ins contain resources registered in XML catalog
4. common.projecttemplates contains resources that is used as template for new projects
5. TBD
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:32 a.m.
New subject: [JBoss JIRA] Updated: (JBIDE-3628) Plugins should be .jar's not directories for efficiency sake
[
https://jira.jboss.org/browse/JBIDE-3628?page=com.atlassian.jira.plugin.s...
]
Denis Golovin updated JBIDE-3628:
---------------------------------
Fix Version/s: 3.2.0.Beta
(was: 3.2.x)
Plugins should be .jar's not directories for efficiency sake
------------------------------------------------------------
Key: JBIDE-3628
URL: https://jira.jboss.org/browse/JBIDE-3628
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Build/Releng
Reporter: Max Rydahl Andersen
Assignee: Denis Golovin
Priority: Critical
Fix For: 3.2.0.Beta
Attachments: exception.log
65 of our plugins are bundled exploded instead of a .jar
Some are probably just mistakes and can easily be packed others are because of legacy
code assuming it can access the files directly and even store data in the plugins - that
should be fixed.
What should be fixed:
1. The way how plug-ins use images in plugin.xml, in java code and in .meta xmodel files
2. Plug-ins that loads resources should be aware that they are in jar now (VPE should be
able to load templates from plugin jar files)
3. Some plug-ins contain resources registered in XML catalog
4. common.projecttemplates contains resources that is used as template for new projects
5. TBD
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:34 p.m.
New subject: [JBoss JIRA] Updated: (JBIDE-3628) Plugins should be .jar's not directories for efficiency sake
[
https://jira.jboss.org/browse/JBIDE-3628?page=com.atlassian.jira.plugin.s...
]
Denis Golovin updated JBIDE-3628:
---------------------------------
Fix Version/s: 3.2.0.Beta2
(was: 3.2.0.Beta1)
Plugins should be .jar's not directories for efficiency sake
------------------------------------------------------------
Key: JBIDE-3628
URL: https://jira.jboss.org/browse/JBIDE-3628
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Build/Releng
Reporter: Max Andersen
Assignee: Denis Golovin
Priority: Critical
Fix For: 3.2.0.Beta2
Attachments: exception.log
65 of our plugins are bundled exploded instead of a .jar
Some are probably just mistakes and can easily be packed others are because of legacy
code assuming it can access the files directly and even store data in the plugins - that
should be fixed.
What should be fixed:
1. The way how plug-ins use images in plugin.xml, in java code and in .meta xmodel files
2. Plug-ins that loads resources should be aware that they are in jar now (VPE should be
able to load templates from plugin jar files)
3. Some plug-ins contain resources registered in XML catalog
4. common.projecttemplates contains resources that is used as template for new projects
5. TBD
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:32 a.m.
New subject: [JBoss JIRA] Updated: (JBIDE-3628) Plugins should be .jar's not directories for efficiency sake
[
https://jira.jboss.org/browse/JBIDE-3628?page=com.atlassian.jira.plugin.s...
]
Denis Golovin updated JBIDE-3628:
---------------------------------
Fix Version/s: 3.3.x
(was: 3.2.0.Beta2)
Plugins should be .jar's not directories for efficiency sake
------------------------------------------------------------
Key: JBIDE-3628
URL: https://jira.jboss.org/browse/JBIDE-3628
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Build/Releng
Reporter: Max Andersen
Assignee: Denis Golovin
Priority: Critical
Fix For: 3.3.x
Attachments: exception.log
65 of our plugins are bundled exploded instead of a .jar
Some are probably just mistakes and can easily be packed others are because of legacy
code assuming it can access the files directly and even store data in the plugins - that
should be fixed.
What should be fixed:
1. The way how plug-ins use images in plugin.xml, in java code and in .meta xmodel files
2. Plug-ins that loads resources should be aware that they are in jar now (VPE should be
able to load templates from plugin jar files)
3. Some plug-ins contain resources registered in XML catalog
4. common.projecttemplates contains resources that is used as template for new projects
5. TBD
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:07 a.m.
New subject: [JBoss JIRA] (JBIDE-3628) Plugins should be .jar's not directories for efficiency sake
[
https://issues.jboss.org/browse/JBIDE-3628?page=com.atlassian.jira.plugin...
]
Denis Golovin updated JBIDE-3628:
---------------------------------
Fix Version/s: 4.0.0.Alpha2
(was: 4.0.0.Alpha1)
moved to 4.0.0.Alpha2
Plugins should be .jar's not directories for efficiency sake
------------------------------------------------------------
Key: JBIDE-3628
URL: https://issues.jboss.org/browse/JBIDE-3628
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Build/Releng
Reporter: Max Rydahl Andersen
Assignee: Denis Golovin
Priority: Critical
Fix For: 4.0.0.Alpha2
Attachments: exception.log
65 of our plugins are bundled exploded instead of a .jar
Some are probably just mistakes and can easily be packed others are because of legacy
code assuming it can access the files directly and even store data in the plugins - that
should be fixed.
What should be fixed:
1. The way how plug-ins use images in plugin.xml, in java code and in .meta xmodel files
2. Plug-ins that loads resources should be aware that they are in jar now (VPE should be
able to load templates from plugin jar files)
3. Some plug-ins contain resources registered in XML catalog
4. common.projecttemplates contains resources that is used as template for new projects
5. TBD
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:13 a.m.
New subject: [JBoss JIRA] (JBIDE-3628) Plugins should be .jar's not directories for efficiency sake
[
https://issues.jboss.org/browse/JBIDE-3628?page=com.atlassian.jira.plugin...
]
Denis Golovin updated JBIDE-3628:
---------------------------------
Fix Version/s: 4.0.x
(was: 4.0.0.Alpha2)
Plugins should be .jar's not directories for efficiency sake
------------------------------------------------------------
Key: JBIDE-3628
URL: https://issues.jboss.org/browse/JBIDE-3628
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Build/Releng
Reporter: Max Rydahl Andersen
Assignee: Denis Golovin
Priority: Critical
Fix For: 4.0.x
Attachments: exception.log
65 of our plugins are bundled exploded instead of a .jar
Some are probably just mistakes and can easily be packed others are because of legacy
code assuming it can access the files directly and even store data in the plugins - that
should be fixed.
What should be fixed:
1. The way how plug-ins use images in plugin.xml, in java code and in .meta xmodel files
2. Plug-ins that loads resources should be aware that they are in jar now (VPE should be
able to load templates from plugin jar files)
3. Some plug-ins contain resources registered in XML catalog
4. common.projecttemplates contains resources that is used as template for new projects
5. TBD
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:58 a.m.
New subject: [JBoss JIRA] (JBIDE-3628) Plugins should be .jar's not directories for efficiency sake
[
https://issues.jboss.org/browse/JBIDE-3628?page=com.atlassian.jira.plugin...
]
Denis Golovin updated JBIDE-3628:
---------------------------------
Fix Version/s: 4.1.x
(was: 4.0.x)
Plugins should be .jar's not directories for efficiency sake
------------------------------------------------------------
Key: JBIDE-3628
URL: https://issues.jboss.org/browse/JBIDE-3628
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Build/Releng
Reporter: Max Rydahl Andersen
Assignee: Denis Golovin
Priority: Critical
Fix For: 4.1.x
Attachments: exception.log
65 of our plugins are bundled exploded instead of a .jar
Some are probably just mistakes and can easily be packed others are because of legacy
code assuming it can access the files directly and even store data in the plugins - that
should be fixed.
What should be fixed:
1. The way how plug-ins use images in plugin.xml, in java code and in .meta xmodel files
2. Plug-ins that loads resources should be aware that they are in jar now (VPE should be
able to load templates from plugin jar files)
3. Some plug-ins contain resources registered in XML catalog
4. common.projecttemplates contains resources that is used as template for new projects
5. TBD
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
4177
days inactive
5573
days old
jbosstools-issues@lists.jboss.org
26 comments
4 participants
participants (4)
-
Denis Golovin (JIRA) -
Max Rydahl Andersen (JIRA)
-
Maxim Areshkau (JIRA)
-
Rob Stryker (JIRA)