[JBoss JIRA] (JBIDE-13033) When server editor is closed and opened Deployment tab is enabled even if it should not
3:37 a.m.
Martin Malina created JBIDE-13033:
-------------------------------------
Summary: When server editor is closed and opened Deployment tab is enabled
even if it should not
Key: JBIDE-13033
URL: https://issues.jboss.org/browse/JBIDE-13033
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: JBossAS/Servers
Affects Versions: 4.0.0.Beta2
Environment: JBT 4.0.0.Beta2 B43
Reporter: Martin Malina
Assignee: Rob Stryker
Fix For: 4.0.0.CR1
Not sure how you control the disabling of the Deployment tab, but it doesn't always
work correctly.
When it's disabled and you reopen (close&open) the server editor it is enabled
again.
Also the comment at the top of the Deployment tab says:
"Settings on this page may only be modified if the server has 0 modules and is fully
synchronized."
- this is not totally accurate - should have something like: "or the server is
stopped"
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:09 a.m.
[
https://issues.jboss.org/browse/JBIDE-13033?page=com.atlassian.jira.plugi...
]
Rob Stryker resolved JBIDE-13033.
---------------------------------
Resolution: Done
whether the server is stopped or not is not relevent. Only if the server has 0 modules and
is fully synchronized should the enablement be true.
The issue here was that on a re-opening of the editor, it never sets the initial state.
This has been fixed pushed to cr1
When server editor is closed and opened Deployment tab is enabled
even if it should not
---------------------------------------------------------------------------------------
Key: JBIDE-13033
URL: https://issues.jboss.org/browse/JBIDE-13033
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: JBossAS/Servers
Affects Versions: 4.0.0.Beta2
Environment: JBT 4.0.0.Beta2 B43
Reporter: Martin Malina
Assignee: Rob Stryker
Fix For: 4.0.0.CR1
Not sure how you control the disabling of the Deployment tab, but it doesn't always
work correctly.
When it's disabled and you reopen (close&open) the server editor it is enabled
again.
Also the comment at the top of the Deployment tab says:
"Settings on this page may only be modified if the server has 0 modules and is fully
synchronized."
- this is not totally accurate - should have something like: "or the server is
stopped"
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:43 a.m.
[
https://issues.jboss.org/browse/JBIDE-13033?page=com.atlassian.jira.plugi...
]
Martin Malina commented on JBIDE-13033:
---------------------------------------
I have one question here: Why not enable the editor when server is stopped (but there are
deployments)? You could argue that if the module is already deployed and you stop the
server and modify the deployment path it will break on the next start of the server. But
the same happens if you remove the deployment while stopped, modify the settings and then
add the deployment again - we don't prevent that.
When server editor is closed and opened Deployment tab is enabled
even if it should not
---------------------------------------------------------------------------------------
Key: JBIDE-13033
URL: https://issues.jboss.org/browse/JBIDE-13033
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: JBossAS/Servers
Affects Versions: 4.0.0.Beta2
Environment: JBT 4.0.0.Beta2 B43
Reporter: Martin Malina
Assignee: Rob Stryker
Fix For: 4.0.0.CR1
Not sure how you control the disabling of the Deployment tab, but it doesn't always
work correctly.
When it's disabled and you reopen (close&open) the server editor it is enabled
again.
Also the comment at the top of the Deployment tab says:
"Settings on this page may only be modified if the server has 0 modules and is fully
synchronized."
- this is not totally accurate - should have something like: "or the server is
stopped"
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:22 a.m.
[
https://issues.jboss.org/browse/JBIDE-13033?page=com.atlassian.jira.plugi...
]
Rob Stryker resolved JBIDE-13033.
---------------------------------
Resolution: Done
Hi Martin:
Let's say you have a deployed DynWeb1.war. The editor is disabled. In order to change
the value, you must:
1) Remove the module from the server
2) Click publish
3) modify value in editor to Dynweb2.war
4) save editor
5) republish with new value
The editor will not be re-enabled until step 2 is done. Step 2 ensures that
{appserver_home}/standalone/deployments/DynWeb1.war is REMOVED. Then, the next publish at
step 5) will publish the war as DynWeb2.war.
The end result is that dynweb.war is removed and DynWeb2.war is added.
But the same happens if you remove the deployment while stopped,
modify the settings and then add the deployment again - we don't prevent that.
This is where you are wrong. Removing the deployment will not re-enable the editor until
you publish (thus removing the remote copy with the first name).
So, that's why it is the way it is now ;)
When server editor is closed and opened Deployment tab is enabled
even if it should not
---------------------------------------------------------------------------------------
Key: JBIDE-13033
URL: https://issues.jboss.org/browse/JBIDE-13033
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: JBossAS/Servers
Affects Versions: 4.0.0.Beta2
Environment: JBT 4.0.0.Beta2 B43
Reporter: Martin Malina
Assignee: Rob Stryker
Fix For: 4.0.0.CR1
Not sure how you control the disabling of the Deployment tab, but it doesn't always
work correctly.
When it's disabled and you reopen (close&open) the server editor it is enabled
again.
Also the comment at the top of the Deployment tab says:
"Settings on this page may only be modified if the server has 0 modules and is fully
synchronized."
- this is not totally accurate - should have something like: "or the server is
stopped"
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:55 a.m.
[
https://issues.jboss.org/browse/JBIDE-13033?page=com.atlassian.jira.plugi...
]
Martin Malina commented on JBIDE-13033:
---------------------------------------
You're right, when you remove a deployed module on a stopped server, the Publish
button removes it - I didn't know that. But that shows something - when you remove a
module shouldn't it be removed right away?
Consider this:
When you copy a deployment on a stopped server, it is copied there right away.
When you remove a deployment from a stopped server, it is not removed right away - you
need to click Publish. Can we change that? So that the "unpublish" of the
removed module is done immediately? If you agree I'll create a JIRA for that.
So the above is my only remaining concern here. Otherwise you're right and I was wrong
:)
When server editor is closed and opened Deployment tab is enabled
even if it should not
---------------------------------------------------------------------------------------
Key: JBIDE-13033
URL: https://issues.jboss.org/browse/JBIDE-13033
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: JBossAS/Servers
Affects Versions: 4.0.0.Beta2
Environment: JBT 4.0.0.Beta2 B43
Reporter: Martin Malina
Assignee: Rob Stryker
Fix For: 4.0.0.CR1
Not sure how you control the disabling of the Deployment tab, but it doesn't always
work correctly.
When it's disabled and you reopen (close&open) the server editor it is enabled
again.
Also the comment at the top of the Deployment tab says:
"Settings on this page may only be modified if the server has 0 modules and is fully
synchronized."
- this is not totally accurate - should have something like: "or the server is
stopped"
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:32 p.m.
[
https://issues.jboss.org/browse/JBIDE-13033?page=com.atlassian.jira.plugi...
]
Max Rydahl Andersen commented on JBIDE-13033:
---------------------------------------------
removal of modules are done lazy to avoid accidental deletion.
When server editor is closed and opened Deployment tab is enabled
even if it should not
---------------------------------------------------------------------------------------
Key: JBIDE-13033
URL: https://issues.jboss.org/browse/JBIDE-13033
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: JBossAS/Servers
Affects Versions: 4.0.0.Beta2
Environment: JBT 4.0.0.Beta2 B43
Reporter: Martin Malina
Assignee: Rob Stryker
Fix For: 4.0.0.CR1
Not sure how you control the disabling of the Deployment tab, but it doesn't always
work correctly.
When it's disabled and you reopen (close&open) the server editor it is enabled
again.
Also the comment at the top of the Deployment tab says:
"Settings on this page may only be modified if the server has 0 modules and is fully
synchronized."
- this is not totally accurate - should have something like: "or the server is
stopped"
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:17 a.m.
[
https://issues.jboss.org/browse/JBIDE-13033?page=com.atlassian.jira.plugi...
]
Martin Malina closed JBIDE-13033.
---------------------------------
OK, thanks Max. In that case it's all as it should be and I'm closing this JIRA.
When server editor is closed and opened Deployment tab is enabled
even if it should not
---------------------------------------------------------------------------------------
Key: JBIDE-13033
URL: https://issues.jboss.org/browse/JBIDE-13033
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: JBossAS/Servers
Affects Versions: 4.0.0.Beta2
Environment: JBT 4.0.0.Beta2 B43
Reporter: Martin Malina
Assignee: Rob Stryker
Fix For: 4.0.0.CR1
Not sure how you control the disabling of the Deployment tab, but it doesn't always
work correctly.
When it's disabled and you reopen (close&open) the server editor it is enabled
again.
Also the comment at the top of the Deployment tab says:
"Settings on this page may only be modified if the server has 0 modules and is fully
synchronized."
- this is not totally accurate - should have something like: "or the server is
stopped"
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
4885
days inactive
4900
days old
jbosstools-issues@lists.jboss.org
6 comments
3 participants
participants (3)
-
Martin Malina (JIRA) -
Max Rydahl Andersen (JIRA)
-
Rob Stryker (JIRA)