[ http://jira.jboss.com/jira/browse/JBIDE-1479?page=all ] Max Andersen updated JBIDE-1479: -------------------------------- Fix Version/s: 2.0.1 Assignee: Sergey Vasilyev something we can fix ? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBIDE-1479?page=comments#action_12394455 ] Snjezana Peco commented on JBIDE-1479: -------------------------------------- In order to reproduce the issue, you can try the following test case: - create a Seam project - import all the files from http://jira.jboss.com/jira/secure/attachment/12315941/JBIDE-675.tar.gz to the WebContent directory This step has to be repeated if you want to reproduce the issue after formatting - open employee.xhtml or pdataEdit.xhtml - select the opened file or WebContent directory in the Package Explorer and choose Source>Format You will get one of the following issues: - Eclipse crashes - Eclipse freezes - the Visual Editor breaks (the visual part is empty) Closing/opening the VPE editor doesn't help. The Mozilla browser is broken (it takes forever to load). You have to restart Eclipse. The problem is that the "Format" action notifies INodeAdapter in the non-UI thread. The solution is to call VpeController.notifyChanged in the UI thread (Display.async). However, there are some more issues. They are the following: - The OverviewRuler.redraw() method calls the StyledText.getLineAtOffset() method with an incorrect offset. I have fixed this in the way the FreeCaretStyledText.redrawRange() method is fixed. - if the opened file is large (employee.xhtml) and you format the WebContent directory, the "Format" action will send a lot of events and Eclipse will freeze I have fixed this issue in the following way (there are probably some other ways to solve it) : VpeController.notifyChanged is executed in the UIJob. The job is scheduled to be run after1000 ms delay. The old job is canceled if a new job needs to be started within 1000 ms. A job flooding is avoided in this way. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBIDE-1479?page=comments#action_12395202 ] Max Andersen commented on JBIDE-1479: ------------------------------------- Sergey - could you try and see if we could get that patch in ? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBIDE-1479?page=all ] Maxim Areshkau updated JBIDE-1479: ---------------------------------- Attachment: hs_err_pid1912.log Log with violation access exception when we trying to modify in non ui thread. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBIDE-1479?page=comments#action_12395639 ] Maxim Areshkau commented on JBIDE-1479: --------------------------------------- No, I am still working on it. Could you, please, show me steps to reproduce issue what was fixed with org.jboss.tools.common.text.xml.patch? About org.jboss.tools.vpe1.patch, I have looked into this and have applied with some modifications. You can see my changes in svn and make some comments. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBIDE-1479?page=comments#action_12395769 ] Snjezana Peco commented on JBIDE-1479: -------------------------------------- I have reviewed the modified patch on svn. It solves the basic issue. You haven't applied org.jboss.tools.common.text.xml.patch that fixes the following exception in the StyledWdiget class: Caused by: java.lang.IllegalArgumentException: Index out of bounds at org.eclipse.swt.SWT.error(SWT.java:3547) at org.eclipse.swt.SWT.error(SWT.java:3481) at org.eclipse.swt.SWT.error(SWT.java:3452) at org.eclipse.swt.custom.StyledText.getLineAtOffset(StyledText.java:3399) at org.eclipse.jface.text.source.OverviewRuler.doPaint1(OverviewRuler.java:734) at org.eclipse.jface.text.source.OverviewRuler.doubleBufferPaint(OverviewRuler.java:558) at org.eclipse.jface.text.source.OverviewRuler.redraw(OverviewRuler.java:784) at org.eclipse.jface.text.source.OverviewRuler.access$2(OverviewRuler.java:778) at org.eclipse.jface.text.source.OverviewRuler$1.run(OverviewRuler.java:387) at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35) at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:123) ... 23 more The steps to reproduce the exception: - create Seam project - import all the files from http://jira.jboss.com/jira/secure/attachment/12315941/JBIDE-675.tar.gz to the WebContent directory This step has to be repeated if you want to reproduce the issue after formatting - open pdataEdit.xhtml - select pdataEdit in the Package Explorer and choose Source>Format I also suggest adding the following code to the start of the notifyChanged method : Display display = null; if (PlatformUI.isWorkbenchRunning()) display= PlatformUI.getWorkbench().getDisplay(); if (display != null && (Thread.currentThread() == display.getThread())) { notifyChangedInUiThread(notifier, eventType, feature, oldValue, newValue, pos); return; } In this way, the UIJob will start only if notifyChanged is called in non-UI thread what introduces minimal changes. Without adding this code, you will notice a delay of 1 sec when typing in the source editor. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-1479?page=com.atlassian.jira.plu... ] Aliaksey Nis closed JBIDE-1479. ------------------------------- Verified in JBoss Tools 200809010011-nightly -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira