[ https://jira.jboss.org/jira/browse/JBIDE-4307?page=com.atlassian.jira.plu... ] Max Rydahl Andersen updated JBIDE-4307: --------------------------------------- Component/s: JBossAS -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-4307?page=com.atlassian.jira.plu... ] Rob Stryker commented on JBIDE-4307: ------------------------------------ xpaths are a pretty old part of my code and need to be refactored a bit. There's code in the UI to allow for a fileset of sorts for each xpath, so that scanner doesn't have to scan every singlke xml file hoping to find your path. This way you can narrow it down a bit. But that code is not clean, and is not actually SHOWN visibly to the user. So... I would say the wizard should be redone in a title area dialog. As for relative to the server, since this is not an often used feature (as it's not exposed to the user, so it's all secret) it shouldn't be too hard to change those paths. The danger, of course, being that old paths no longer work. so care will need to be taken to maintain backwards compat. at LEAST from the point of view of the user. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-4307?page=com.atlassian.jira.plu... ] Rob Stryker commented on JBIDE-4307: ------------------------------------ currently the xml file the xpaths are stored in has something like the following: <query attribute="port" dir="/home/rob/apps/jboss/jboss-soa-p.4.3.0/jboss-as/server/default" filePattern="**/*server.xml" name="JBoss Web" xpathPattern=&quot;//Server/Service[@name=&#39;jboss.web&#39;]/Connector[count((a)sslProtocol) = 0 and (count(@protocol) = 0 or @protocol = 'HTTP/1.1')]"/> So the attributes are: 1) name (identifier for this xpath) 2) dir to start searching in 3) file pattern (optional, limits the scope of files to scan) 4) xpath pattern My idea is that if the dir is null it defaults to the server root -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-4307?page=com.atlassian.jira.plu... ] Rob Stryker resolved JBIDE-4307. -------------------------------- Fix Version/s: 3.1.0.M3 (was: LATER) Resolution: Done Labels: new_and_noteworthy (was: ) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-4307?page=com.atlassian.jira.plu... ] Rob Stryker resolved JBIDE-4307. -------------------------------- Resolution: Done that path is in the result set and is something that comes out of the ant directory scanner as a matched path which I can't control very well. I suppose I could just force it to be relative for visual purposes. However this JIRA was not dealing with the result set. It was dealing with the "root directory" section and allowing such relative paths in THAT field. (just did a check) turns out that field was just from a substring and was off by one. fixing doing new Path(whatever).makeRelative() to remove leading slashes. So to clarify a bit more, this jira was 100% related to the root directory, which can now be an absolute directory (/home/rob) or a server-relative path (server/default translates to /home/rob/apps/jboss/server/default) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira