[JBoss JIRA] (JBIDE-12902) Project runtime pref page modifies original model without call to performOK or performApply
11:44 a.m.
Rob Stryker created JBIDE-12902:
-----------------------------------
Summary: Project runtime pref page modifies original model without call to
performOK or performApply
Key: JBIDE-12902
URL: https://issues.jboss.org/browse/JBIDE-12902
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: runtime detection
Affects Versions: 4.0.0.Beta1
Reporter: Rob Stryker
Assignee: Rob Stryker
Fix For: 4.0.0.CR1
Add, edit, and remove, all edit the core model of runtime paths in this preference page.
Also, the preference page is often closed and re-opened when this doesn't need to
happen.
Possible fixes are
1) to ensure NO ONE saves a model until performOK or performApply is called,
2) keep track of if the page is dirty or not
3) show a dialog when clicking 'link' on a dirty page asking to save and re-open
the page
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:57 a.m.
[
https://issues.jboss.org/browse/JBIDE-12902?page=com.atlassian.jira.plugi...
]
Rob Stryker updated JBIDE-12902:
--------------------------------
Attachment: JBIDE-12902.patch
patch for cr1
Project runtime pref page modifies original model without call to
performOK or performApply
-------------------------------------------------------------------------------------------
Key: JBIDE-12902
URL: https://issues.jboss.org/browse/JBIDE-12902
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: runtime detection
Affects Versions: 4.0.0.Beta1
Reporter: Rob Stryker
Assignee: Rob Stryker
Fix For: 4.0.0.CR1
Attachments: JBIDE-12902.patch
Add, edit, and remove, all edit the core model of runtime paths in this preference page.
Also, the preference page is often closed and re-opened when this doesn't need to
happen.
Possible fixes are
1) to ensure NO ONE saves a model until performOK or performApply is called,
2) keep track of if the page is dirty or not
3) show a dialog when clicking 'link' on a dirty page asking to save and re-open
the page
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:59 a.m.
[
https://issues.jboss.org/browse/JBIDE-12902?page=com.atlassian.jira.plugi...
]
Rob Stryker updated JBIDE-12902:
--------------------------------
Attachment: JBIDE-12902a.patch
tiny change, moving the isDirty set flag to a position after a .equals
Project runtime pref page modifies original model without call to
performOK or performApply
-------------------------------------------------------------------------------------------
Key: JBIDE-12902
URL: https://issues.jboss.org/browse/JBIDE-12902
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: runtime detection
Affects Versions: 4.0.0.Beta1
Reporter: Rob Stryker
Assignee: Rob Stryker
Fix For: 4.0.0.CR1
Attachments: JBIDE-12902.patch, JBIDE-12902a.patch
Add, edit, and remove, all edit the core model of runtime paths in this preference page.
Also, the preference page is often closed and re-opened when this doesn't need to
happen.
Possible fixes are
1) to ensure NO ONE saves a model until performOK or performApply is called,
2) keep track of if the page is dirty or not
3) show a dialog when clicking 'link' on a dirty page asking to save and re-open
the page
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:03 p.m.
[
https://issues.jboss.org/browse/JBIDE-12902?page=com.atlassian.jira.plugi...
]
Rob Stryker updated JBIDE-12902:
--------------------------------
Attachment: JBIDE-12902.png
screenshot of msg dialog
Project runtime pref page modifies original model without call to
performOK or performApply
-------------------------------------------------------------------------------------------
Key: JBIDE-12902
URL: https://issues.jboss.org/browse/JBIDE-12902
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: runtime detection
Affects Versions: 4.0.0.Beta1
Reporter: Rob Stryker
Assignee: Rob Stryker
Fix For: 4.0.0.CR1
Attachments: JBIDE-12902.patch, JBIDE-12902.png, JBIDE-12902a.patch
Add, edit, and remove, all edit the core model of runtime paths in this preference page.
Also, the preference page is often closed and re-opened when this doesn't need to
happen.
Possible fixes are
1) to ensure NO ONE saves a model until performOK or performApply is called,
2) keep track of if the page is dirty or not
3) show a dialog when clicking 'link' on a dirty page asking to save and re-open
the page
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:13 p.m.
[
https://issues.jboss.org/browse/JBIDE-12902?page=com.atlassian.jira.plugi...
]
Max Rydahl Andersen commented on JBIDE-12902:
---------------------------------------------
the dialog text is not good.
Suggestion:
title: Open <type> preferences
body:
You have unsaved changes that needs to be saved to show <type> preferences.
Do you want to save these changes and open <type> preferences ?
Yes|No
Project runtime pref page modifies original model without call to
performOK or performApply
-------------------------------------------------------------------------------------------
Key: JBIDE-12902
URL: https://issues.jboss.org/browse/JBIDE-12902
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: runtime detection
Affects Versions: 4.0.0.Beta1
Reporter: Rob Stryker
Assignee: Rob Stryker
Fix For: 4.0.0.CR1
Attachments: JBIDE-12902.patch, JBIDE-12902.png, JBIDE-12902a.patch
Add, edit, and remove, all edit the core model of runtime paths in this preference page.
Also, the preference page is often closed and re-opened when this doesn't need to
happen.
Possible fixes are
1) to ensure NO ONE saves a model until performOK or performApply is called,
2) keep track of if the page is dirty or not
3) show a dialog when clicking 'link' on a dirty page asking to save and re-open
the page
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:50 p.m.
[
https://issues.jboss.org/browse/JBIDE-12902?page=com.atlassian.jira.plugi...
]
Rob Stryker updated JBIDE-12902:
--------------------------------
Attachment: JBIDE-12902b.patch
patch b for approves
Project runtime pref page modifies original model without call to
performOK or performApply
-------------------------------------------------------------------------------------------
Key: JBIDE-12902
URL: https://issues.jboss.org/browse/JBIDE-12902
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: runtime detection
Affects Versions: 4.0.0.Beta1
Reporter: Rob Stryker
Assignee: Rob Stryker
Fix For: 4.0.0.CR1
Attachments: JBIDE-12902.patch, JBIDE-12902.png, JBIDE-12902a.patch,
JBIDE-12902b.patch
Add, edit, and remove, all edit the core model of runtime paths in this preference page.
Also, the preference page is often closed and re-opened when this doesn't need to
happen.
Possible fixes are
1) to ensure NO ONE saves a model until performOK or performApply is called,
2) keep track of if the page is dirty or not
3) show a dialog when clicking 'link' on a dirty page asking to save and re-open
the page
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:48 p.m.
[
https://issues.jboss.org/browse/JBIDE-12902?page=com.atlassian.jira.plugi...
]
Rob Stryker resolved JBIDE-12902.
---------------------------------
Fix Version/s: 4.0.0.Beta2
(was: 4.0.0.CR1)
Resolution: Done
The attached patchb is obviously empty. I made only the changes max suggested in his last
comment to the text of the message box.
Use cases for QE:
1) Open runtime pref page, add new runtime path, then:
a) assert new runtime is added
b) press cancel
c) re-open pref page, assert:
1) runtime is still added in server view, but
2) runtime PATH is not on the pref page
2) create one runtime path, press ok, re-open runtime pref page, see one runtime path.
click "remove", click "cancel", re-open pref page, assert path still
there
3) create one runtime path, press ok, re-open runtime pref page, see one runtime path.
click "remove", click hyperlink next to JBossAS, assert message box appears.
a) If press no, assert dialog goes away, nothing happens
b) If press yes, assert preference dialog closes, re-opens on wtp runtime preference
page
Ensure that all the flashing and re-opening of the preference page dialog has stopped
except in example 3.
Project runtime pref page modifies original model without call to
performOK or performApply
-------------------------------------------------------------------------------------------
Key: JBIDE-12902
URL: https://issues.jboss.org/browse/JBIDE-12902
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: runtime-detection
Affects Versions: 4.0.0.Beta1
Reporter: Rob Stryker
Assignee: Rob Stryker
Fix For: 4.0.0.Beta2
Attachments: JBIDE-12902.patch, JBIDE-12902.png, JBIDE-12902a.patch,
JBIDE-12902b.patch
Add, edit, and remove, all edit the core model of runtime paths in this preference page.
Also, the preference page is often closed and re-opened when this doesn't need to
happen.
Possible fixes are
1) to ensure NO ONE saves a model until performOK or performApply is called,
2) keep track of if the page is dirty or not
3) show a dialog when clicking 'link' on a dirty page asking to save and re-open
the page
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:10 a.m.
[
https://issues.jboss.org/browse/JBIDE-12902?page=com.atlassian.jira.plugi...
]
Petr Suchý closed JBIDE-12902.
------------------------------
Verified on JBT 4.0.0.Beta2 v20121107-1252-B43
Project runtime pref page modifies original model without call to
performOK or performApply
-------------------------------------------------------------------------------------------
Key: JBIDE-12902
URL: https://issues.jboss.org/browse/JBIDE-12902
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: runtime-detection
Affects Versions: 4.0.0.Beta1
Reporter: Rob Stryker
Assignee: Rob Stryker
Fix For: 4.0.0.Beta2
Attachments: JBIDE-12902.patch, JBIDE-12902.png, JBIDE-12902a.patch,
JBIDE-12902b.patch
Add, edit, and remove, all edit the core model of runtime paths in this preference page.
Also, the preference page is often closed and re-opened when this doesn't need to
happen.
Possible fixes are
1) to ensure NO ONE saves a model until performOK or performApply is called,
2) keep track of if the page is dirty or not
3) show a dialog when clicking 'link' on a dirty page asking to save and re-open
the page
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
4918
days inactive
4943
days old
jbosstools-issues@lists.jboss.org
7 comments
3 participants
participants (3)
-
Max Rydahl Andersen (JIRA) -
Petr Suchý (JIRA)
-
Rob Stryker (JIRA)