[ https://issues.jboss.org/browse/JBIDE-8973?page=com.atlassian.jira.plugin... ] Fred Bricon updated JBIDE-8973: ------------------------------- Fix Version/s: 3.3.x (was: 3.3.0.M3) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-8973?page=com.atlassian.jira.plugin... ] Fred Bricon edited comment on JBIDE-8973 at 12/19/11 6:25 AM: -------------------------------------------------------------- So here are a few strategies we can apply to identify a jar : 1 : Check if the jar contains the maven metadata : {code} File jar = ... org.apache.maven.shared.runtime.MavenRuntime r = new DefaultMavenRuntime(); MavenProjectProperties projectProperties = r.getProjectProperties(jar.toURL()); {code} 3 : Identify via the Nexus indexer : {code} File jar = ... IndexedArtifactFile iaf= ((NexusIndexManager)MavenPlugin.getIndexManager()).identify(jar) {code} 4 : Identify via the JBoss Nexus instance REST API if we're online, via a SHA1 search.: Example in Groovy code (can be run in a GroovyConsole). {code} @Grab(group='org.codehaus.groovy.modules.http-builder', module='http-builder', version='0.5.1' ) import groovyx.net.http.* import static groovyx.net.http.ContentType.* import static groovyx.net.http.Method.* def http = new HTTPBuilder( 'https://repository.jboss.org' ) // perform a GET request, expecting JSON response data http.request( GET, JSON ) { uri.path = '/nexus/service/local/lucene/search' uri.query = [ sha1:"e6ddfa5d1d3613668bbc33ff344c887950c21f67" ] headers.'Accept' = 'application/json' // response handler for a success response code: response.success = { resp, json -> def a = json.data.artifactId[0] def g = json.data.groupId[0] def v = json.data.version[0] print "groupId:$g, artifactId:$a, version:$v" //prints groupId:org.mvel, artifactId:mvel, version:1.2.24-java1.4 } // handler for any failure status code: response.failure = { resp -> println "Unexpected error: ${resp.statusLine.statusCode} : ${resp.statusLine.reasonPhrase}" } } {code} Here the mvel file taken from a Seam 2 project can not be found on maven central. Calls to https://repository.jboss.org take > 1s for me 4b : Call http://search.maven.org/ REST API if we're online to perform a SHA1 search. Example in Groovy code (can be run in a GroovyConsole) {code} import groovy.json.* import groovy.time.* def slurper = new JsonSlurper() def sha1 = "5675fd96b29656504b86029551973d60fb41339b" def q = URLEncoder.encode("1:\"$sha1\"") def url = "http://search.maven.org/solrsearch/select?q=$q&rows=2&wt=json" def content = new URL(url).getText("UTF-8") def root = slurper.parseText(content) def docs = root.response.docs def a = root.response.docs.a[0] def g = root.response.docs.g[0] def v = root.response.docs.v[0] print "groupId:$g, artifactId:$a, version:$v" //prints groupId:commons-beanutils, artifactId:commons-beanutils, version:1.7.0 {code} Calls to search.maven.org take ~ 250ms for me was (Author: fbricon): So here are a few strategies we can apply to identify a jar : 1 : Check if the jar contains the maven metadata : {code} File jar = ... org.apache.maven.shared.runtime.MavenRuntime r = new DefaultMavenRuntime(); MavenProjectProperties projectProperties = r.getProjectProperties(jar.toURL()); {code} 3 : Identify via the Nexus indexer : {code} File jar = ... IndexedArtifactFile iaf= ((NexusIndexManager)MavenPlugin.getIndexManager()).identify(jar) {code} 4 : Identify via the JBoss Nexus instance REST API : Example in Groovy code (can be run in a GroovyConsole). {code} @Grab(group='org.codehaus.groovy.modules.http-builder', module='http-builder', version='0.5.1' ) import groovyx.net.http.* import static groovyx.net.http.ContentType.* import static groovyx.net.http.Method.* def http = new HTTPBuilder( 'https://repository.jboss.org' ) // perform a GET request, expecting JSON response data http.request( GET, JSON ) { uri.path = '/nexus/service/local/lucene/search' uri.query = [ sha1:"e6ddfa5d1d3613668bbc33ff344c887950c21f67" ] headers.'Accept' = 'application/json' // response handler for a success response code: response.success = { resp, json -> def a = json.data.artifactId[0] def g = json.data.groupId[0] def v = json.data.version[0] print "groupId:$g, artifactId:$a, version:$v" //prints groupId:org.mvel, artifactId:mvel, version:1.2.24-java1.4 } // handler for any failure status code: response.failure = { resp -> println "Unexpected error: ${resp.statusLine.statusCode} : ${resp.statusLine.reasonPhrase}" } } {code} Here the mvel file taken from a Seam 2 project can not be found on maven central. Calls to https://repository.jboss.org take > 1s for me 4b : Call http://search.maven.org/ REST API if we're online to perform a SHA1 search. Example in Groovy code (can be run in a GroovyConsole) {code} import groovy.json.* import groovy.time.* def slurper = new JsonSlurper() def sha1 = "5675fd96b29656504b86029551973d60fb41339b" def q = URLEncoder.encode("1:\"$sha1\"") def url = "http://search.maven.org/solrsearch/select?q=$q&rows=2&wt=json" def content = new URL(url).getText("UTF-8") def root = slurper.parseText(content) def docs = root.response.docs def a = root.response.docs.a[0] def g = root.response.docs.g[0] def v = root.response.docs.v[0] print "groupId:$g, artifactId:$a, version:$v" //prints groupId:commons-beanutils, artifactId:commons-beanutils, version:1.7.0 {code} Calls to search.maven.org take ~ 250ms for me -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-8973?page=com.atlassian.jira.plugin... ] Fred Bricon edited comment on JBIDE-8973 at 12/19/11 6:30 AM: -------------------------------------------------------------- So here are a few strategies we can apply to identify a jar : 1 : Check if the jar contains the maven metadata : {code} File jar = ... org.apache.maven.shared.runtime.MavenRuntime r = new DefaultMavenRuntime(); MavenProjectProperties projectProperties = r.getProjectProperties(jar.toURL()); {code} 3 : Identify via the Nexus indexer : {code} File jar = ... IndexedArtifactFile iaf= ((NexusIndexManager)MavenPlugin.getIndexManager()).identify(jar) {code} 4 : Identify via the JBoss Nexus instance REST API if we're online, via a SHA1 search.: Example in Groovy code (can be run in a GroovyConsole). {code} @Grab(group='org.codehaus.groovy.modules.http-builder', module='http-builder', version='0.5.1' ) import groovyx.net.http.* import static groovyx.net.http.ContentType.* import static groovyx.net.http.Method.* def http = new HTTPBuilder( 'https://repository.jboss.org' ) // perform a GET request, expecting JSON response data http.request( GET, JSON ) { uri.path = '/nexus/service/local/lucene/search' uri.query = [ sha1:"e6ddfa5d1d3613668bbc33ff344c887950c21f67" ] headers.'Accept' = 'application/json' // response handler for a success response code: response.success = { resp, json -> def a = json.data.artifactId[0] def g = json.data.groupId[0] def v = json.data.version[0] print "groupId:$g, artifactId:$a, version:$v" //prints groupId:org.mvel, artifactId:mvel, version:1.2.24-java1.4 } } {code} Here the mvel file taken from a Seam 2 project can not be found on maven central. Calls to https://repository.jboss.org take > 1s for me 4b : Call http://search.maven.org/ REST API if we're online to perform a SHA1 search. Example in Groovy code (can be run in a GroovyConsole) {code} import groovy.json.* def slurper = new JsonSlurper() def sha1 = "5675fd96b29656504b86029551973d60fb41339b" def q = URLEncoder.encode("1:\"$sha1\"") def url = "http://search.maven.org/solrsearch/select?q=$q&rows=2&wt=json" def content = new URL(url).getText("UTF-8") def root = slurper.parseText(content) def docs = root.response.docs def a = docs.a[0] def g = docs.g[0] def v = docs.v[0] print "groupId:$g, artifactId:$a, version:$v" //prints groupId:commons-beanutils, artifactId:commons-beanutils, version:1.7.0 {code} Calls to search.maven.org take ~ 250ms for me was (Author: fbricon): So here are a few strategies we can apply to identify a jar : 1 : Check if the jar contains the maven metadata : {code} File jar = ... org.apache.maven.shared.runtime.MavenRuntime r = new DefaultMavenRuntime(); MavenProjectProperties projectProperties = r.getProjectProperties(jar.toURL()); {code} 3 : Identify via the Nexus indexer : {code} File jar = ... IndexedArtifactFile iaf= ((NexusIndexManager)MavenPlugin.getIndexManager()).identify(jar) {code} 4 : Identify via the JBoss Nexus instance REST API if we're online, via a SHA1 search.: Example in Groovy code (can be run in a GroovyConsole). {code} @Grab(group='org.codehaus.groovy.modules.http-builder', module='http-builder', version='0.5.1' ) import groovyx.net.http.* import static groovyx.net.http.ContentType.* import static groovyx.net.http.Method.* def http = new HTTPBuilder( 'https://repository.jboss.org' ) // perform a GET request, expecting JSON response data http.request( GET, JSON ) { uri.path = '/nexus/service/local/lucene/search' uri.query = [ sha1:"e6ddfa5d1d3613668bbc33ff344c887950c21f67" ] headers.'Accept' = 'application/json' // response handler for a success response code: response.success = { resp, json -> def a = json.data.artifactId[0] def g = json.data.groupId[0] def v = json.data.version[0] print "groupId:$g, artifactId:$a, version:$v" //prints groupId:org.mvel, artifactId:mvel, version:1.2.24-java1.4 } } {code} Here the mvel file taken from a Seam 2 project can not be found on maven central. Calls to https://repository.jboss.org take > 1s for me 4b : Call http://search.maven.org/ REST API if we're online to perform a SHA1 search. Example in Groovy code (can be run in a GroovyConsole) {code} import groovy.json.* import groovy.time.* def slurper = new JsonSlurper() def sha1 = "5675fd96b29656504b86029551973d60fb41339b" def q = URLEncoder.encode("1:\"$sha1\"") def url = "http://search.maven.org/solrsearch/select?q=$q&rows=2&wt=json" def content = new URL(url).getText("UTF-8") def root = slurper.parseText(content) def docs = root.response.docs def a = docs.a[0] def g = docs.g[0] def v = docs.v[0] print "groupId:$g, artifactId:$a, version:$v" //prints groupId:commons-beanutils, artifactId:commons-beanutils, version:1.7.0 {code} Calls to search.maven.org take ~ 250ms for me -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-8973?page=com.atlassian.jira.plugin... ] Fred Bricon updated JBIDE-8973: ------------------------------- Attachment: identify_dependencies.png Attaching screenshot of current work in progress. Page 1 is all about dependency identification. Next page will show xml snippet preview. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-8973?page=com.atlassian.jira.plugin... ] Fred Bricon commented on JBIDE-8973: ------------------------------------ In order to test the current work in progress, you need to import org.jboss.tools.maven.conversion.ui in your workspace (not part of the maven core feature yet) and run Run As > Eclipse Application (a.k.a eclipse in hosted mode). The wizard is plugged to a project conversion participant (only active for java projects). Create a Dynamic web project, right click > Configure > Convert to Maven project. See http://screencast.com/t/D52i1zBR5Qg TODO : * Implement a preview page + copy to clipboard * Delete existing jars / classpath container (in a smart way) * Edit dependency on double-click * Support EAR dependencies (i.e. not classpath dependencies) * Support simple non java dependencies (outside the Convert to Maven project workflow) * Add this plugin to Maven Core feature -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-8973?page=com.atlassian.jira.plugin... ] Fred Bricon updated JBIDE-8973: ------------------------------- Description: Execute: right click on a non-maven project, and choose "Configure > Convert to Maven" Assert: UI is shown that shows which jars misses metadata and what can be automatically detected based on maven metadata in the jar. UI has option to classpath dependencies from project. Execute: Press Ok Assert: The selected dependencies are added to the generated pom.xml. was: Execute: multiple select lib dependencies, then right click and choose "Build path > Convert to Maven dependencies" Assert: UI is shown that shows which jars misses metadata and what can be automatically detected based on maven metadata in the jar. UI has option to delete jars from project. Execute: Press Ok Assert: The jars are removed from classpath container, and now available in the classpath container and if user chose to delete then the files are removed from the project. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-8973?page=com.atlassian.jira.plugin... ] Fred Bricon edited comment on JBIDE-8973 at 8/31/12 9:22 AM: ------------------------------------------------------------- In order to test the current work in progress, you need to import org.jboss.tools.maven.conversion.ui in your workspace (not part of the maven core feature yet) and run Run As > Eclipse Application (a.k.a eclipse in hosted mode). The wizard is plugged to a project conversion participant (only active for java projects). Create a Dynamic web project, right click > Configure > Convert to Maven project. See http://screencast.com/t/D52i1zBR5Qg TODO : * Implement a preview page + copy to clipboard * Delete existing jars / -classpath container- (in a smart way) * -Edit dependency on double-click- * Support EAR dependencies (i.e. not classpath dependencies) * Support simple non java dependencies (outside the Convert to Maven project workflow) * -Add this plugin to Maven Core feature- was (Author: fbricon): In order to test the current work in progress, you need to import org.jboss.tools.maven.conversion.ui in your workspace (not part of the maven core feature yet) and run Run As > Eclipse Application (a.k.a eclipse in hosted mode). The wizard is plugged to a project conversion participant (only active for java projects). Create a Dynamic web project, right click > Configure > Convert to Maven project. See http://screencast.com/t/D52i1zBR5Qg TODO : * Implement a preview page + copy to clipboard * Delete existing jars / classpath container (in a smart way) * Edit dependency on double-click * Support EAR dependencies (i.e. not classpath dependencies) * Support simple non java dependencies (outside the Convert to Maven project workflow) * Add this plugin to Maven Core feature -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-8973?page=com.atlassian.jira.plugin... ] Rastislav Wagner closed JBIDE-8973. ----------------------------------- verified in JBDS Alpha1-v20120904-0259-H12 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-8973?page=com.atlassian.jira.plugin... ] Fred Bricon commented on JBIDE-8973: ------------------------------------ no. We identify jars using their SHA1 signature. Not trying to do any suggestions. If the identified jars are actual *-redhat-* versions, they should be identified as such. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-8973?page=com.atlassian.jira.plugin... ] Isaac Rooskov closed JBIDE-8973. -------------------------------- Resolution: Done Re-closing issue now that release note status has been set. Thanks for the fantastic base release note text :D -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira