[ https://issues.jboss.org/browse/JBIDE-8863?page=com.atlassian.jira.plugin... ] Alexey Kazakov updated JBIDE-8863: ---------------------------------- Assignee: Rob Stryker (was: Max Rydahl Andersen) Component/s: JBossAS (was: core) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-8863?page=com.atlassian.jira.plugin... ] Max Rydahl Andersen commented on JBIDE-8863: -------------------------------------------- marking as critical since it on the surface sound like it might be a problematic issue with copying. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-8863?page=com.atlassian.jira.plugin... ] Andre Dietisheim edited comment on JBIDE-8863 at 5/27/11 6:01 AM: ------------------------------------------------------------------ added projects archive so that you wont have to recreate it was (Author: adietish): added projects archive so that you wont have to recreate it each time -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-8863?page=com.atlassian.jira.plugin... ] Andre Dietisheim updated JBIDE-8863: ------------------------------------ Description: h3.Context: For some reasons I have to deploy an EAR webapp with (in its libs) a jar containing itself another jar. h3.Environment: For this I have a first Java project with the following component descriptor: {code:xml} <?xml version="1.0" encoding="UTF-8"?> <project-modules id="moduleCoreId" project-version="1.5.0"> <wb-module deploy-name="project1"> <wb-resource deploy-path="/" source-path="/src/main/java"/> </wb-module> </project-modules> {code} Then, the second Java project has the component descriptor: {code:xml} <?xml version="1.0" encoding="UTF-8"?> <project-modules id="moduleCoreId" project-version="1.5.0"> <wb-module deploy-name="project2"> <wb-resource deploy-path="/" source-path="/src/main/java"/> <dependent-module archiveName="project1.jar" deploy-path="/lib" handle="module:/resource/project1/project1"> <dependency-type>uses</dependency-type> </dependent-module> </wb-module> </project-modules> {code} Then, in Eclipse when exporting the *project2* as a *Module Archive*, I obtain a .jar file featuring both classes from *project2* and a *lib* folder with the project1 compiled jar. Now, in the ear project I have the following lines in the component descriptor: {code:xml} <dependent-module archiveName=" project1.jar" deploy-path="/lib" handle="module:/resource/ project1/ project1"> <dependency-type>uses</dependency-type> </dependent-module> <dependent-module archiveName=" project2.jar" deploy-path="/lib" handle="module:/resource/ project2/ project2"> <dependency-type>uses</dependency-type> </dependent-module> {code} (The EAR needs the 2 jars as well) h3.Problem: Then, when deployed into my *JBoss 4.2 Runtime* server in Eclipse, I got the following error: {code} Error renaming C:\DEV\jboss\server\default\tmp\jbosstoolsTemp\tmp7021855122707247750.jar to C:\DEV\jboss\server\default\deploy\EAR_Project.ear\lib\project2.jar\lib\project1.jar {code} !error-renaming-archive.png! After some research, I think an exception is thrown at *org.jboss.ide.eclipse.as.core.server.xpl.PublishCopyUtil.LocalCopyCallback.moveTempFile(File, File)* during the safe rename. However, when I look to the error message I got the feeling that the publishing process want to copy the tmp jar file into a folder called "C:\DEV\jboss\server\default\deploy\EAR_Project.ear\lib\project2.jar\lib\" which can not work because "C:\DEV\jboss\server\default\deploy\EAR_Project.ear\lib\project2.jar" is a file. was: h3.Context: For some reasons I have to deploy an EAR webapp with (in its libs) a jar containing itself another jar. h3.Environment: For this I have a first Java project with the following component descriptor: {code:xml} <?xml version="1.0" encoding="UTF-8"?> <project-modules id="moduleCoreId" project-version="1.5.0"> <wb-module deploy-name="project1"> <wb-resource deploy-path="/" source-path="/src/main/java"/> </wb-module> </project-modules> {code} Then, the second Java project has the component descriptor: {code:xml} <?xml version="1.0" encoding="UTF-8"?> <project-modules id="moduleCoreId" project-version="1.5.0"> <wb-module deploy-name="project2"> <wb-resource deploy-path="/" source-path="/src/main/java"/> <dependent-module archiveName="project1.jar" deploy-path="/lib" handle="module:/resource/project1/project1"> <dependency-type>uses</dependency-type> </dependent-module> </wb-module> </project-modules> {code} Then, in Eclipse when exporting the *project2* as a *Module Archive*, I obtain a .jar file featuring both classes from *project2* and a *lib* folder with the project1 compiled jar. Now, in the ear project I have the following lines in the component descriptor: {code:xml} <dependent-module archiveName=" project1.jar" deploy-path="/lib" handle="module:/resource/ project1/ project1"> <dependency-type>uses</dependency-type> </dependent-module> <dependent-module archiveName=" project2.jar" deploy-path="/lib" handle="module:/resource/ project2/ project2"> <dependency-type>uses</dependency-type> </dependent-module> {code} (The EAR needs the 2 jars as well) h3.Problem: Then, when deployed into my *JBoss 4.2 Runtime* server in Eclipse, I got the following error: {code}Error renaming C:\DEV\jboss\server\default\tmp\jbosstoolsTemp\tmp7021855122707247750.jar to C:\DEV\jboss\server\default\deploy\EAR_Project.ear\lib\project2.jar\lib\project1.jar{code} After some research, I think an exception is thrown at *org.jboss.ide.eclipse.as.core.server.xpl.PublishCopyUtil.LocalCopyCallback.moveTempFile(File, File)* during the safe rename. However, when I look to the error message I got the feeling that the publishing process want to copy the tmp jar file into a folder called "C:\DEV\jboss\server\default\deploy\EAR_Project.ear\lib\project2.jar\lib\" which can not work because "C:\DEV\jboss\server\default\deploy\EAR_Project.ear\lib\project2.jar" is a file. Steps to Reproduce: Projects configuration: # Create an EAR project 'EAR_Project'. # Create 2 Java projects 'project1' and 'project2'. # In the 'EAR_Project' properties, in 'Deployment Assembly' add projects 'project1' and 'project2' (in the EAR library directory lib). # In the 'project2' properties, in 'Deployment Assembly' add project 'project1' and set deploy path to 'lib/project1.jar'. Runtime: # Create a JBoss 4.2 runtime. # Add 'EAR_Project'. # Do publish. => Problem Occurred window must appear. {code}Error renaming C:\DEV\jboss\server\default\tmp\jbosstoolsTemp\tmp7972940254262193574.jar to C:\DEV\jboss\server\default\deploy\EAR_Project.ear\lib\project2.jar\lib\project1.jar{code} !error-renaming-archive.png! was: Projects configuration: # Create an EAR project 'EAR_Project'. # Create 2 Java projects 'project1' and 'project2'. # In the 'EAR_Project' properties, in 'Deployment Assembly' add projects 'project1' and 'project2' (in the EAR library directory lib). # In the 'project2' properties, in 'Deployment Assembly' add project 'project1' and set deploy path to 'lib/project1.jar'. Runtime: # Create a JBoss 4.2 runtime. # Add 'EAR_Project'. # Do publish. => Problem Occurred window must appear. {code}Error renaming C:\DEV\jboss\server\default\tmp\jbosstoolsTemp\tmp7972940254262193574.jar to C:\DEV\jboss\server\default\deploy\EAR_Project.ear\lib\project2.jar\lib\project1.jar{code} -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-8863?page=com.atlassian.jira.plugin... ] Andre Dietisheim edited comment on JBIDE-8863 at 5/27/11 12:33 PM: ------------------------------------------------------------------- I debugged the current code (which may differ from the code that was used when the issue was filed since we introduces AS7 deployments in the meantime). AFAIK the problem resides in the fact that the outer EAR project is never deployed/created. The current code does deploy on behalf of the project children and does nothing if there're no children. Eclipse WTP does not treat the inner projects (project1 and project2) as children (@see PublishUtil#getResources - it returns an empty IModuleResource[] for the EAR_Project. It's using IModule#loadAdapter on to get a ModuleDelegate for the EAR_Project which it then gets the child resources from). I might fix it by providing a workaround for this particular case. I'm not sure though if this is the proper solution, I would need in depth comments from Rob. was (Author: adietish): I debugged the current code (which may differ from the code that was used when the issue was filed since we introduces AS7 deployments in the meantime). AFAIK the problem resides in the fact that the outer EAR project is never deployed/created. The current code does deploy on behalf of the project children and does nothing if there're no children. Eclipse WTP does not treat the inner projects (project1 and project2) as children (@see PublishUtil#getResources - it returns an empty IModuleResource[] for the EAR_Project. It's using IModule#loadAdapter on to get a ModuleDelegate for the EAR_Project which it then gets the child resources from). I might fix it by providing a workaround for this particular case. I'm not sure though if this is the proper solution, I would need in depth comments from Rob. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-8863?page=com.atlassian.jira.plugin... ] Andre Dietisheim commented on JBIDE-8863: ----------------------------------------- the error is due to the fact that project2 (the proj nested into project1, which is again nested into the ear) shall be added to a jar (project1). The current code seems to be written to handle directories only (see AbstractServerToolsPublisher#fullPublish). IMHO the usecase where a further jar shall be nested into another jar should be added in here. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-8863?page=com.atlassian.jira.plugin... ] Andre Dietisheim edited comment on JBIDE-8863 at 5/28/11 8:56 AM: ------------------------------------------------------------------ the error is due to the fact that project2 (the proj nested into project1, which is again nested into the ear) shall be added to a jar (project1). The current code seems to be written to handle directories only (see AbstractServerToolsPublisher#fullPublish). IMHO the usecase where a further jar shall be nested into another jar should be added in there (most likely to LocalCopyCallback and all other ICallbackHandler implementors). Unfortunately it's is far from obvious to me how to achieve this. My basic 'problem' is that the current copy code has no reference to the parent project that I should check to see if its a jar. was (Author: adietish): the error is due to the fact that project2 (the proj nested into project1, which is again nested into the ear) shall be added to a jar (project1). The current code seems to be written to handle directories only (see AbstractServerToolsPublisher#fullPublish). IMHO the usecase where a further jar shall be nested into another jar should be added in here. Unfortunately how to achieve this is far from obvious to me. My basic 'problem' is that the current copy code has no reference to the parent project that I should check to see if its a jar. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-8863?page=com.atlassian.jira.plugin... ] Andre Dietisheim updated JBIDE-8863: ------------------------------------ Steps to Reproduce: Projects configuration: # Create an EAR project 'EAR_Project'. # Create 2 Java projects 'project1' and 'project2'. # In the 'EAR_Project' properties, in 'Deployment Assembly' add projects 'project1' and 'project2' (in the EAR library directory lib). # In the 'project2' properties, in 'Deployment Assembly' add project 'project1' and set deploy path to 'lib/project1.jar'. Runtime: # Create a JBoss 4.2 runtime. # make sure your deployment is done in exploded mode (uncheck "Deploy projects as compressed archives" on the "Deployment" tab of the server adapter if needed) # Add 'EAR_Project'. # Do publish. => Problem Occurred window must appear. {code}Error renaming C:\DEV\jboss\server\default\tmp\jbosstoolsTemp\tmp7972940254262193574.jar to C:\DEV\jboss\server\default\deploy\EAR_Project.ear\lib\project2.jar\lib\project1.jar{code} !error-renaming-archive.png! was: Projects configuration: # Create an EAR project 'EAR_Project'. # Create 2 Java projects 'project1' and 'project2'. # In the 'EAR_Project' properties, in 'Deployment Assembly' add projects 'project1' and 'project2' (in the EAR library directory lib). # In the 'project2' properties, in 'Deployment Assembly' add project 'project1' and set deploy path to 'lib/project1.jar'. Runtime: # Create a JBoss 4.2 runtime. # Add 'EAR_Project'. # Do publish. => Problem Occurred window must appear. {code}Error renaming C:\DEV\jboss\server\default\tmp\jbosstoolsTemp\tmp7972940254262193574.jar to C:\DEV\jboss\server\default\deploy\EAR_Project.ear\lib\project2.jar\lib\project1.jar{code} !error-renaming-archive.png! -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-8863?page=com.atlassian.jira.plugin... ] Max Rydahl Andersen updated JBIDE-8863: --------------------------------------- Fix Version/s: 3.2.2 (was: 3.2.1.CR1) Priority: Major (was: Critical) I missed the fact that this is a very rare edgecase (a nested jar in a nested jar), so its not as far as I can see a common nor critical bug for now. That said it sounds like it should be doable in context of WTP UI so not removing it completely - just not marked as critical for 3.2.1. Ok ? -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-8863?page=com.atlassian.jira.plugin... ] Rob Stryker commented on JBIDE-8863: ------------------------------------ This is an issue with our publishers. It is expected that utility projects get zipped up, as opposed to web / ejb / ear projects which *may or may not* get zipped up. Utility projects were never expected to have further child projects. This issue will need to be investigated. It's possible we may need to force the use of a full zipped publisher recursive behavior on utility projects, but this could present several challenges. Also, the recursive zip behavior is part of the project archives integration, and so may or may not be present. A simple zip is handled by WTP's utility classes, but a recursive zip with nested modules is part of the archives integration. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-8863?page=com.atlassian.jira.plugin... ] Philippe Guinot commented on JBIDE-8863: ---------------------------------------- {quote}I'm curious - what is the usecase for this ? that nested jar is not going to be visible to anyone via normal classloading. ?{quote} We are launching from a web application a Hadoop Map/Reduce job. The job task is contained in a Jar file which is sent to the Hadoop cluster. The dependencies needed by the classes in the JAR must be in a lib folder inside the JAR. Hence the nested jars. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-8863?page=com.atlassian.jira.plugin... ] Max Rydahl Andersen updated JBIDE-8863: --------------------------------------- Fix Version/s: 3.3.0.Beta2 (was: 3.3.0.Final) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-8863?page=com.atlassian.jira.plugin... ] Rob Stryker resolved JBIDE-8863. -------------------------------- Fix Version/s: 3.3.0.Beta1 (was: 3.3.0.Beta2) Resolution: Done commit made :) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-8863?page=com.atlassian.jira.plugin... ] Rob Stryker commented on JBIDE-8863: ------------------------------------ what operating system are you using? Also what version of jbt are you using now? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-8863?page=com.atlassian.jira.plugin... ] Philippe Guinot commented on JBIDE-8863: ---------------------------------------- Yeah, sorry Jboss Tools 3.3.1 and in the About Eclipse window, the version shown for JBoss AS Tools is 2.3.1.v20120715-0243-H142-Final -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira