[
https://issues.jboss.org/browse/JBIDE-16309?page=com.atlassian.jira.plugi...
]
Mickael Istria commented on JBIDE-16309:
----------------------------------------
Extracting the "${jbt.upstream.repo}" and setting it in parent pom sounds like a
good idea which doesn't add difficulty.
I can set this in parent pom and update the example commit to use it in URL.
About prefixing URLs with stream instead of suffixing, I'm ok with this, but it is a
bigger change (implies changes in conventions and publish.sh). So I'd vote for doing
this later.
{quote}the important part is we don't require users to think about which
branch/profile they need to use {quote}
parent pom will always set the best default
Move inter-JBT dependencies to component poms
---------------------------------------------
Key: JBIDE-16309
URL:
https://issues.jboss.org/browse/JBIDE-16309
Project: Tools (JBoss Tools)
Issue Type: Enhancement
Components: build
Reporter: Mickael Istria
Assignee: Mickael Istria
Fix For: 4.2.0.Alpha2
It has been discussed several times that the composite site is a kind of "weak
point" in our build chain, because it allows cyclic dependencies, and it also
introduces indirections that make it less straightforward to find out what a project
should/does depend on to build.
The benefit of composite now seem a bit light: it's cool because we can put it in
parent pom and all builds succeed to get there dependencies, but out of that, there
hasn't been much other use-cases. And as we want to provide more and more autonomy to
project, this composite site they'd depend on is something that doesn't make them
autonomous.
So the idea is to move dependencies to project root poms. I've made a draft of how it
would look like in project pom if we remove the "jbosstools-site" from parent
pom and let projects manage their inter-dependencies:
https://github.com/mickaelistria/jbosstools-javaee/tree/JBIDE-16309
You can try this by running "mvn clean verify -P\!jbosstools-site". The
"-P\!jbosstools-site" disable the jbosstools-site profile, which is the one
controlling addition of the composite or ggregate to the resolver
https://github.com/jbosstools/jbosstools-build/blob/master/parent/pom.xml...
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:
http://www.atlassian.com/software/jira