[ https://jira.jboss.org/jira/browse/JBIDE-5835?page=com.atlassian.jira.plu... ] Alexey Kazakov updated JBIDE-5835: ---------------------------------- Fix Version/s: 3.2.next Assignee: Viacheslav Kabanovich -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-5835?page=com.atlassian.jira.plu... ] Max Rydahl Andersen commented on JBIDE-5835: -------------------------------------------- note, the reason this is important is that users do stuff like this: propertiesLocation=\${user.dir}/src/main/config/application.properties to be used in their maven build and avoid having ${user.dir} replaced when maven process resources. So this is rather annoying to those users that our properties editor clears out this escape character without warning. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-5835?page=com.atlassian.jira.plu... ] Alexey Kazakov commented on JBIDE-5835: --------------------------------------- I vote for Slava's solution to let user have such properties in soure folder but modify them if user has edited them in Edit dialog. This dialog is quite useful when it converts a user's input to correct form for runtime. For example it converts not latin characters to \uXXXX. But if user has some unusal value then he can use source tab (now it's impossible because Properties editor will modify it anyway). Max, what do you think? Slava, is it possible to modify only changed property? Or it's a limitation of Properties editor implementation and we have to convert the whole file even if the only property was changed via Edit dialog? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-5835?page=com.atlassian.jira.plu... ] Max Rydahl Andersen commented on JBIDE-5835: -------------------------------------------- Definitely - lets only touch entries the user asked us to touch. So when editing these fields via the property editor can I not at all put \${blahblah} into it ? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-5835?page=com.atlassian.jira.plu... ] Max Rydahl Andersen commented on JBIDE-5835: -------------------------------------------- Tihomir, do you know where you are getting that funny non-java-properties syntax from ? Is that just how Maven wants it ? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-5835?page=com.atlassian.jira.plu... ] Neil Moorcroft commented on JBIDE-5835: --------------------------------------- It is defined in the maven resource plugin docs, see escapeString here http://maven.apache.org/plugins/maven-resources-plugin/resources-mojo.html It can be overridden but the default is \ -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-5835?page=com.atlassian.jira.plu... ] Alexey Kazakov commented on JBIDE-5835: --------------------------------------- Of course a file should not be changed if user edit it in the source tab and that is what Slava has suggest. But I think it's ok to convert a property (to something that will be correct in runtime) if user has edited it in the property tab. It's a useful feature. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-5835?page=com.atlassian.jira.plu... ] Viacheslav Kabanovich commented on JBIDE-5835: ---------------------------------------------- We use java.util.Properties to load a property value from the source and to save the (modified) value back to source. Symbol '\' in source is never a part of property value but the escape symbol. When it concludes a source line, it just means that current property's value is continued on the next line. In combination '\n' it is interpreted as breaking property's value into two lines and so on. The combination \$ is interpreted as $, and entries with source values \${user.dir}, ${user.dir} are resolved into properties with equal value ${user.dir}. I assume that most technologies treat *.properties files by loading them into java.util.Properties and that is why we do the same in our visual editor. However, some tools (Maven?, no Seam?) may in runtime preprocess content of *.properties files treating them as text and for such a preprocessing tool \${user.dir} and ${user.dir} may be considered differently according to rules of that specific tool. If a tool loads Java properties object before treating ${} sequences, it will find ${\u0075\u0073\u0065\u0072\u0051\u002e\u0064\u0069\u0072} equivalent to ${user.dir}, but if it makes replacements before creating Java properties object, then of course they are not identical. We cannot suit all tools, our visual editor is compatible to those that follow the first pattern. Now, about saving a value modified in the visual editor. For many characters (e.g.English letters, digits) there are two ways to put them into source (e.g. \u0075 == u), for $ there are three ways (\$ == \u0024 == $). We delegate saving to source to the implementation of java.util.Properties class, and it decides about source representation for each character. In the past, we already had code versions that copied some internal methods of java.util.Properties, with modifications to enforce some of our logic, and I believe that was not good, and it was a step forward when we dropped that code, but we would have to go back to that approach if we are going to change logic of saving on the base of merging new value with source representation of the old value. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-5835?page=com.atlassian.jira.plu... ] Max Rydahl Andersen commented on JBIDE-5835: -------------------------------------------- ${} is not really the question here - the question is if we are editing source or compiling it... IMO a good editor would not mutate content even if has errors in it - it most definitely shouldn't without warning. But as you just said using \ is actually perfectly valid in properties file as you just said - its continued on the next line, so why are we removing it ? That's like running force Java Source formatting by default and remove users new lines for better readability. aka. A Bad default behavior -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-5835?page=com.atlassian.jira.plu... ] Viacheslav Kabanovich resolved JBIDE-5835. ------------------------------------------ Resolution: Done -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira