[ https://issues.jboss.org/browse/JBIDE-8701?page=com.atlassian.jira.plugin... ] Max Rydahl Andersen commented on JBIDE-8701: -------------------------------------------- I like that idea, but is that doable/feasible Yahor ? if not - push to later version -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-8701?page=com.atlassian.jira.plugin... ] Yahor Radtsevich updated JBIDE-8701: ------------------------------------ Fix Version/s: 3.3.0.M3 (was: 3.3.0.M2) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-8701?page=com.atlassian.jira.plugin... ] Yahor Radtsevich updated JBIDE-8701: ------------------------------------ Fix Version/s: 3.3.0.Beta1 (was: 3.3.0.M4) Bulk moved to 3.3.0.Beta1 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-8701?page=com.atlassian.jira.plugin... ] Denis Golovin updated JBIDE-8701: --------------------------------- Fix Version/s: 3.3.0.Beta1 (was: 3.3.0.M5) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-8701?page=com.atlassian.jira.plugin... ] Denis Maliarevich commented on JBIDE-8701: ------------------------------------------ The only possible way to scroll somewhere on the page is to execute javascript: {code} browser.execute("window.scrollTo(0, document.body.scrollHeight)"); {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-8701?page=com.atlassian.jira.plugin... ] Denis Maliarevich edited comment on JBIDE-8701 at 1/17/12 10:03 AM: -------------------------------------------------------------------- Thus changing the focus should be based on currently visible nodes. Or row lock could be performed in one-way: from source editor scroll bar changes -> it will influence on visual part position. Or problem can be solved by capturing the focus events in XulRunner and giving the focus to another xul element. was (Author: dmaliarevich): Thus changing the focus should be based on currently visible nodes. Or row lock could be performed in one-way: from source editor scroll bar changes -> it will influence on visual part position. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-8701?page=com.atlassian.jira.plugin... ] Yahor Radtsevich edited comment on JBIDE-8701 at 1/17/12 1:29 PM: ------------------------------------------------------------------ The browser widget may be scrolled also by calling: {code:java} nsIDOMWindow.scrollTo(int xScroll, int yScroll) {code} And you should be able to listen to the browser scrolling events using something like this: {code:java} nsIDOMEventListener listener = new nsIDOMEventListener() { public nsISupports queryInterface(String interfaceId) { return interfaceId.equals(nsIDOMEventListener.NS_IDOMEVENTLISTENER_IID) ? this : null; } public void handleEvent(nsIDOMEvent event) { int pageYOffset = queryInterface(window, nsIDOMWindowInternal.class).getPageYOffset(); // scroll the source here } } queryInterface(window, nsIDOMEventTarget.class).addEventListener("scroll", listener, false); {code} was (Author: yradtsevich): The browser widget may be scrolled also by calling: {code:java} nsIDOMWindow.scrollTo(int xScroll, int yScroll) {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-8701?page=com.atlassian.jira.plugin... ] Denis Maliarevich commented on JBIDE-8701: ------------------------------------------ One-way scrolling(source->visual and vice versa) works well. Enabling both listeners leads to cyclic updates -- that is a problem. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-8701?page=com.atlassian.jira.plugin... ] Denis Golovin edited comment on JBIDE-8701 at 1/19/12 5:58 PM: --------------------------------------------------------------- that's a piece of cake. When you get scolling event in source editor: # disable listener for visual part (because you know youl get event from visual part scroller) # scroll visual part # enable listener for viusal part back The same approach should be implemented for visual part scroll listener. considering that you can't change both scrolls at the same time this approach should work was (Author: dgolovin): that's a piece of cake. When you get scolling event in source editor: disable listener for visual part, scroll visual part,enable listener for vusal part -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-8701?page=com.atlassian.jira.plugin... ] Denis Maliarevich updated JBIDE-8701: ------------------------------------- Attachment: JBIDE8701-Source-Scroll-3.patch Patch 3 is attached. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-8701?page=com.atlassian.jira.plugin... ] Denis Maliarevich edited comment on JBIDE-8701 at 1/23/12 10:57 AM: -------------------------------------------------------------------- Removing scroll event listeners works only for source listener. For visual listener (xulrunner interface) -- events seem to be handled asynchronously. After visual listener has been removed and added once again it catches the same source scroll event. I suppose it's the result of display events queue processing. So in order to detach event's influence on each other -- two flags were added. Boolean sourceScrollEvent and visualScrollEvent flags indicate that the scrolling is performed programmatically by VPE. But there is another issue: that listeners react to any content change event. For instance setSelection(). So this behavior should be carefully checked. was (Author: dmaliarevich): Removing scroll event listeners works only for source listener. For visual listener (xulrunner interface) -- events seem to be handled asynchronously. After visual listener has been removed and added once again it cathes the same source scroll event. I suppose it's the result of display events queue processing. So in order to detach event's influence on each other -- two flags were added. Boolean sourceScrollEvent and visualScrollEvent flags indicates that the scrolling is performed programmatically. But there is another issue: that listeners react to any content change event. For instance setSelection(). So this behavior should be carefully checked. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-8701?page=com.atlassian.jira.plugin... ] Denis Maliarevich updated JBIDE-8701: ------------------------------------- Attachment: JBIDE8701-Source-Scroll-4-Listeners-Done.patch Patch 4 is attached. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-8701?page=com.atlassian.jira.plugin... ] Denis Maliarevich commented on JBIDE-8701: ------------------------------------------ Preferences page option was added, toolbar icon was added. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-8701?page=com.atlassian.jira.plugin... ] Denis Maliarevich commented on JBIDE-8701: ------------------------------------------ The next step is to create special function to correlate source and visual position precisely. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-8701?page=com.atlassian.jira.plugin... ] Denis Maliarevich commented on JBIDE-8701: ------------------------------------------ Now scroll functions should be updated for smooth scrolling. Getting source editor position from visual pane should rely on more precise detection, without scroll pikes for containers (like forms and divs). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-8701?page=com.atlassian.jira.plugin... ] Denis Maliarevich commented on JBIDE-8701: ------------------------------------------ Source scrolling was updated: now it takes top 9 lines to get correct visual position. Visual scrolling gets 9 coordinates from the visual pane and than calculates a better source position. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-8701?page=com.atlassian.jira.plugin... ] Denis Maliarevich commented on JBIDE-8701: ------------------------------------------ Analyzing of scroll position from visual pane to source should be updated. The problem is with inaccurate targetting of the source element from its visual representation. Due to the visual page structure neighbouring elemetns could have quite different source positions. Some compromise should be found. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-8701?page=com.atlassian.jira.plugin... ] Denis Maliarevich commented on JBIDE-8701: ------------------------------------------ Base functionality was implemented. JUnit should be added. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-8701?page=com.atlassian.jira.plugin... ] Denis Maliarevich commented on JBIDE-8701: ------------------------------------------ Junit was updated. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-8701?page=com.atlassian.jira.plugin... ] Denis Maliarevich commented on JBIDE-8701: ------------------------------------------ The test is still failling on Jenkins. I don't know the reason :( Possibly failed SWTBotTests could influence on that. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-8701?page=com.atlassian.jira.plugin... ] Denis Maliarevich commented on JBIDE-8701: ------------------------------------------ The only explanation that I have is that the eclipse with the junit page has lost focus and Ctrl+End combination was captured by another app. So I'll disable junit for a while, to solve this problem. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-8701?page=com.atlassian.jira.plugin... ] Yahor Radtsevich updated JBIDE-8701: ------------------------------------ Labels: new_and_noteworthy (was: ) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira