[ https://issues.jboss.org/browse/JBIDE-9937?page=com.atlassian.jira.plugin... ] Vitali Yemialyanchyk updated JBIDE-9937: ---------------------------------------- Attachment: screenshot-1.jpg -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-9937?page=com.atlassian.jira.plugin... ] Yahor Radtsevich updated JBIDE-9937: ------------------------------------ Assignee: Alexey Kazakov (was: Yahor Radtsevich) Component/s: jsp/jsf/xml source editing (was: Visual Page Editor core) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-9937?page=com.atlassian.jira.plugin... ] Yahor Radtsevich updated JBIDE-9937: ------------------------------------ Attachment: java-save.png The dialog which is shown for .java-files: !java-save.png|thumbnail! -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-9937?page=com.atlassian.jira.plugin... ] Alexey Kazakov updated JBIDE-9937: ---------------------------------- Component/s: UpStream (was: jsp/jsf/xml source editing) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-9937?page=com.atlassian.jira.plugin... ] Alexey Kazakov updated JBIDE-9937: ---------------------------------- Fix Version/s: 3.3.x -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-9937?page=com.atlassian.jira.plugin... ] Alexey Kazakov updated JBIDE-9937: ---------------------------------- Attachment: jspx.png I cannot reproduce this issue even with your page: !jspx.png! -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-9937?page=com.atlassian.jira.plugin... ] Vitali Yemialyanchyk commented on JBIDE-9937: --------------------------------------------- VPE can not open file in UTF-8 directly, it only can save file in UTF-8. so open the file with editor which can open file in UTF-8, then copy file content in to clipboard, then copy from clipboard to VPE. then try to reproduce the issue. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-9937?page=com.atlassian.jira.plugin... ] Vitali Yemialyanchyk commented on JBIDE-9937: --------------------------------------------- 2) write something in Russian - you can substitute it with 2) write something in Arabic, Herbrew, China -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-9937?page=com.atlassian.jira.plugin... ] Vitali Yemialyanchyk commented on JBIDE-9937: --------------------------------------------- Vitya, my comment: VPE can not open file in UTF-8 directly, it only can save file in UTF-8. so open the file with editor which can open file in UTF-8, then copy file content in to clipboard, then copy from clipboard to VPE. then try to reproduce the issue. provide steps how to reproduce the issue. example.jspx page in example.zip contain some Hebrew characters, I input these when edit file in VPE and then save the file in UTF-8 like VPE propose. when you try to open the file - vpe does not recognize UTF-8 and open it Win-1252 or Win-1251 does not matter - so you can not reproduce the issue. once more: 1) open the file (example.jspx) with some editor which can open file in UTF-8 without UTF-8 header signature. 2) copy content into clipboard; 3) past in VPE; or just input some Arabic, Hebrew, China, Cyrillic text in VPE and try to reproduce the issue. it reproducible constantly. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-9937?page=com.atlassian.jira.plugin... ] Vitali Yemialyanchyk commented on JBIDE-9937: --------------------------------------------- if you select save - you'll get dialog like Alexey shows... but try: File -> Save As -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-9937?page=com.atlassian.jira.plugin... ] Victor Rubezhny commented on JBIDE-9937: ---------------------------------------- In my case editor uses CharsetEncoder to convert editor's content into ISO-8859-1 encoding and this encoder is set up to report a problem when it faces an Unmappable Character. If we would like to change this strategy we have the only "replace" choice to use but any replacement will kill original content (probably we can replace UTF-8 character by UrlEncoded equivalent but more sophisticated processing is to be performed for xml content (I though that xml node/attribute names cannod be encoded, and so on). Other possibility is to prevent the saving for such documents by detecting the problems prior to saving and doing (in case of decode problems) the save way as Save operation does (with showing the dialog with the proposal to save in UTF-8 encoding). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-9937?page=com.atlassian.jira.plugin... ] Victor Rubezhny commented on JBIDE-9937: ---------------------------------------- Due to "meta content="text/html; charset=utf-8"" could be used the editor should ALWAYS save the pages using UTF-8 encoding. But this may rise a conflict with Window->Preferences->General->Workspace->Text File Encoding. BTW, Vitaly, it's strange for me but, I have UTF-8 value is set for the preference mentioned above (but I'm using Ubuntu x64) and it seems to me that VPE (actually, Text editor) overrides this preference (or just not using it) by converting the text using ISO-8859-1 encoding while saving a file. What value is specified for this preference in your system? Also, you may check the following preferences: Window->Preferences->Web->HTML Files->Creating Files: Encoding Window->Preferences->Web->JSP Files->Creating Files: Encoding It seams to me that VPE editor should use these preferences while saving files (not only when creating a new HTML/JSP file). Alexey, WDYT? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-9937?page=com.atlassian.jira.plugin... ] Victor Rubezhny commented on JBIDE-9937: ---------------------------------------- IMHO, It's not normal to use ISO Latin-1 to edit the texts which is actually has UTF-8 encoding. The Java char is actually a single 16-bit Unicode character, so it's possible to insert (paste) any unicode characters into a text has being edited, but when the text is to be saved it has to be converted to the specified encoding. This means that if you have ISO Latin-1 encoding specified for the editor and inserting a chars like "פותחת מתקן מחקר חדש לקידום קיימא", then the editor should always ask you to save the page in UTF-8 encoding (these characters are 16-bits wide while ISO Latin-1 defines 8-bit wide character set). Vitaly, does "jspx.png dialog" occur always when you press "Save" in your editor (I mean "Save", not "Save As")? If not then VPE editor probably overrides somehow the preferences specified above. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-9937?page=com.atlassian.jira.plugin... ] Victor Rubezhny commented on JBIDE-9937: ---------------------------------------- "I dislike - I can not then reopen file in UTF-8 encoding" - but it's OK, IMO, since the editor uses Window->Preferences->General->Workspace->Text File Encoding preference. Try to change it to UTF-8 and then restart eclipse. (I have UTF-8 is set and have no "jspx.png dialog" displayed at all). I understood "Save As" problem. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-9937?page=com.atlassian.jira.plugin... ] Victor Rubezhny updated JBIDE-9937: ----------------------------------- Issue Type: Feature Request (was: Bug) Fix Version/s: LATER (was: 3.3.x) Priority: Minor (was: Major) Component/s: jsp/jsf/xml source editing -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-9937?page=com.atlassian.jira.plugin... ] Victor Rubezhny commented on JBIDE-9937: ---------------------------------------- "I've set "UTF-8 encoding" for both cases - then I've try to open example.jspx - VPE does not display UTF-8 symbols" After you have changed the editor encoding to UTF-8, your example.jspx is still non-UTF-8 encoded. So, when you opened it within editor it could be shown improperly because of this difference in editor and file encodings. But after you'll press Save (not Save as, but save) the file should be saved in UTF-8 (as editor's preferences force) and you have not to see "jspx.png dialog" like I do now. (But editor content must be changed somehow due to enable Save operation). After your file is saved in UTF-8 you may copy/paste any UTF-8 encoded characters and editor should show/save/open them with no problems. But "Save As" will behave still as you described in this issue. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira