[JBoss JIRA] Created: (JBIDE-8956) Make Conditional Transitions Illegal if they are Leaving a Node that is not a Decision Node
8:50 a.m.
Make Conditional Transitions Illegal if they are Leaving a Node that is not a Decision
Node
-------------------------------------------------------------------------------------------
Key: JBIDE-8956
URL: https://issues.jboss.org/browse/JBIDE-8956
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: jbpm
Affects Versions: 3.2.1.M1, 3.3.0.M1
Reporter: Koen Aers
Assignee: Koen Aers
Fix For: 3.2.1.CR1, 3.3.0.M2
This request is related to SOA-2010.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:52 a.m.
New subject: [JBoss JIRA] Commented: (JBIDE-8956) Make Conditional Transitions Illegal if they are Leaving a Node that is not a Decision Node
[
https://issues.jboss.org/browse/JBIDE-8956?page=com.atlassian.jira.plugin...
]
Koen Aers commented on JBIDE-8956:
----------------------------------
Marco said:
In the patch, there are two things:
- a bunch of changes to ConditionSection, in which I show a warning if the selected
transition doesn't comply with conditions/transitions/decisions.
- A number of the *DomAdapters have been modified (+2,3 rules of code), in order to make
sure that Transition.source is set during parsing.
Make Conditional Transitions Illegal if they are Leaving a Node that
is not a Decision Node
-------------------------------------------------------------------------------------------
Key: JBIDE-8956
URL: https://issues.jboss.org/browse/JBIDE-8956
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: jbpm
Affects Versions: 3.2.1.M1, 3.3.0.M1
Reporter: Koen Aers
Assignee: Koen Aers
Fix For: 3.2.1.CR1, 3.3.0.M2
Attachments: JBIDE-8956.patch
This request is related to SOA-2010.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:52 a.m.
New subject: [JBoss JIRA] Updated: (JBIDE-8956) Make Conditional Transitions Illegal if they are Leaving a Node that is not a Decision Node
[
https://issues.jboss.org/browse/JBIDE-8956?page=com.atlassian.jira.plugin...
]
Koen Aers updated JBIDE-8956:
-----------------------------
Attachment: JBIDE-8956.patch
Patch proposed by Marco Rietveld
Make Conditional Transitions Illegal if they are Leaving a Node that
is not a Decision Node
-------------------------------------------------------------------------------------------
Key: JBIDE-8956
URL: https://issues.jboss.org/browse/JBIDE-8956
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: jbpm
Affects Versions: 3.2.1.M1, 3.3.0.M1
Reporter: Koen Aers
Assignee: Koen Aers
Fix For: 3.2.1.CR1, 3.3.0.M2
Attachments: JBIDE-8956.patch
This request is related to SOA-2010.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:54 a.m.
New subject: [JBoss JIRA] Commented: (JBIDE-8956) Make Conditional Transitions Illegal if they are Leaving a Node that is not a Decision Node
[
https://issues.jboss.org/browse/JBIDE-8956?page=com.atlassian.jira.plugin...
]
Koen Aers commented on JBIDE-8956:
----------------------------------
Marco,
The patch looks OK. But I was thinking that for backward compatibility reasons it probably
would be good to have a preference that allows the warnings to be suppressed.
Thoughts?
Make Conditional Transitions Illegal if they are Leaving a Node that
is not a Decision Node
-------------------------------------------------------------------------------------------
Key: JBIDE-8956
URL: https://issues.jboss.org/browse/JBIDE-8956
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: jbpm
Affects Versions: 3.2.1.M1, 3.3.0.M1
Reporter: Koen Aers
Assignee: Koen Aers
Fix For: 3.2.1.CR1, 3.3.0.M2
Attachments: JBIDE-8956.patch
This request is related to SOA-2010.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:08 a.m.
New subject: [JBoss JIRA] Commented: (JBIDE-8956) Make Conditional Transitions Illegal if they are Leaving a Node that is not a Decision Node
[
https://issues.jboss.org/browse/JBIDE-8956?page=com.atlassian.jira.plugin...
]
Marco Rietveld commented on JBIDE-8956:
---------------------------------------
Koen,
That sounds good. Is there already a default place where I could put this
parameter/option?
I also think about some way to make sure that the warnings are only used when used in
conjunction with certain versions of the jbpm-jpdl jar. Does that sound like a good idea?
Make Conditional Transitions Illegal if they are Leaving a Node that
is not a Decision Node
-------------------------------------------------------------------------------------------
Key: JBIDE-8956
URL: https://issues.jboss.org/browse/JBIDE-8956
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: jbpm
Affects Versions: 3.2.1.M1, 3.3.0.M1
Reporter: Koen Aers
Assignee: Koen Aers
Fix For: 3.2.1.CR1, 3.3.0.M2
Attachments: JBIDE-8956.patch
This request is related to SOA-2010.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:16 a.m.
New subject: [JBoss JIRA] Updated: (JBIDE-8956) Make Conditional Transitions Illegal if they are Leaving a Node that is not a Decision Node
[
https://issues.jboss.org/browse/JBIDE-8956?page=com.atlassian.jira.plugin...
]
Koen Aers updated JBIDE-8956:
-----------------------------
Attachment: preferences.png
Make Conditional Transitions Illegal if they are Leaving a Node that
is not a Decision Node
-------------------------------------------------------------------------------------------
Key: JBIDE-8956
URL: https://issues.jboss.org/browse/JBIDE-8956
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: jbpm
Affects Versions: 3.2.1.M1, 3.3.0.M1
Reporter: Koen Aers
Assignee: Koen Aers
Fix For: 3.2.1.CR1, 3.3.0.M2
Attachments: JBIDE-8956.patch, preferences.png
This request is related to SOA-2010.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:22 a.m.
New subject: [JBoss JIRA] Commented: (JBIDE-8956) Make Conditional Transitions Illegal if they are Leaving a Node that is not a Decision Node
[
https://issues.jboss.org/browse/JBIDE-8956?page=com.atlassian.jira.plugin...
]
Koen Aers commented on JBIDE-8956:
----------------------------------
I think the best approach would be to make a new preference page. You contribute it in the
'JBoss jBPM->jBPM 3' category and call it 'Compatibility'. On the page
there is just a checkbox with a label 'Suppress warnings on transitions with invalid
conditions' that is unchecked by default. You can basically copy paste the
JpdlTemplatesPage :
http://anonsvn.jboss.org/repos/jbosstools/trunk/jbpm/plugins/org.jbpm.gd....
and contribute it
Make Conditional Transitions Illegal if they are Leaving a Node that
is not a Decision Node
-------------------------------------------------------------------------------------------
Key: JBIDE-8956
URL: https://issues.jboss.org/browse/JBIDE-8956
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: jbpm
Affects Versions: 3.2.1.M1, 3.3.0.M1
Reporter: Koen Aers
Assignee: Koen Aers
Fix For: 3.2.1.CR1, 3.3.0.M2
Attachments: JBIDE-8956.patch, preferences.png
This request is related to SOA-2010.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:26 a.m.
New subject: [JBoss JIRA] Commented: (JBIDE-8956) Make Conditional Transitions Illegal if they are Leaving a Node that is not a Decision Node
[
https://issues.jboss.org/browse/JBIDE-8956?page=com.atlassian.jira.plugin...
]
Koen Aers commented on JBIDE-8956:
----------------------------------
Of course, you'll have to use the value of this pref in the ConditionSection ;-)
And I don't think you should try to make a difference between the jbpm-jpdl jars. Just
leave it to the user.
Make Conditional Transitions Illegal if they are Leaving a Node that
is not a Decision Node
-------------------------------------------------------------------------------------------
Key: JBIDE-8956
URL: https://issues.jboss.org/browse/JBIDE-8956
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: jbpm
Affects Versions: 3.2.1.M1, 3.3.0.M1
Reporter: Koen Aers
Assignee: Koen Aers
Fix For: 3.2.1.CR1, 3.3.0.M2
Attachments: JBIDE-8956.patch, preferences.png
This request is related to SOA-2010.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:11 a.m.
New subject: [JBoss JIRA] Updated: (JBIDE-8956) Make Conditional Transitions Illegal if they are Leaving a Node that is not a Decision Node
[
https://issues.jboss.org/browse/JBIDE-8956?page=com.atlassian.jira.plugin...
]
Marco Rietveld updated JBIDE-8956:
----------------------------------
Attachment: 190511-org.jbpm.gd.jpdl.patch
Patch for the org.jbpm.gd.jpdl.patch plugin.
Make Conditional Transitions Illegal if they are Leaving a Node that
is not a Decision Node
-------------------------------------------------------------------------------------------
Key: JBIDE-8956
URL: https://issues.jboss.org/browse/JBIDE-8956
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: jbpm
Affects Versions: 3.2.1.M1, 3.3.0.M1
Reporter: Koen Aers
Assignee: Koen Aers
Fix For: 3.2.1.CR1, 3.3.0.M2
Attachments: 190511-org.jbpm.gd.jpdl.patch, JBIDE-8956.patch, preferences.png
This request is related to SOA-2010.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:53 a.m.
New subject: [JBoss JIRA] Commented: (JBIDE-8956) Make Conditional Transitions Illegal if they are Leaving a Node that is not a Decision Node
[
https://issues.jboss.org/browse/JBIDE-8956?page=com.atlassian.jira.plugin...
]
Marco Rietveld commented on JBIDE-8956:
---------------------------------------
BTW, many thanks to http://www.eclipse.org/articles/Article-Preferences/preferences.htm.
That page helped a lot with implementing the preference in the ConditionSection.
Make Conditional Transitions Illegal if they are Leaving a Node that
is not a Decision Node
-------------------------------------------------------------------------------------------
Key: JBIDE-8956
URL: https://issues.jboss.org/browse/JBIDE-8956
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: jbpm
Affects Versions: 3.2.1.M1, 3.3.0.M1
Reporter: Koen Aers
Assignee: Koen Aers
Fix For: 3.2.1.CR1, 3.3.0.M2
Attachments: 190511-org.jbpm.gd.jpdl.patch, JBIDE-8956.patch, preferences.png
This request is related to SOA-2010.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:33 a.m.
New subject: [JBoss JIRA] Resolved: (JBIDE-8956) Make Conditional Transitions Illegal if they are Leaving a Node that is not a Decision Node
[
https://issues.jboss.org/browse/JBIDE-8956?page=com.atlassian.jira.plugin...
]
Koen Aers resolved JBIDE-8956.
------------------------------
Release Notes Text: Transitions with conditions are now by default illegal when they
leave a node that is not a decision node. A warning is shown when a user tries to add such
a configuration. The old behaviour is still possible by checking a checkbox located on the
'Compatibility' preference page.
Resolution: Done
patch applied in trunk and 3.2.x
Make Conditional Transitions Illegal if they are Leaving a Node that
is not a Decision Node
-------------------------------------------------------------------------------------------
Key: JBIDE-8956
URL: https://issues.jboss.org/browse/JBIDE-8956
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: jbpm
Affects Versions: 3.2.1.M1, 3.3.0.M1
Reporter: Koen Aers
Assignee: Koen Aers
Fix For: 3.2.1.CR1, 3.3.0.M2
Attachments: 190511-org.jbpm.gd.jpdl.patch, JBIDE-8956.patch, preferences.png
This request is related to SOA-2010.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:49 a.m.
New subject: [JBoss JIRA] Commented: (JBIDE-8956) Make Conditional Transitions Illegal if they are Leaving a Node that is not a Decision Node
[
https://issues.jboss.org/browse/JBIDE-8956?page=com.atlassian.jira.plugin...
]
Marco Rietveld commented on JBIDE-8956:
---------------------------------------
Thanks Koen!
Make Conditional Transitions Illegal if they are Leaving a Node that
is not a Decision Node
-------------------------------------------------------------------------------------------
Key: JBIDE-8956
URL: https://issues.jboss.org/browse/JBIDE-8956
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: jbpm
Affects Versions: 3.2.1.M1, 3.3.0.M1
Reporter: Koen Aers
Assignee: Koen Aers
Fix For: 3.2.1.CR1, 3.3.0.M2
Attachments: 190511-org.jbpm.gd.jpdl.patch, JBIDE-8956.patch, preferences.png
This request is related to SOA-2010.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:39 a.m.
New subject: [JBoss JIRA] Commented: (JBIDE-8956) Make Conditional Transitions Illegal if they are Leaving a Node that is not a Decision Node
[
https://issues.jboss.org/browse/JBIDE-8956?page=com.atlassian.jira.plugin...
]
Koen Aers commented on JBIDE-8956:
----------------------------------
Come on man, you did all the hard work ;-)
Make Conditional Transitions Illegal if they are Leaving a Node that
is not a Decision Node
-------------------------------------------------------------------------------------------
Key: JBIDE-8956
URL: https://issues.jboss.org/browse/JBIDE-8956
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: jbpm
Affects Versions: 3.2.1.M1, 3.3.0.M1
Reporter: Koen Aers
Assignee: Koen Aers
Fix For: 3.2.1.CR1, 3.3.0.M2
Attachments: 190511-org.jbpm.gd.jpdl.patch, JBIDE-8956.patch, preferences.png
This request is related to SOA-2010.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:05 a.m.
New subject: [JBoss JIRA] Commented: (JBIDE-8956) Make Conditional Transitions Illegal if they are Leaving a Node that is not a Decision Node
[
https://issues.jboss.org/browse/JBIDE-8956?page=com.atlassian.jira.plugin...
]
Marco Rietveld commented on JBIDE-8956:
---------------------------------------
True, but the thanks was more for the hand holding.. :)
Make Conditional Transitions Illegal if they are Leaving a Node that
is not a Decision Node
-------------------------------------------------------------------------------------------
Key: JBIDE-8956
URL: https://issues.jboss.org/browse/JBIDE-8956
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: jbpm
Affects Versions: 3.2.1.M1, 3.3.0.M1
Reporter: Koen Aers
Assignee: Koen Aers
Fix For: 3.2.1.CR1, 3.3.0.M2
Attachments: 190511-org.jbpm.gd.jpdl.patch, JBIDE-8956.patch, preferences.png
This request is related to SOA-2010.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:11 a.m.
New subject: [JBoss JIRA] Closed: (JBIDE-8956) Make Conditional Transitions Illegal if they are Leaving a Node that is not a Decision Node
[
https://issues.jboss.org/browse/JBIDE-8956?page=com.atlassian.jira.plugin...
]
Jiri Peterka closed JBIDE-8956.
-------------------------------
Verified in jbds-eap-4.1.0.cr1-h527, preferences page and behaviour for non-decision mode
Make Conditional Transitions Illegal if they are Leaving a Node that
is not a Decision Node
-------------------------------------------------------------------------------------------
Key: JBIDE-8956
URL: https://issues.jboss.org/browse/JBIDE-8956
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: jbpm
Affects Versions: 3.2.1.M1, 3.3.0.M1
Reporter: Koen Aers
Assignee: Koen Aers
Fix For: 3.2.1.CR1, 3.3.0.M2
Attachments: 190511-org.jbpm.gd.jpdl.patch, JBIDE-8956.patch, preferences.png
This request is related to SOA-2010.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
5413
days inactive
5434
days old
jbosstools-issues@lists.jboss.org
14 comments
3 participants
participants (3)
-
Jiri Peterka (JIRA) -
Koen Aers (JIRA)
-
Marco Rietveld (JIRA)