[JBoss JIRA] Created: (JBIDE-5422) CSV input configuration should be simple like when adding the CSV template
3:13 p.m.
CSV input configuration should be simple like when adding the CSV template
--------------------------------------------------------------------------
Key: JBIDE-5422
URL: https://jira.jboss.org/jira/browse/JBIDE-5422
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: smooks
Affects Versions: 3.1.0.GA
Reporter: Brian Fitzpatrick
Assignee: Xue Peng
Fix For: 3.1.0.GA
When configuring CSV input data details, we should simplify the reader configuration like
we did for configuring a CSV template.
- Separator Character
- Quote Character
- Field list
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:08 a.m.
New subject: [JBoss JIRA] Commented: (JBIDE-5422) CSV input configuration should be simple like when adding the CSV template
[
https://jira.jboss.org/jira/browse/JBIDE-5422?page=com.atlassian.jira.plu...
]
Xue Peng commented on JBIDE-5422:
---------------------------------
How to simplify?
CSV input configuration should be simple like when adding the CSV
template
--------------------------------------------------------------------------
Key: JBIDE-5422
URL: https://jira.jboss.org/jira/browse/JBIDE-5422
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: smooks
Affects Versions: 3.1.0.GA
Reporter: Brian Fitzpatrick
Assignee: Xue Peng
Fix For: 3.1.0.GA
Original Estimate: 0 minutes
Remaining Estimate: 0 minutes
When configuring CSV input data details, we should simplify the reader configuration like
we did for configuring a CSV template.
- Separator Character
- Quote Character
- Field list
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:14 a.m.
New subject: [JBoss JIRA] Commented: (JBIDE-5422) CSV input configuration should be simple like when adding the CSV template
[
https://jira.jboss.org/jira/browse/JBIDE-5422?page=com.atlassian.jira.plu...
]
Brian Fitzpatrick commented on JBIDE-5422:
------------------------------------------
The same way we simplified when adding a CSV template in the Apply Template task. The CSV
stuff should boil down to the three fields - Separator character, quote character, and
text field in which people can simply type "field1,field2,field3" and have it
work. We don't need to have it as a list box with Add/Remove buttons here. CSVs are
simple - the UI should be too.
Does that help?
CSV input configuration should be simple like when adding the CSV
template
--------------------------------------------------------------------------
Key: JBIDE-5422
URL: https://jira.jboss.org/jira/browse/JBIDE-5422
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: smooks
Affects Versions: 3.1.0.GA
Reporter: Brian Fitzpatrick
Assignee: Xue Peng
Fix For: 3.1.0.GA
Original Estimate: 0 minutes
Remaining Estimate: 0 minutes
When configuring CSV input data details, we should simplify the reader configuration like
we did for configuring a CSV template.
- Separator Character
- Quote Character
- Field list
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:19 a.m.
New subject: [JBoss JIRA] Commented: (JBIDE-5422) CSV input configuration should be simple like when adding the CSV template
[
https://jira.jboss.org/jira/browse/JBIDE-5422?page=com.atlassian.jira.plu...
]
Xue Peng commented on JBIDE-5422:
---------------------------------
I will replace the fields table with a simple text control.
CSV input configuration should be simple like when adding the CSV
template
--------------------------------------------------------------------------
Key: JBIDE-5422
URL: https://jira.jboss.org/jira/browse/JBIDE-5422
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: smooks
Affects Versions: 3.1.0.GA
Reporter: Brian Fitzpatrick
Assignee: Xue Peng
Fix For: 3.1.0.GA
Original Estimate: 0 minutes
Remaining Estimate: 0 minutes
When configuring CSV input data details, we should simplify the reader configuration like
we did for configuring a CSV template.
- Separator Character
- Quote Character
- Field list
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:29 a.m.
New subject: [JBoss JIRA] Commented: (JBIDE-5422) CSV input configuration should be simple like when adding the CSV template
[
https://jira.jboss.org/jira/browse/JBIDE-5422?page=com.atlassian.jira.plu...
]
Xue Peng commented on JBIDE-5422:
---------------------------------
Hi Brian ,
It seems that you want there are only there attribute field control in CSV reader panel ,
do you ?
CSV input configuration should be simple like when adding the CSV
template
--------------------------------------------------------------------------
Key: JBIDE-5422
URL: https://jira.jboss.org/jira/browse/JBIDE-5422
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: smooks
Affects Versions: 3.1.0.GA
Reporter: Brian Fitzpatrick
Assignee: Xue Peng
Fix For: 3.1.0.GA
Original Estimate: 0 minutes
Remaining Estimate: 0 minutes
When configuring CSV input data details, we should simplify the reader configuration like
we did for configuring a CSV template.
- Separator Character
- Quote Character
- Field list
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:29 a.m.
New subject: [JBoss JIRA] Commented: (JBIDE-5422) CSV input configuration should be simple like when adding the CSV template
[
https://jira.jboss.org/jira/browse/JBIDE-5422?page=com.atlassian.jira.plu...
]
Brian Fitzpatrick commented on JBIDE-5422:
------------------------------------------
I think that if you replace the listbox where you add/remove fields with a simple field
where users can type in field1,field2,field3, I think that's fine for GA.
We may do some additional tweaking as far as JBIDE-5423 to reduce the size footprint of
all the reader configurations, but that will be discussed there.
CSV input configuration should be simple like when adding the CSV
template
--------------------------------------------------------------------------
Key: JBIDE-5422
URL: https://jira.jboss.org/jira/browse/JBIDE-5422
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: smooks
Affects Versions: 3.1.0.GA
Reporter: Brian Fitzpatrick
Assignee: Xue Peng
Fix For: 3.1.0.GA
Original Estimate: 0 minutes
Remaining Estimate: 0 minutes
When configuring CSV input data details, we should simplify the reader configuration like
we did for configuring a CSV template.
- Separator Character
- Quote Character
- Field list
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:20 p.m.
New subject: [JBoss JIRA] Updated: (JBIDE-5422) CSV input configuration should be simple like when adding the CSV template
[
https://jira.jboss.org/jira/browse/JBIDE-5422?page=com.atlassian.jira.plu...
]
Xue Peng updated JBIDE-5422:
----------------------------
Attachment: JBIDE-5422.patch
CSV input configuration should be simple like when adding the CSV
template
--------------------------------------------------------------------------
Key: JBIDE-5422
URL: https://jira.jboss.org/jira/browse/JBIDE-5422
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: smooks
Affects Versions: 3.1.0.GA
Reporter: Brian Fitzpatrick
Assignee: Xue Peng
Fix For: 3.1.0.GA
Attachments: JBIDE-5422.patch
Original Estimate: 0 minutes
Remaining Estimate: 0 minutes
When configuring CSV input data details, we should simplify the reader configuration like
we did for configuring a CSV template.
- Separator Character
- Quote Character
- Field list
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:31 a.m.
New subject: [JBoss JIRA] Commented: (JBIDE-5422) CSV input configuration should be simple like when adding the CSV template
[
https://jira.jboss.org/jira/browse/JBIDE-5422?page=com.atlassian.jira.plu...
]
Brian Fitzpatrick commented on JBIDE-5422:
------------------------------------------
This was somewhat fixed with the patch to JBIDE-5215
I still think we should reduce some of the other fields on the CSV config - for instance
do we need the Target Profile field or the Features listbox/buttons?
CSV input configuration should be simple like when adding the CSV
template
--------------------------------------------------------------------------
Key: JBIDE-5422
URL: https://jira.jboss.org/jira/browse/JBIDE-5422
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: smooks
Affects Versions: 3.1.0.GA
Reporter: Brian Fitzpatrick
Assignee: Xue Peng
Fix For: 3.1.0.GA
Attachments: JBIDE-5422.patch
Original Estimate: 0 minutes
Remaining Estimate: 0 minutes
When configuring CSV input data details, we should simplify the reader configuration like
we did for configuring a CSV template.
- Separator Character
- Quote Character
- Field list
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:55 a.m.
New subject: [JBoss JIRA] Commented: (JBIDE-5422) CSV input configuration should be simple like when adding the CSV template
[
https://jira.jboss.org/jira/browse/JBIDE-5422?page=com.atlassian.jira.plu...
]
Xue Peng commented on JBIDE-5422:
---------------------------------
Hi Brian:
I'm not sure that do we need the Target profile and other GUIs , these GUIs are
editing the properties' value for csv reader , if we remove/hide them , user need to
edit these properties of csv reader in the source tab directly.
But I think if it's rare to use them , hidden them to save the space is OK.
CSV input configuration should be simple like when adding the CSV
template
--------------------------------------------------------------------------
Key: JBIDE-5422
URL: https://jira.jboss.org/jira/browse/JBIDE-5422
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: smooks
Affects Versions: 3.1.0.GA
Reporter: Brian Fitzpatrick
Assignee: Xue Peng
Fix For: 3.1.0.GA
Attachments: JBIDE-5422.patch
Original Estimate: 0 minutes
Remaining Estimate: 0 minutes
When configuring CSV input data details, we should simplify the reader configuration like
we did for configuring a CSV template.
- Separator Character
- Quote Character
- Field list
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:31 p.m.
New subject: [JBoss JIRA] Assigned: (JBIDE-5422) CSV input configuration should be simple like when adding the CSV template
[
https://jira.jboss.org/jira/browse/JBIDE-5422?page=com.atlassian.jira.plu...
]
Brian Fitzpatrick reassigned JBIDE-5422:
----------------------------------------
Assignee: Tom Fennelly (was: Xue Peng)
Hey Tom... Can you comment on what fields we should keep and what should be removed? We
can then assign it back to Dart to work on...
CSV input configuration should be simple like when adding the CSV
template
--------------------------------------------------------------------------
Key: JBIDE-5422
URL: https://jira.jboss.org/jira/browse/JBIDE-5422
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: smooks
Affects Versions: 3.1.0.GA
Reporter: Brian Fitzpatrick
Assignee: Tom Fennelly
Fix For: 3.1.0.GA
Attachments: JBIDE-5422.patch
Original Estimate: 0 minutes
Remaining Estimate: 0 minutes
When configuring CSV input data details, we should simplify the reader configuration like
we did for configuring a CSV template.
- Separator Character
- Quote Character
- Field list
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:35 a.m.
New subject: [JBoss JIRA] Commented: (JBIDE-5422) CSV input configuration should be simple like when adding the CSV template
[
https://jira.jboss.org/jira/browse/JBIDE-5422?page=com.atlassian.jira.plu...
]
Tom Fennelly commented on JBIDE-5422:
-------------------------------------
I think we should definitely get rid of:
1. The "Features" field (wrongly named - they are not features). These are
shorthand binding configs supported by the CSV reader config. Lets not expose this
functionality in the editor... too confusing.
2. Move "Fields" to the top.
3. Get rid of "Target Profile" for now.
4. Get rid of "Encoding". This config will be removed from the CSV (and other
readers) config in a future relase of Smooks. It was a mistake to have it tere. Lets not
expose it in the reader configs in the editor.
CSV input configuration should be simple like when adding the CSV
template
--------------------------------------------------------------------------
Key: JBIDE-5422
URL: https://jira.jboss.org/jira/browse/JBIDE-5422
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: smooks
Affects Versions: 3.1.0.CR2
Reporter: Brian Fitzpatrick
Assignee: Tom Fennelly
Fix For: 3.1.0.CR2
Attachments: JBIDE-5422.patch
Original Estimate: 0 minutes
Remaining Estimate: 0 minutes
When configuring CSV input data details, we should simplify the reader configuration like
we did for configuring a CSV template.
- Separator Character
- Quote Character
- Field list
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:37 a.m.
New subject: [JBoss JIRA] Commented: (JBIDE-5422) CSV input configuration should be simple like when adding the CSV template
[
https://jira.jboss.org/jira/browse/JBIDE-5422?page=com.atlassian.jira.plu...
]
Tom Fennelly commented on JBIDE-5422:
-------------------------------------
Also.... (add to previous comment)... the "Start Line Number" (maps to skipLines
config on reader) needs to be added here.
CSV input configuration should be simple like when adding the CSV
template
--------------------------------------------------------------------------
Key: JBIDE-5422
URL: https://jira.jboss.org/jira/browse/JBIDE-5422
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: smooks
Affects Versions: 3.1.0.CR2
Reporter: Brian Fitzpatrick
Assignee: Tom Fennelly
Fix For: 3.1.0.CR2
Attachments: JBIDE-5422.patch
Original Estimate: 0 minutes
Remaining Estimate: 0 minutes
When configuring CSV input data details, we should simplify the reader configuration like
we did for configuring a CSV template.
- Separator Character
- Quote Character
- Field list
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:02 a.m.
New subject: [JBoss JIRA] Assigned: (JBIDE-5422) CSV input configuration should be simple like when adding the CSV template
[
https://jira.jboss.org/jira/browse/JBIDE-5422?page=com.atlassian.jira.plu...
]
Brian Fitzpatrick reassigned JBIDE-5422:
----------------------------------------
Assignee: Xue Peng (was: Tom Fennelly)
@Dart - Can you take care of the bits Tom has brought up to simplify this UI a bit?
CSV input configuration should be simple like when adding the CSV
template
--------------------------------------------------------------------------
Key: JBIDE-5422
URL: https://jira.jboss.org/jira/browse/JBIDE-5422
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: smooks
Affects Versions: 3.1.0.CR2
Reporter: Brian Fitzpatrick
Assignee: Xue Peng
Fix For: 3.1.0.CR2
Attachments: JBIDE-5422.patch
Original Estimate: 0 minutes
Remaining Estimate: 0 minutes
When configuring CSV input data details, we should simplify the reader configuration like
we did for configuring a CSV template.
- Separator Character
- Quote Character
- Field list
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:10 a.m.
New subject: [JBoss JIRA] Updated: (JBIDE-5422) CSV input configuration should be simple like when adding the CSV template
[
https://jira.jboss.org/jira/browse/JBIDE-5422?page=com.atlassian.jira.plu...
]
Xue Peng updated JBIDE-5422:
----------------------------
Attachment: csvreader_panel.jpg
CSV input configuration should be simple like when adding the CSV
template
--------------------------------------------------------------------------
Key: JBIDE-5422
URL: https://jira.jboss.org/jira/browse/JBIDE-5422
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: smooks
Affects Versions: 3.1.0.CR2
Reporter: Brian Fitzpatrick
Assignee: Xue Peng
Fix For: 3.1.0.CR2
Attachments: csvreader_panel.jpg, JBIDE-5422.patch
Original Estimate: 0 minutes
Remaining Estimate: 0 minutes
When configuring CSV input data details, we should simplify the reader configuration like
we did for configuring a CSV template.
- Separator Character
- Quote Character
- Field list
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:09 a.m.
New subject: [JBoss JIRA] Commented: (JBIDE-5422) CSV input configuration should be simple like when adding the CSV template
[
https://jira.jboss.org/jira/browse/JBIDE-5422?page=com.atlassian.jira.plu...
]
Brian Fitzpatrick commented on JBIDE-5422:
------------------------------------------
Screen shot looks good to me. :)
CSV input configuration should be simple like when adding the CSV
template
--------------------------------------------------------------------------
Key: JBIDE-5422
URL: https://jira.jboss.org/jira/browse/JBIDE-5422
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: smooks
Affects Versions: 3.1.0.CR2
Reporter: Brian Fitzpatrick
Assignee: Xue Peng
Fix For: 3.1.0.CR2
Attachments: csvreader_panel.jpg, JBIDE-5422.patch
Original Estimate: 0 minutes
Remaining Estimate: 0 minutes
When configuring CSV input data details, we should simplify the reader configuration like
we did for configuring a CSV template.
- Separator Character
- Quote Character
- Field list
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:32 a.m.
New subject: [JBoss JIRA] Updated: (JBIDE-5422) CSV input configuration should be simple like when adding the CSV template
[
https://jira.jboss.org/jira/browse/JBIDE-5422?page=com.atlassian.jira.plu...
]
Brian Fitzpatrick updated JBIDE-5422:
-------------------------------------
This appears to be done. Going to mark it fixed. :)
CSV input configuration should be simple like when adding the CSV
template
--------------------------------------------------------------------------
Key: JBIDE-5422
URL: https://jira.jboss.org/jira/browse/JBIDE-5422
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: smooks
Affects Versions: 3.1.0.CR2
Reporter: Brian Fitzpatrick
Assignee: Xue Peng
Fix For: 3.1.0.CR2
Attachments: csvreader_panel.jpg, JBIDE-5422.patch
Original Estimate: 0 minutes
Remaining Estimate: 0 minutes
When configuring CSV input data details, we should simplify the reader configuration like
we did for configuring a CSV template.
- Separator Character
- Quote Character
- Field list
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:32 a.m.
New subject: [JBoss JIRA] Resolved: (JBIDE-5422) CSV input configuration should be simple like when adding the CSV template
[
https://jira.jboss.org/jira/browse/JBIDE-5422?page=com.atlassian.jira.plu...
]
Brian Fitzpatrick resolved JBIDE-5422.
--------------------------------------
Resolution: Done
CSV input configuration should be simple like when adding the CSV
template
--------------------------------------------------------------------------
Key: JBIDE-5422
URL: https://jira.jboss.org/jira/browse/JBIDE-5422
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: smooks
Affects Versions: 3.1.0.CR2
Reporter: Brian Fitzpatrick
Assignee: Xue Peng
Fix For: 3.1.0.CR2
Attachments: csvreader_panel.jpg, JBIDE-5422.patch
Original Estimate: 0 minutes
Remaining Estimate: 0 minutes
When configuring CSV input data details, we should simplify the reader configuration like
we did for configuring a CSV template.
- Separator Character
- Quote Character
- Field list
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5943
days inactive
5992
days old
jbosstools-issues@lists.jboss.org
16 comments
3 participants
participants (3)
-
Brian Fitzpatrick (JIRA) -
Tom Fennelly (JIRA)
-
Xue Peng (JIRA)