[JBoss JIRA] (JBIDE-10357) Add listeners in VpeController to support full/partial VPE refresh monitoring.
6:41 a.m.
Add listeners in VpeController to support full/partial VPE refresh monitoring.
------------------------------------------------------------------------------
Key: JBIDE-10357
URL: https://issues.jboss.org/browse/JBIDE-10357
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Visual Page Editor core
Affects Versions: 3.3.0.Beta1
Reporter: Maxim Shmidov
Assignee: Yahor Radtsevich
In some cases i need to know when VPE intitiates or finishes visual refresh.
Implementation of required listeners is very simple, and i already have a patch with this
functionality.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:43 a.m.
[
https://issues.jboss.org/browse/JBIDE-10357?page=com.atlassian.jira.plugi...
]
Maxim Shmidov updated JBIDE-10357:
----------------------------------
Attachment: VpeController.java.patch
Add listeners in VpeController to support full/partial VPE refresh
monitoring.
------------------------------------------------------------------------------
Key: JBIDE-10357
URL: https://issues.jboss.org/browse/JBIDE-10357
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Visual Page Editor core
Affects Versions: 3.3.0.Beta1
Reporter: Maxim Shmidov
Assignee: Yahor Radtsevich
Attachments: VpeController.java.patch
In some cases i need to know when VPE intitiates or finishes visual refresh.
Implementation of required listeners is very simple, and i already have a patch with this
functionality.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:13 a.m.
[
https://issues.jboss.org/browse/JBIDE-10357?page=com.atlassian.jira.plugi...
]
Yahor Radtsevich commented on JBIDE-10357:
------------------------------------------
Thanks for the patch, Maxim! I will be happy to apply the patch after you explain/fix
these two issues with it:
# why there are duplicate calls of addJobListeners(uiJob, refreshListeners) in the
following code. Can we move them outside the if/else?
{code:java}
if (uiJob.getState() != Job.RUNNING) {
uiJob.setPriority(Job.LONG);
addJobListeners(uiJob, refreshListeners);
// Fix of JBIDE-1900
uiJob.schedule(getVpeUpdateDelayTime());
} else {
uiJob.cancel();
addJobListeners(uiJob, refreshListeners);
uiJob.schedule(getVpeUpdateDelayTime());
setVpeUpdateDelayTime(400);
}
{code}
# It is not common to check for {{null}} in add/remove listener methods. These methods
should throw an exception (NPE?) in this case.
{code:java}
public void addRefreshJobChangeListener(final IJobChangeListener listener) {
if (listener != null) {
refreshListeners.add(listener);
}
}
{code}
Add listeners in VpeController to support full/partial VPE refresh
monitoring.
------------------------------------------------------------------------------
Key: JBIDE-10357
URL: https://issues.jboss.org/browse/JBIDE-10357
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Visual Page Editor core
Affects Versions: 3.3.0.Beta1
Reporter: Maxim Shmidov
Assignee: Yahor Radtsevich
Attachments: VpeController.java.patch
In some cases i need to know when VPE intitiates or finishes visual refresh.
Implementation of required listeners is very simple, and i already have a patch with this
functionality.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:59 a.m.
[
https://issues.jboss.org/browse/JBIDE-10357?page=com.atlassian.jira.plugi...
]
Maxim Shmidov commented on JBIDE-10357:
---------------------------------------
1. Of course it will be better to move method call outside of if/else clause, but i fear
the potential implications of adding listeners to running job before cancelling it (else
scenario). Of course it is possible to refactor this clause, but i was trying to make
changes as little as possible.
2. ListenerList will throw IllegalArgumentException in case of null argument. I think
you're right, null check is not needed here.
Add listeners in VpeController to support full/partial VPE refresh
monitoring.
------------------------------------------------------------------------------
Key: JBIDE-10357
URL: https://issues.jboss.org/browse/JBIDE-10357
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Visual Page Editor core
Affects Versions: 3.3.0.Beta1
Reporter: Maxim Shmidov
Assignee: Yahor Radtsevich
Attachments: VpeController.java.patch
In some cases i need to know when VPE intitiates or finishes visual refresh.
Implementation of required listeners is very simple, and i already have a patch with this
functionality.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:37 a.m.
[
https://issues.jboss.org/browse/JBIDE-10357?page=com.atlassian.jira.plugi...
]
Maxim Shmidov updated JBIDE-10357:
----------------------------------
Attachment: VpeRefreshEvent.patch
Add listeners in VpeController to support full/partial VPE refresh
monitoring.
------------------------------------------------------------------------------
Key: JBIDE-10357
URL: https://issues.jboss.org/browse/JBIDE-10357
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Visual Page Editor core
Affects Versions: 3.3.0.Beta1
Reporter: Maxim Shmidov
Assignee: Yahor Radtsevich
Attachments: VpeController.java.patch, VpeRefreshEvent.patch
In some cases i need to know when VPE intitiates or finishes visual refresh.
Implementation of required listeners is very simple, and i already have a patch with this
functionality.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:40 a.m.
[
https://issues.jboss.org/browse/JBIDE-10357?page=com.atlassian.jira.plugi...
]
Maxim Shmidov commented on JBIDE-10357:
---------------------------------------
I've added a new version of patch (named "VpeRefreshEvent").
IJobChangeListener is not used there; instead i created new listener interface specially
for vpe refresh event. This event is fired in VpeController at the end of corresponding
jobs. Such approach allows client to remove listener while job is running.
Add listeners in VpeController to support full/partial VPE refresh
monitoring.
------------------------------------------------------------------------------
Key: JBIDE-10357
URL: https://issues.jboss.org/browse/JBIDE-10357
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Visual Page Editor core
Affects Versions: 3.3.0.Beta1
Reporter: Maxim Shmidov
Assignee: Yahor Radtsevich
Attachments: VpeController.java.patch, VpeRefreshEvent.patch
In some cases i need to know when VPE intitiates or finishes visual refresh.
Implementation of required listeners is very simple, and i already have a patch with this
functionality.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:10 a.m.
[
https://issues.jboss.org/browse/JBIDE-10357?page=com.atlassian.jira.plugi...
]
Yahor Radtsevich updated JBIDE-10357:
-------------------------------------
Fix Version/s: 3.3.0.Beta1
Add listeners in VpeController to support full/partial VPE refresh
monitoring.
------------------------------------------------------------------------------
Key: JBIDE-10357
URL: https://issues.jboss.org/browse/JBIDE-10357
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Visual Page Editor core
Affects Versions: 3.3.0.Beta1
Reporter: Maxim Shmidov
Assignee: Yahor Radtsevich
Fix For: 3.3.0.Beta1
Attachments: VpeController.java.patch, VpeRefreshEvent.patch
In some cases i need to know when VPE intitiates or finishes visual refresh.
Implementation of required listeners is very simple, and i already have a patch with this
functionality.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:14 a.m.
[
https://issues.jboss.org/browse/JBIDE-10357?page=com.atlassian.jira.plugi...
]
Yahor Radtsevich updated JBIDE-10357:
-------------------------------------
Attachment: JBIDE10357-applied.patch
I have [^JBIDE10357-applied.patch]. It is the last Maxim's patch with some minor
changes (comments and method names are changed).
Add listeners in VpeController to support full/partial VPE refresh
monitoring.
------------------------------------------------------------------------------
Key: JBIDE-10357
URL: https://issues.jboss.org/browse/JBIDE-10357
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Visual Page Editor core
Affects Versions: 3.3.0.Beta1
Reporter: Maxim Shmidov
Assignee: Yahor Radtsevich
Fix For: 3.3.0.Beta1
Attachments: JBIDE10357-applied.patch, VpeController.java.patch,
VpeRefreshEvent.patch
In some cases i need to know when VPE intitiates or finishes visual refresh.
Implementation of required listeners is very simple, and i already have a patch with this
functionality.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:14 a.m.
[
https://issues.jboss.org/browse/JBIDE-10357?page=com.atlassian.jira.plugi...
]
Yahor Radtsevich edited comment on JBIDE-10357 at 12/9/11 11:14 AM:
--------------------------------------------------------------------
I have applied [^JBIDE10357-applied.patch]. It is the last Maxim's patch with some
minor changes (comments and method names are changed).
was (Author: yradtsevich):
I have [^JBIDE10357-applied.patch]. It is the last Maxim's patch with some minor
changes (comments and method names are changed).
Add listeners in VpeController to support full/partial VPE refresh
monitoring.
------------------------------------------------------------------------------
Key: JBIDE-10357
URL: https://issues.jboss.org/browse/JBIDE-10357
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Visual Page Editor core
Affects Versions: 3.3.0.Beta1
Reporter: Maxim Shmidov
Assignee: Yahor Radtsevich
Fix For: 3.3.0.Beta1
Attachments: JBIDE10357-applied.patch, VpeController.java.patch,
VpeRefreshEvent.patch
In some cases i need to know when VPE intitiates or finishes visual refresh.
Implementation of required listeners is very simple, and i already have a patch with this
functionality.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:16 a.m.
[
https://issues.jboss.org/browse/JBIDE-10357?page=com.atlassian.jira.plugi...
]
Yahor Radtsevich resolved JBIDE-10357.
--------------------------------------
Resolution: Done
*Resolved*
Add listeners in VpeController to support full/partial VPE refresh
monitoring.
------------------------------------------------------------------------------
Key: JBIDE-10357
URL: https://issues.jboss.org/browse/JBIDE-10357
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Visual Page Editor core
Affects Versions: 3.3.0.Beta1
Reporter: Maxim Shmidov
Assignee: Yahor Radtsevich
Fix For: 3.3.0.Beta1
Attachments: JBIDE10357-applied.patch, VpeController.java.patch,
VpeRefreshEvent.patch
In some cases i need to know when VPE intitiates or finishes visual refresh.
Implementation of required listeners is very simple, and i already have a patch with this
functionality.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:38 a.m.
[
https://issues.jboss.org/browse/JBIDE-10357?page=com.atlassian.jira.plugi...
]
Maxim Shmidov commented on JBIDE-10357:
---------------------------------------
Verified in trunk. Everything works fine. Thanks, Yahor.
Add listeners in VpeController to support full/partial VPE refresh
monitoring.
------------------------------------------------------------------------------
Key: JBIDE-10357
URL: https://issues.jboss.org/browse/JBIDE-10357
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Visual Page Editor core
Affects Versions: 3.3.0.Beta1
Reporter: Maxim Shmidov
Assignee: Yahor Radtsevich
Fix For: 3.3.0.Beta1
Attachments: JBIDE10357-applied.patch, VpeController.java.patch,
VpeRefreshEvent.patch
In some cases i need to know when VPE intitiates or finishes visual refresh.
Implementation of required listeners is very simple, and i already have a patch with this
functionality.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:33 p.m.
New subject: [JBoss JIRA] (JBIDE-10357) Add listeners in VpeController to support full/partial VPE refresh monitoring
[
https://issues.jboss.org/browse/JBIDE-10357?page=com.atlassian.jira.plugi...
]
Denis Golovin updated JBIDE-10357:
----------------------------------
Summary: Add listeners in VpeController to support full/partial VPE refresh
monitoring (was: Add listeners in VpeController to support full/partial VPE refresh
monitoring.)
Description: In some cases I need to know when VPE intitiates or finishes visual
refresh. Implementation of required listeners is very simple, and i already have a patch
with this functionality. (was: In some cases i need to know when VPE intitiates or
finishes visual refresh. Implementation of required listeners is very simple, and i
already have a patch with this functionality.)
Add listeners in VpeController to support full/partial VPE refresh
monitoring
-----------------------------------------------------------------------------
Key: JBIDE-10357
URL: https://issues.jboss.org/browse/JBIDE-10357
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Visual Page Editor core
Affects Versions: 3.3.0.Beta1
Reporter: Maxim Shmidov
Assignee: Yahor Radtsevich
Fix For: 3.3.0.Beta1
Attachments: JBIDE10357-applied.patch, VpeController.java.patch,
VpeRefreshEvent.patch
In some cases I need to know when VPE intitiates or finishes visual refresh.
Implementation of required listeners is very simple, and i already have a patch with this
functionality.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:40 a.m.
New subject: [JBoss JIRA] (JBIDE-10357) Add listeners in VpeController to support full/partial VPE refresh monitoring
[
https://issues.jboss.org/browse/JBIDE-10357?page=com.atlassian.jira.plugi...
]
Vlado Pakan commented on JBIDE-10357:
-------------------------------------
Please Maxim could you verify and close this Jira or provide steps how to verify it.
Add listeners in VpeController to support full/partial VPE refresh
monitoring
-----------------------------------------------------------------------------
Key: JBIDE-10357
URL: https://issues.jboss.org/browse/JBIDE-10357
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Visual Page Editor core
Affects Versions: 3.3.0.Beta1
Reporter: Maxim Shmidov
Assignee: Yahor Radtsevich
Fix For: 3.3.0.Beta1
Attachments: JBIDE10357-applied.patch, VpeController.java.patch,
VpeRefreshEvent.patch
In some cases I need to know when VPE intitiates or finishes visual refresh.
Implementation of required listeners is very simple, and i already have a patch with this
functionality.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:56 a.m.
New subject: [JBoss JIRA] (JBIDE-10357) Add listeners in VpeController to support full/partial VPE refresh monitoring
[
https://issues.jboss.org/browse/JBIDE-10357?page=com.atlassian.jira.plugi...
]
Yahor Radtsevich commented on JBIDE-10357:
------------------------------------------
{quote}
Please Maxim could you verify and close this Jira or provide steps how to verify it.
{quote}
Maxim has already verified it (see his last comment). But he does not have the rights to
close this issue.
Add listeners in VpeController to support full/partial VPE refresh
monitoring
-----------------------------------------------------------------------------
Key: JBIDE-10357
URL: https://issues.jboss.org/browse/JBIDE-10357
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Visual Page Editor core
Affects Versions: 3.3.0.Beta1
Reporter: Maxim Shmidov
Assignee: Yahor Radtsevich
Fix For: 3.3.0.Beta1
Attachments: JBIDE10357-applied.patch, VpeController.java.patch,
VpeRefreshEvent.patch
In some cases I need to know when VPE intitiates or finishes visual refresh.
Implementation of required listeners is very simple, and i already have a patch with this
functionality.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:38 a.m.
New subject: [JBoss JIRA] (JBIDE-10357) Add listeners in VpeController to support full/partial VPE refresh monitoring
[
https://issues.jboss.org/browse/JBIDE-10357?page=com.atlassian.jira.plugi...
]
Vlado Pakan closed JBIDE-10357.
-------------------------------
Add listeners in VpeController to support full/partial VPE refresh
monitoring
-----------------------------------------------------------------------------
Key: JBIDE-10357
URL: https://issues.jboss.org/browse/JBIDE-10357
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Visual Page Editor core
Affects Versions: 3.3.0.Beta1
Reporter: Maxim Shmidov
Assignee: Yahor Radtsevich
Fix For: 3.3.0.Beta1
Attachments: JBIDE10357-applied.patch, VpeController.java.patch,
VpeRefreshEvent.patch
In some cases I need to know when VPE intitiates or finishes visual refresh.
Implementation of required listeners is very simple, and i already have a patch with this
functionality.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
4639
days inactive
4680
days old
jbosstools-issues@lists.jboss.org
14 comments
10 participants
participants (10)
-
Denis Golovin (Updated) (JIRA) -
Maxim Shmidov (Commented) (JIRA)
-
Maxim Shmidov (Created) (JIRA)
-
Maxim Shmidov (Updated) (JIRA)
-
Vlado Pakan (JIRA)
-
Yahor Radtsevich (Commented) (JIRA)
-
Yahor Radtsevich (Issue Comment Edited) (JIRA)
-
Yahor Radtsevich (JIRA)
-
Yahor Radtsevich (Resolved) (JIRA)
-
Yahor Radtsevich (Updated) (JIRA)