[ https://jira.jboss.org/jira/browse/JBIDE-3253?page=com.atlassian.jira.plu... ] Rob Stryker resolved JBIDE-3253. -------------------------------- Resolution: Done Assignee: Rob Stryker There were several problems with the search bar. The constant thread access left it in an iffy state often, especially since each launched thread worked on the exact same map (on the assumption only one thread was launched at a time, which turned out not to be true) Also, when a new keypress is initiated, the old thread (in the middle of pruning down the match list) often left the map in an uncertain state, half completed. The new implementation gives each thread a clone of the map. Only when the thread completes can it set the list of matches back to the view. This way, partial refinements are not persisted and only completed ones alert the view. Much cleaner. I like it more gooder. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-3253?page=com.atlassian.jira.plu... ] Rob Stryker commented on JBIDE-3253: ------------------------------------ The first thread does get canceled, however in the last implementation, because the cancelation is done with a variable (setStopped()), there's no guarantee when that thread will stop. So as was done before, I'd perform setStopped(), then launch newThread. Then both threads could be working on the same map. In the new implementation, the first thread will stop sometime after setStopped() is called, but, at least they're not working on the same map now and changes will only be "persisted" if the thread actually finishes. The first thread *is* canceled in both the before and the current cases. The difference was what maps the threads were acting on. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira