[ https://jira.jboss.org/browse/JBIDE-6346?page=com.atlassian.jira.plugin.s... ] Victor Rubezhny updated JBIDE-6346: ----------------------------------- Fix Version/s: 3.2-Helios Affects Version/s: 3.2-Helios -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBIDE-6346?page=com.atlassian.jira.plugin.s... ] Victor Rubezhny commented on JBIDE-6346: ---------------------------------------- The issue is reproducible only when at least one Seam project (registered in JBoss AS) exists in the workspace. See the trace below which probably describes the operations which slows down name validation: Thread [main] (Suspended) Inflater.inflateBytes(byte[], int, int) line: not available [native method] Inflater.inflate(byte[], int, int) line: 215 ZipFile$2(InflaterInputStream).read(byte[], int, int) line: 128 BufferedInputStream.read1(byte[], int, int) line: 254 BufferedInputStream.read(byte[], int, int) line: 313 Util.getInputStreamAsByteArray(InputStream, int) line: 323 ToolFactory.createDefaultClassFileReader(InputStream, int) line: 268 JavaEEArchiveUtilities.isEJBArchive(IArchive) line: 728 JavaEEArchiveUtilities.refineForJavaEE(IArchive) line: 538 JavaEEArchiveUtilities.openArchive(ArchiveOptions) line: 330 JavaEEArchiveUtilities(ArchiveFactoryImpl).openArchive(IPath) line: 47 JavaEEBinaryComponentHelper.getJavaEEQuickPeek(IPath) line: 55 JavaEEProjectUtilities.getJ2EEFileType(IPath) line: 219 JEEHeirarchyExportParticipant.isChildModule(IVirtualComponent, FlatVirtualComponent$FlatComponentTaskModel, IFlatFile) line: 54 FlatVirtualComponent.shouldAddComponentFile(IVirtualComponent, IFlatFile) line: 210 VirtualComponentFlattenUtility.addFile(IVirtualComponent, IPath, IAdaptable) line: 118 VirtualComponentFlattenUtility.addFile(IVirtualComponent, IFile, IPath) line: 135 VirtualComponentFlattenUtility.addMembersInternal(IVirtualComponent, IVirtualContainer, IPath) line: 99 VirtualComponentFlattenUtility.addMembersInternal(IVirtualComponent, IVirtualContainer, IPath) line: 95 VirtualComponentFlattenUtility.addMembersInternal(IVirtualComponent, IVirtualContainer, IPath) line: 95 VirtualComponentFlattenUtility.addMembers(IVirtualComponent, IVirtualContainer, IPath) line: 50 FlatVirtualComponent.treeWalk() line: 162 FlatVirtualComponent.cacheResources() line: 120 FlatVirtualComponent.getChildModules() line: 110 JEEFlexProjDeployable(FlatComponentDeployable).getExportModelChildren() line: 144 JEEFlexProjDeployable(FlatComponentDeployable).getModules() line: 155 JBossServer(DeployableServer).doGetParentModules(IModule) line: 92 JBossServer(DeployableServer).getRootModules(IModule) line: 74 Server.getRootModules(IModule, IProgressMonitor) line: 2300 RegistrationHelper.getRegistrationError(IModule, String, IServer) line: 97 RegisterServerContext.getErrorMessage() line: 176 NewProjectWizard(NewWebProjectWizard).canFinish() line: 52 WizardDialog.updateButtons() line: 1318 NewProjectWizardPage(WizardPage).setPageComplete(boolean) line: 299 NewWebProjectWizardPage$LocationAdapter.setValue(Object) line: 383 NewWebProjectWizardPage$NameAdapter.setValue(Object) line: 374 NewWebProjectWizardPage$NameAdapter(NewWebProjectWizardPage$LocalValueProvider).valueChange(PropertyChangeEvent) line: 353 StringFieldEditorEx.propertyChange(PropertyChangeEvent) line: 77 StringFieldEditorEx(FieldEditor).fireValueChanged(String, Object, Object) line: 350 StringFieldEditorEx(StringFieldEditor).valueChanged() line: 328 StringFieldEditor$1.modifyText(ModifyEvent) line: 178 TypedListener.handleEvent(Event) line: 167 EventTable.sendEvent(Event) line: 84 Text(Widget).sendEvent(Event) line: 1050 Text(Widget).sendEvent(int, Event, boolean) line: 1074 Text(Widget).sendEvent(int) line: 1055 Text.wmCommandChild(int, int) line: 2526 BorderedControl(Control).WM_COMMAND(int, int) line: 4276 BorderedControl(Control).windowProc(int, int, int, int) line: 4142 BorderedControl(Canvas).windowProc(int, int, int, int) line: 341 Display.windowProc(int, int, int, int) line: 4843 OS.CallWindowProcW(int, int, int, int, int) line: not available [native method] OS.CallWindowProc(int, int, int, int, int) line: 2359 Text.callWindowProc(int, int, int, int) line: 255 Text(Control).windowProc(int, int, int, int) line: 4230 Text.windowProc(int, int, int, int) line: 2170 Display.windowProc(int, int, int, int) line: 4830 OS.DispatchMessageW(MSG) line: not available [native method] OS.DispatchMessage(MSG) line: 2456 Display.readAndDispatch() line: 3626 WizardDialog(Window).runEventLoop(Shell) line: 825 WizardDialog(Window).open() line: 801 WizardHandler$New.executeHandler(ExecutionEvent) line: 254 WizardHandler$New(WizardHandler).execute(ExecutionEvent) line: 274 HandlerProxy.execute(ExecutionEvent) line: 293 Command.executeWithChecks(ExecutionEvent) line: 476 ParameterizedCommand.executeWithChecks(Object, Object) line: 508 HandlerService.executeCommand(ParameterizedCommand, Event) line: 169 SlaveHandlerService.executeCommand(ParameterizedCommand, Event) line: 241 ActionFactory$WorkbenchCommandAction(CommandAction).runWithEvent(Event) line: 157 ActionContributionItem.handleWidgetSelection(Event, boolean) line: 584 ActionContributionItem.access$2(ActionContributionItem, Event, boolean) line: 501 ActionContributionItem$5.handleEvent(Event) line: 411 EventTable.sendEvent(Event) line: 84 MenuItem(Widget).sendEvent(Event) line: 1050 Display.runDeferredEvents() line: 4037 Display.readAndDispatch() line: 3628 Workbench.runEventLoop(Window$IExceptionHandler, Display) line: 2416 Workbench.runUI() line: 2380 Workbench.access$4(Workbench) line: 2229 Workbench$5.run() line: 504 Realm.runWithDefault(Realm, Runnable) line: 332 Workbench.createAndRunWorkbench(Display, WorkbenchAdvisor) line: 497 PlatformUI.createAndRunWorkbench(Display, WorkbenchAdvisor) line: 149 IDEApplication.start(IApplicationContext) line: 115 EclipseAppHandle.run(Object) line: 196 EclipseAppLauncher.runApplication(Object) line: 110 EclipseAppLauncher.start(Object) line: 79 EclipseStarter.run(Object) line: 369 EclipseStarter.run(String[], Runnable) line: 179 NativeMethodAccessorImpl.invoke0(Method, Object, Object[]) line: not available [native method] NativeMethodAccessorImpl.invoke(Object, Object[]) line: 39 DelegatingMethodAccessorImpl.invoke(Object, Object[]) line: 25 Method.invoke(Object, Object...) line: 585 Main.invokeFramework(String[], URL[]) line: 619 Main.basicRun(String[]) line: 574 Main.run(String[]) line: 1406 Main.main(String[]) line: 1382 -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBIDE-6346?page=com.atlassian.jira.plugin.s... ] Max Rydahl Andersen updated JBIDE-6346: --------------------------------------- Assignee: Rob Stryker (was: Viacheslav Kabanovich) Priority: Critical (was: Major) Component/s: JBossAS (was: JSF) (was: struts/shale) Rob - something we can fix or WTP API deficiency ? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBIDE-6346?page=com.atlassian.jira.plugin.s... ] Rob Stryker commented on JBIDE-6346: ------------------------------------ There are already other bugs opened for wtp 3.2.1 for performance issues... they didn't make it into 3.2 proper because they were not deemed critical. https://bugs.eclipse.org/bugs/show_bug.cgi?id=316024 However I'm sure other changes can be made here in our code as well. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBIDE-6346?page=com.atlassian.jira.plugin.s... ] Rob Stryker updated JBIDE-6346: ------------------------------- Attachment: JBIDE-6346.patch The following patch makes the UI a lot more efficient, and I'm in favor of 90% of the patch. I did, however, comment out 5 lines which I'm not sure why they were there at all, and it may be that someone needs to review the removal of those 5 lines. Basically, instead of using static methods that each time traverse the module tree, I added a constructor and a cache that can be used if someone wants. However the most troublesome method of the entire batch is the call to server.getRootModules(m, null); The reason this is troublesome is that if your workspace has a lot of projects, and you're asking it to find the root / parent of project A, it will get Project B, get *it's* list of children, see if they match, get project C, get *it's* list of children, see if htey match, etc. Right now, on the project level in wtp, the cache is not enabled. It is set to be enabled in 3.2.1. Angel was scared to add it in. So parsing the same project twice in a row will take a long time. It may be the call to server.getRootModules(m,null) is there for a reason, but it is not commented and I am not sure what (if any) benefit it provides. I ran some manual (non-scientific) tests with just my cache added, and not commenting out the get parent module call. My cache helps a lot, but the majority of the gains were by removing the get parent module call. Hope this helps. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBIDE-6346?page=com.atlassian.jira.plugin.s... ] Rob Stryker commented on JBIDE-6346: ------------------------------------ Do the following 4 lines have a reason to be in RegistrationHelper?? If we can remove them it would go much faster. If they need to be there then this will stay slow. try { server.getRootModules(m, null); } catch (CoreException ce) { WebModelPlugin.getPluginLog().logError(ce); return ce.getStatus().getMessage(); } -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBIDE-6346?page=com.atlassian.jira.plugin.s... ] Viacheslav Kabanovich commented on JBIDE-6346: ---------------------------------------------- Usage of this call is a part of validation. WST's tools modifying servers do this call too (for example, NewServerComposite.isSupportedModule() ) and if exception is caught, it is displayed as error message in wizard. When I first implemented in New Struts/JSF projects wizard the functionality of adding module to a server, I observed that sometimes it crashes, and adding this call to catch exception and display it as error message in wizard solved the problem by displaying problem before wizard is completed and failed in process of adding new module to the selected server. The cause of this exception might be disability of a server to process a module; and that could be as a bug in server implementation as a way for validation. By the way, logging was added by someone later and should not be there. Since logging appeared, nobody complained about such log output, which may indicate that for years passed that exception has ceased to be thrown for used servers and modules. If we can be sure that the exception will not bother us anymore we may remove this check. I am not sure of that. Also, as I wrote before, this issue was mostly caused by repeating check on each keystroke to the project name field. That is already solved. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBIDE-6346?page=com.atlassian.jira.plugin.s... ] Viacheslav Kabanovich commented on JBIDE-6346: ---------------------------------------------- Sure, Rob, sorry that I failed to mention that apart from those commented lines I found your patch necessary to use. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBIDE-6346?page=com.atlassian.jira.plugin.s... ] Rob Stryker commented on JBIDE-6346: ------------------------------------ I'll double check this after lunch =] -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBIDE-6346?page=com.atlassian.jira.plugin.s... ] Viacheslav Kabanovich resolved JBIDE-6346. ------------------------------------------ Resolution: Done -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBIDE-6346?page=com.atlassian.jira.plugin.s... ] Vlado Pakan closed JBIDE-6346. ------------------------------ Verified on JBDS 4.0.0.v201008261621R-H420-M2 -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira