[JBoss JIRA] (JBIDE-10228) org.jboss.tools.jst.css.dialog.widgets.ImageCombo has incorrect logik with Image dispose
7:40 a.m.
org.jboss.tools.jst.css.dialog.widgets.ImageCombo has incorrect logik with Image dispose
----------------------------------------------------------------------------------------
Key: JBIDE-10228
URL: https://issues.jboss.org/browse/JBIDE-10228
Project: Tools (JBoss Tools)
Issue Type: Sub-task
Components: common/jst/core
Affects Versions: 3.3.0.M4
Reporter: Vitali Yemialyanchyk
Assignee: Alexey Kazakov
line 226:
{code}
public void add(String string, Image image) {
...
if (image != null) {
newItem.setImage(image); <-----------
here you get image if it not null
}
newItem.addDisposeListener(new DisposeListener() {
public void widgetDisposed(DisposeEvent e) {
TableItem item = (TableItem) e.getSource();
item.getImage().dispose(); <-----------
here you dispose image in any case
}
});
...
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:43 a.m.
[
https://issues.jboss.org/browse/JBIDE-10228?page=com.atlassian.jira.plugi...
]
Max Rydahl Andersen updated JBIDE-10228:
----------------------------------------
Fix Version/s: 3.3.0.Beta1
Setting fix version to look at these in Beta1 if resource leaks even have an effect.
org.jboss.tools.jst.css.dialog.widgets.ImageCombo has incorrect logik
with Image dispose
----------------------------------------------------------------------------------------
Key: JBIDE-10228
URL: https://issues.jboss.org/browse/JBIDE-10228
Project: Tools (JBoss Tools)
Issue Type: Sub-task
Components: common/jst/core
Affects Versions: 3.3.0.M4
Reporter: Vitali Yemialyanchyk
Assignee: Alexey Kazakov
Fix For: 3.3.0.Beta1
line 226:
{code}
public void add(String string, Image image) {
...
if (image != null) {
newItem.setImage(image); <-----------
here you get image if it not null
}
newItem.addDisposeListener(new DisposeListener() {
public void widgetDisposed(DisposeEvent e) {
TableItem item = (TableItem) e.getSource();
item.getImage().dispose(); <-----------
here you dispose image in any case
}
});
...
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:05 a.m.
[
https://issues.jboss.org/browse/JBIDE-10228?page=com.atlassian.jira.plugi...
]
Victor Rubezhny updated JBIDE-10228:
------------------------------------
Attachment: jbide-10228.patch
Patch jbide-10228.patch fixes the issue
org.jboss.tools.jst.css.dialog.widgets.ImageCombo has incorrect logik
with Image dispose
----------------------------------------------------------------------------------------
Key: JBIDE-10228
URL: https://issues.jboss.org/browse/JBIDE-10228
Project: Tools (JBoss Tools)
Issue Type: Sub-task
Components: common/jst/core
Affects Versions: 3.3.0.M4
Reporter: Vitali Yemialyanchyk
Assignee: Alexey Kazakov
Fix For: 3.3.0.Beta1
Attachments: jbide-10228.patch
line 226:
{code}
public void add(String string, Image image) {
...
if (image != null) {
newItem.setImage(image); <-----------
here you get image if it not null
}
newItem.addDisposeListener(new DisposeListener() {
public void widgetDisposed(DisposeEvent e) {
TableItem item = (TableItem) e.getSource();
item.getImage().dispose(); <-----------
here you dispose image in any case
}
});
...
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:20 p.m.
[
https://issues.jboss.org/browse/JBIDE-10228?page=com.atlassian.jira.plugi...
]
Viacheslav Kabanovich commented on JBIDE-10228:
-----------------------------------------------
I think this method should not dispose image at all. It is public, so that other clients
may call it with images managed elsewhere. This dialog is creating 414 new images at the
start and then 138 new images each time color attribute is clicked. The images are
disposed afterwards, but it is better to create once 138 images for named colors, register
them in the image registry, and then reuse.
org.jboss.tools.jst.css.dialog.widgets.ImageCombo has incorrect logik
with Image dispose
----------------------------------------------------------------------------------------
Key: JBIDE-10228
URL: https://issues.jboss.org/browse/JBIDE-10228
Project: Tools (JBoss Tools)
Issue Type: Sub-task
Components: common/jst/core
Affects Versions: 3.3.0.M4
Reporter: Vitali Yemialyanchyk
Assignee: Viacheslav Kabanovich
Fix For: 3.3.0.Beta1
Attachments: jbide-10228.patch
line 226:
{code}
public void add(String string, Image image) {
...
if (image != null) {
newItem.setImage(image); <-----------
here you get image if it not null
}
newItem.addDisposeListener(new DisposeListener() {
public void widgetDisposed(DisposeEvent e) {
TableItem item = (TableItem) e.getSource();
item.getImage().dispose(); <-----------
here you dispose image in any case
}
});
...
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:58 p.m.
[
https://issues.jboss.org/browse/JBIDE-10228?page=com.atlassian.jira.plugi...
]
Vitali Yemialyanchyk commented on JBIDE-10228:
----------------------------------------------
I do not sure is this comment to this issue or may be some other from JBIDE-10221 list...
in general patch, which Victor propose is something, which I expected in this case. One
note: it whould be nice to obey the rule "where you create a resource, there
dispose". So may be possible somehow change the logic, I have no sources at this
moment, so can not propose something better.
About image numbers... if you wrote about this case, cause I did not dig into details.
414 new images and 138 images - it is a really big number of resources to allocate for and
store for a long Eclipse run session to get "No more handlers" exception. There
are concret recomendations in SWT documentation about it. As I remember I saw such
recommendations, but can not post a link - will try to find it tomorrow. Only few number
of really useful images should be in plugin storage, others should be dispoused after it
use - this is formulation, which I got from these recommendations...
org.jboss.tools.jst.css.dialog.widgets.ImageCombo has incorrect logik
with Image dispose
----------------------------------------------------------------------------------------
Key: JBIDE-10228
URL: https://issues.jboss.org/browse/JBIDE-10228
Project: Tools (JBoss Tools)
Issue Type: Sub-task
Components: common/jst/core
Affects Versions: 3.3.0.M4
Reporter: Vitali Yemialyanchyk
Assignee: Viacheslav Kabanovich
Fix For: 3.3.0.Beta1
Attachments: jbide-10228.patch
line 226:
{code}
public void add(String string, Image image) {
...
if (image != null) {
newItem.setImage(image); <-----------
here you get image if it not null
}
newItem.addDisposeListener(new DisposeListener() {
public void widgetDisposed(DisposeEvent e) {
TableItem item = (TableItem) e.getSource();
item.getImage().dispose(); <-----------
here you dispose image in any case
}
});
...
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:04 p.m.
[
https://issues.jboss.org/browse/JBIDE-10228?page=com.atlassian.jira.plugi...
]
Vitali Yemialyanchyk commented on JBIDE-10228:
----------------------------------------------
i.e. if you deside to store all images in pluging storage during whole Eclipse run session
- it is equal to resources leaks, cause here the number of handlers is restricted to
rather small number.
org.jboss.tools.jst.css.dialog.widgets.ImageCombo has incorrect logik
with Image dispose
----------------------------------------------------------------------------------------
Key: JBIDE-10228
URL: https://issues.jboss.org/browse/JBIDE-10228
Project: Tools (JBoss Tools)
Issue Type: Sub-task
Components: common/jst/core
Affects Versions: 3.3.0.M4
Reporter: Vitali Yemialyanchyk
Assignee: Viacheslav Kabanovich
Fix For: 3.3.0.Beta1
Attachments: jbide-10228.patch
line 226:
{code}
public void add(String string, Image image) {
...
if (image != null) {
newItem.setImage(image); <-----------
here you get image if it not null
}
newItem.addDisposeListener(new DisposeListener() {
public void widgetDisposed(DisposeEvent e) {
TableItem item = (TableItem) e.getSource();
item.getImage().dispose(); <-----------
here you dispose image in any case
}
});
...
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:06 p.m.
[
https://issues.jboss.org/browse/JBIDE-10228?page=com.atlassian.jira.plugi...
]
Viacheslav Kabanovich commented on JBIDE-10228:
-----------------------------------------------
This dialog may create even more new images at start. 'Property Sheet' tab has 8
color attributes. If they are set, they are also added to 'Edited properties' tab,
which is fully loaded at start. In this case dialog creates at start 1518 new images and
then 1104 each time you switch to 'Edited properties' tab.
org.jboss.tools.jst.css.dialog.widgets.ImageCombo has incorrect logik
with Image dispose
----------------------------------------------------------------------------------------
Key: JBIDE-10228
URL: https://issues.jboss.org/browse/JBIDE-10228
Project: Tools (JBoss Tools)
Issue Type: Sub-task
Components: common/jst/core
Affects Versions: 3.3.0.M4
Reporter: Vitali Yemialyanchyk
Assignee: Viacheslav Kabanovich
Fix For: 3.3.0.Beta1
Attachments: jbide-10228.patch
line 226:
{code}
public void add(String string, Image image) {
...
if (image != null) {
newItem.setImage(image); <-----------
here you get image if it not null
}
newItem.addDisposeListener(new DisposeListener() {
public void widgetDisposed(DisposeEvent e) {
TableItem item = (TableItem) e.getSource();
item.getImage().dispose(); <-----------
here you dispose image in any case
}
});
...
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:21 p.m.
[
https://issues.jboss.org/browse/JBIDE-10228?page=com.atlassian.jira.plugi...
]
Vitali Yemialyanchyk commented on JBIDE-10228:
----------------------------------------------
it is very big values, if I correct 10000 is maximum number for handlers, for dialogs
images have to be disposed immediately after dialog close. Only few images for dialog can
exist - JBossTools logo is a good example.
org.jboss.tools.jst.css.dialog.widgets.ImageCombo has incorrect logik
with Image dispose
----------------------------------------------------------------------------------------
Key: JBIDE-10228
URL: https://issues.jboss.org/browse/JBIDE-10228
Project: Tools (JBoss Tools)
Issue Type: Sub-task
Components: common/jst/core
Affects Versions: 3.3.0.M4
Reporter: Vitali Yemialyanchyk
Assignee: Viacheslav Kabanovich
Fix For: 3.3.0.Beta1
Attachments: jbide-10228.patch
line 226:
{code}
public void add(String string, Image image) {
...
if (image != null) {
newItem.setImage(image); <-----------
here you get image if it not null
}
newItem.addDisposeListener(new DisposeListener() {
public void widgetDisposed(DisposeEvent e) {
TableItem item = (TableItem) e.getSource();
item.getImage().dispose(); <-----------
here you dispose image in any case
}
});
...
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:18 p.m.
[
https://issues.jboss.org/browse/JBIDE-10228?page=com.atlassian.jira.plugi...
]
Viacheslav Kabanovich commented on JBIDE-10228:
-----------------------------------------------
Vitali, if we use image registry, we have to store only 138 images, because all color
combos use the same set. Maybe 138 is large enough to cause a concern, but I think it is
better than 1518 at dialog start. If you think registry should be cleaned on dialog
disposal, we can do that.
org.jboss.tools.jst.css.dialog.widgets.ImageCombo has incorrect logik
with Image dispose
----------------------------------------------------------------------------------------
Key: JBIDE-10228
URL: https://issues.jboss.org/browse/JBIDE-10228
Project: Tools (JBoss Tools)
Issue Type: Sub-task
Components: common/jst/core
Affects Versions: 3.3.0.M4
Reporter: Vitali Yemialyanchyk
Assignee: Viacheslav Kabanovich
Fix For: 3.3.0.Beta1
Attachments: jbide-10228.patch
line 226:
{code}
public void add(String string, Image image) {
...
if (image != null) {
newItem.setImage(image); <-----------
here you get image if it not null
}
newItem.addDisposeListener(new DisposeListener() {
public void widgetDisposed(DisposeEvent e) {
TableItem item = (TableItem) e.getSource();
item.getImage().dispose(); <-----------
here you dispose image in any case
}
});
...
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:55 p.m.
[
https://issues.jboss.org/browse/JBIDE-10228?page=com.atlassian.jira.plugi...
]
Viacheslav Kabanovich commented on JBIDE-10228:
-----------------------------------------------
Now, at start dialog creates 138 images, puts them to plugin image registry, reuses them
as needed by new combos created during work with the dialog, and at closing the dialog
removes them from the registry.
org.jboss.tools.jst.css.dialog.widgets.ImageCombo has incorrect logik
with Image dispose
----------------------------------------------------------------------------------------
Key: JBIDE-10228
URL: https://issues.jboss.org/browse/JBIDE-10228
Project: Tools (JBoss Tools)
Issue Type: Sub-task
Components: common/jst/core
Affects Versions: 3.3.0.M4
Reporter: Vitali Yemialyanchyk
Assignee: Viacheslav Kabanovich
Fix For: 3.3.0.Beta1
Attachments: jbide-10228.patch
line 226:
{code}
public void add(String string, Image image) {
...
if (image != null) {
newItem.setImage(image); <-----------
here you get image if it not null
}
newItem.addDisposeListener(new DisposeListener() {
public void widgetDisposed(DisposeEvent e) {
TableItem item = (TableItem) e.getSource();
item.getImage().dispose(); <-----------
here you dispose image in any case
}
});
...
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:02 p.m.
[
https://issues.jboss.org/browse/JBIDE-10228?page=com.atlassian.jira.plugi...
]
Viacheslav Kabanovich resolved JBIDE-10228.
-------------------------------------------
Resolution: Done
org.jboss.tools.jst.css.dialog.widgets.ImageCombo has incorrect logik
with Image dispose
----------------------------------------------------------------------------------------
Key: JBIDE-10228
URL: https://issues.jboss.org/browse/JBIDE-10228
Project: Tools (JBoss Tools)
Issue Type: Sub-task
Components: common/jst/core
Affects Versions: 3.3.0.M4
Reporter: Vitali Yemialyanchyk
Assignee: Viacheslav Kabanovich
Fix For: 3.3.0.Beta1
Attachments: jbide-10228.patch
line 226:
{code}
public void add(String string, Image image) {
...
if (image != null) {
newItem.setImage(image); <-----------
here you get image if it not null
}
newItem.addDisposeListener(new DisposeListener() {
public void widgetDisposed(DisposeEvent e) {
TableItem item = (TableItem) e.getSource();
item.getImage().dispose(); <-----------
here you dispose image in any case
}
});
...
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:46 p.m.
[
https://issues.jboss.org/browse/JBIDE-10228?page=com.atlassian.jira.plugi...
]
Alexey Kazakov updated JBIDE-10228:
-----------------------------------
Fix Version/s: 3.3.0.M5
(was: 3.3.0.Beta1)
Was fixed for 3.3.0.M5
org.jboss.tools.jst.css.dialog.widgets.ImageCombo has incorrect logik
with Image dispose
----------------------------------------------------------------------------------------
Key: JBIDE-10228
URL: https://issues.jboss.org/browse/JBIDE-10228
Project: Tools (JBoss Tools)
Issue Type: Sub-task
Components: common/jst/core
Affects Versions: 3.3.0.M4
Reporter: Vitali Yemialyanchyk
Assignee: Viacheslav Kabanovich
Fix For: 3.3.0.M5
Attachments: jbide-10228.patch
line 226:
{code}
public void add(String string, Image image) {
...
if (image != null) {
newItem.setImage(image); <-----------
here you get image if it not null
}
newItem.addDisposeListener(new DisposeListener() {
public void widgetDisposed(DisposeEvent e) {
TableItem item = (TableItem) e.getSource();
item.getImage().dispose(); <-----------
here you dispose image in any case
}
});
...
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
5233
days inactive
5245
days old
jbosstools-issues@lists.jboss.org
11 comments
7 participants
participants (7)
-
Alexey Kazakov (Updated) (JIRA) -
Max Rydahl Andersen (Updated) (JIRA)
-
Viacheslav Kabanovich (Commented) (JIRA)
-
Viacheslav Kabanovich (Resolved) (JIRA)
-
Victor Rubezhny (Updated) (JIRA)
-
Vitali Yemialyanchyk (Commented) (JIRA)
-
Vitali Yemialyanchyk (Created) (JIRA)