[ http://jira.jboss.com/jira/browse/JBIDE-1124?page=all ] Max Andersen updated JBIDE-1124: -------------------------------- Assignee: Alexey Kazakov (was: Viacheslav Kabanovich) i guess this might be for alex or victor instead ? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBIDE-1124?page=all ] Alexey Kazakov reassigned JBIDE-1124: ------------------------------------- Assignee: Victor Rubezhny (was: Alexey Kazakov) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBIDE-1124?page=comments#action_12383465 ] Max Andersen commented on JBIDE-1124: ------------------------------------- 1) There should not be any EL content assistance in hbm.xml files 2) HBMXMLStructuredTextViewerConfiguration is used - see it's plugin.xml where there is the following: <sourceViewerConfiguration target="org.hibernate.eclipse.mapper.hbmxmlsource" class="org.hibernate.eclipse.mapper.editors.HBMXMLStructuredTextViewerConfiguration" /> This will work with WTP xml editors and worked before 3) http://www.hibernate.org/hib_docs/tools/viewlets/hbmxml_editing.htm shows hbm.xml completion in hibernate tools (which works when it is installed standalone) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBIDE-1124?page=comments#action_12383541 ] Victor Rubezhny commented on JBIDE-1124: ---------------------------------------- "1) There should not be any EL content assistance in hbm.xml files " Is it a strong requirement to exclude any EL CA from hbm.xml files? Why I'm asking: For some reasons there is a hack in RHDS text editors that always uses RedHatStructuredTextViewerConfigurationXML configuration for all xml-files. If we open an hbm.xml-file by JBoss Tools XML Text Editor (RHDS XML Text Editor) - the EditorPartWrapperExtention finds the Hibernate3CompaundEditor in "org.jboss.tools.common.model.ui.xmlEditor" extension point. Hibernate3CompaundEditor is multipage editor which uses XMLTextEditor as source editor. RedHatStructuredTextViewerConfigurationXML is hardcoded as XMLTextEditor's source viewer cofiguration. Result: You see the CA and OpenOns from the RHDS. In another case, while we open an hbm-xml-file by XML Editor (non-JBoss Tools) the XMLMultiPageEditorPart creates StructuredTextEditor as source editor. On setInput it searches the registry for configuration and finds RedHatStructuredTextViewerConfigurationXML as configuration for target content type "org.jboss.tools.common.model.ui.xml". This becomes as result of specifying "org.jboss.tools.common.model.ui.xml" as the highest priority content type for any xml file. Result: O-o-ops! You see the CA and OpenOns from the RHDS again. And no Hibernate CA. As result I can add HBMXMLStructuredTextViewerConfiguration as "initial" source viewer configuration and its CA processors will return Hibernate proposals simultaneously with other JBoss Tools CA processors (Seam EL for example) registered for RedHatStructuredTextViewerConfigurationXML. For the XML Editor its needed to change <content-type base-type="org.eclipse.core.runtime.xml" ... /> to <content-type base-type="org.jboss.tools.common.model.ui.xml" ... /> in org.hibernate.eclipse.mapper/plugin.xml's declarations for content types. This will invoke the BMXMLStructuredTextViewerConfiguration for hbm.xml-files in XML Editor. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBIDE-1124?page=comments#action_12383543 ] Victor Rubezhny commented on JBIDE-1124: ---------------------------------------- Yet another question: Can I commit org.hibernate.eclipse.mapper/plugin.xml file changes to svn? I mean changing base-type="org.eclipse.core.runtime.xml" to base-type="org.jboss.tools.common.model.ui.xml" for content types. It will impact the hibernate xml editors when in case they will work standalone (with no JBoss Tools installed)... they will never work standalone. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBIDE-1124?page=comments#action_12383548 ] Victor Rubezhny commented on JBIDE-1124: ---------------------------------------- "Couldn't we remove the hbm.xml content recognizition from the list of things that is categorized as "org.jboss.tools.common.model.ui.xml" and just in the RedHatStructuredTextViewerConfigurationXML lookup the one that org.hibernate.tools will recognize ? Afaik the rhstvcXML does not provide any additional code completion. " Probably not, because it's needed for "Hibernate 3.0 XML Editor" and "Hibernate Configuration 3.0 XML Editor". And it's deep inside "...common.model.ui..." caves. :( Need to consult with Slava on possible workarouds... -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBIDE-1124?page=comments#action_12383781 ] Max Andersen commented on JBIDE-1124: ------------------------------------- what was the fix ? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira