[ https://jira.jboss.org/jira/browse/JBIDE-4142?page=com.atlassian.jira.plu... ] Alexey Kazakov updated JBIDE-4142: ---------------------------------- Issue Type: Bug (was: Feature Request) Component/s: Visual Page Editor core (was: jsp/jsf/xml source editing) Assignee: Maxim Areshkau When I tried it in VPE I got: java.lang.NullPointerException at org.jboss.tools.vpe.editor.VpeVisualDomBuilder.innerDrop(VpeVisualDomBuilder.java:1742) at org.jboss.tools.vpe.editor.VpeController.drop(VpeController.java:2558) at org.jboss.tools.vpe.editor.dnd.context.VpeDragAnyCommand.doMove(JSPViewerDropAdapter.java:201) at org.jboss.tools.vpe.editor.dnd.context.VpeDragAnyCommand.executeHelper(JSPViewerDropAdapter.java:175) at org.jboss.tools.vpe.editor.dnd.context.xpl.DragNodeCommand2.execute(DragNodeCommand2.java:141) at org.eclipse.wst.common.ui.internal.dnd.ViewerDropAdapter.drop(ViewerDropAdapter.java:195) at org.jboss.tools.vpe.editor.dnd.context.JSPViewerDropAdapter.drop(JSPViewerDropAdapter.java:58) at org.jboss.tools.jst.jsp.outline.JSPContentOutlineConfiguration$1.drop(JSPContentOutlineConfiguration.java:114) at org.eclipse.jface.util.DelegatingDropAdapter$3.run(DelegatingDropAdapter.java:211) at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:37) at org.eclipse.core.runtime.Platform.run(Platform.java:880) at org.eclipse.ui.internal.JFaceUtil$1.run(JFaceUtil.java:48) at org.eclipse.jface.util.SafeRunnable.run(SafeRunnable.java:175) at org.eclipse.jface.util.DelegatingDropAdapter.drop(DelegatingDropAdapter.java:209) at org.eclipse.swt.dnd.DNDListener.handleEvent(DNDListener.java:90) at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84) at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1003) at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1027) at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1012) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java:770) at org.eclipse.swt.dnd.DropTarget.Drop(DropTarget.java:455) at org.eclipse.swt.dnd.DropTarget$3.method6(DropTarget.java:257) at org.eclipse.swt.internal.ole.win32.COMObject.callback6(COMObject.java:119) at org.eclipse.swt.internal.ole.win32.COM.DoDragDrop(Native Method) at org.eclipse.swt.dnd.DragSource.drag(DragSource.java:362) at org.eclipse.swt.dnd.DragSource.access$0(DragSource.java:288) at org.eclipse.swt.dnd.DragSource$1.handleEvent(DragSource.java:171) at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84) at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1003) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3823) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3422) at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2382) at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2346) at org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2198) at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:493) at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:288) at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:488) at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149) at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:113) at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:193) at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110) at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79) at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:386) at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:179) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:585) at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:549) at org.eclipse.equinox.launcher.Main.basicRun(Main.java:504) at org.eclipse.equinox.launcher.Main.run(Main.java:1236) at org.eclipse.equinox.launcher.Main.main(Main.java:1212) So it's a bug. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-4142?page=com.atlassian.jira.plu... ] Yahor Radtsevich reassigned JBIDE-4142: --------------------------------------- Assignee: Yahor Radtsevich (was: Maxim Areshkau) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-4142?page=com.atlassian.jira.plu... ] Yahor Radtsevich reassigned JBIDE-4142: --------------------------------------- Assignee: Alexey Kazakov (was: Yahor Radtsevich) Alexey, can you confirm that deleting (commenting) of org.jboss.tools.jst.jsp.outline.JSPContentOutlineConfiguration.getTransferDropTargetListeners(TreeViewer) will not break anything? I understand that this method is intended to give the VPE a way to handle DnD events. But firstly, this handing is not implemented in the VPE (see the implementation of VpeAbstractTemplate.innerDrop). Secondary, the VPE is working correct without this handling because in any case it handles source changing events. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-4142?page=com.atlassian.jira.plu... ] Viacheslav Kabanovich commented on JBIDE-4142: ---------------------------------------------- Yahor, please check following use-cases: You can dnd from Palette to Source, Visual and _Outline_. You can dnd a tld tag from Web Projects View (in Tag Libraries section) to Source, Visual and _Outline_. If these drops to Outline will work after deletion of this method, then probably it can be deleted. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-4142?page=com.atlassian.jira.plu... ] Yahor Radtsevich commented on JBIDE-4142: ----------------------------------------- Thank you, Viacheslav. I found that it is not enough just delete this method. These drops to the Outline View do not work after deletion of this method... -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-4142?page=com.atlassian.jira.plu... ] Yahor Radtsevich updated JBIDE-4142: ------------------------------------ Labels: new_and_noteworthy (was: ) IMO it was a major bug. The new_and_noteworthy label has applied. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira