[ https://issues.jboss.org/browse/JBIDE-12918?page=com.atlassian.jira.plugi... ] Jaroslav Jankovič updated JBIDE-12918: -------------------------------------- Steps to Reproduce: Bug is 100% reproducible with these steps: STEP: In #1 fresh workspace create simple java project with two simple archives in it STEP: Open #2 fresh workspace, add JBoss AS 7 server in it STEP: Import project from #1 workspace STEP: Deploy first archive into the server ASSERT: Archive is properly deployed STEP: Deploy second archive into the server FAIL: Archive is not deployed at all Note that this bug is not dependent on which tool is used for manipulation with archives (Project Archives explorer/view) was: Bug is 100% reproducible with these steps: STEP: In #1 fresh workspace create simple java project with two simple archives in it STEP: Open #2 fresh workspace, add JBoss AS 7 server in it STEP: Import project from #1 workspace STEP: Deploy first archive into the server ASSERT: Archive is properly deployed STEP: Deploy second archive into the server FAIL: Archive is not deployed at all -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-12918?page=com.atlassian.jira.plugi... ] Jaroslav Jankovič updated JBIDE-12918: -------------------------------------- Steps to Reproduce: Bug is 100% reproducible with these steps: STEP: In #1 fresh workspace create simple java project with two simple archives in it STEP: Open #2 fresh workspace, add JBoss AS 7 server in it STEP: Import project from #1 workspace STEP: Deploy first archive into the server ASSERT: Archive is properly deployed STEP: Deploy second archive into the server FAIL: Archive is not deployed at all Note that this bug is not dependent on which tool is used for manipulation with archives (Project Archives explorer/view) I've just found out that there is another workflow how to achieve a different bug (but I believe the same reason): STEP: In #1 fresh workspace create simple java project with two simple archives in it STEP: Open #2 fresh workspace, add JBoss AS 7 server in it STEP: Import project from #1 workspace STEP: Deploy first archive into the server ASSERT: Archive is properly deployed STEP: Remove archive from server STEP: Deploy second archive into the server FAIL: First archive is deployed into server, not second as it should was: Bug is 100% reproducible with these steps: STEP: In #1 fresh workspace create simple java project with two simple archives in it STEP: Open #2 fresh workspace, add JBoss AS 7 server in it STEP: Import project from #1 workspace STEP: Deploy first archive into the server ASSERT: Archive is properly deployed STEP: Deploy second archive into the server FAIL: Archive is not deployed at all Note that this bug is not dependent on which tool is used for manipulation with archives (Project Archives explorer/view) I've just found out that there is another workflow how to achieve a different bug (but I believe the same reason): STEP: In #1 fresh workspace create simple java project with two simple archives in it STEP: Open #2 fresh workspace, add JBoss AS 7 server in it STEP: Import project from #1 workspace STEP: Deploy first archive into the server ASSERT: Archive is properly deployed STEP: Remove archive from server STEP: Deploy second archive into the server FAIL: First archive is deployed into server, not second as it should be -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-12918?page=com.atlassian.jira.plugi... ] Denis Golovin commented on JBIDE-12918: --------------------------------------- Would be got to have project you use to replicate this problem attached to this issue. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-12918?page=com.atlassian.jira.plugi... ] Jaroslav Jankovič commented on JBIDE-12918: ------------------------------------------- Hi Denis, 1. answered in environment 2. jars are simple files in project, not added into classpath 3. answered in environment 4. Deploy the server means selecting archive (in archive explorer or archive view), invoking its context menu and click on "Publish To Server" 5. To remove the archive from server I used simple Del key when Server deployed content its expanded in servers view 6. no exceptions, no eclipse logs -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-12918?page=com.atlassian.jira.plugi... ] Jaroslav Jankovič updated JBIDE-12918: -------------------------------------- Attachment: pr3.zip Eclipse test project attached as zip file. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-12918?page=com.atlassian.jira.plugi... ] Jaroslav Jankovič updated JBIDE-12918: -------------------------------------- Attachment: JBIDE-12918.ogv Screencast attached -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-12918?page=com.atlassian.jira.plugi... ] Jaroslav Jankovič edited comment on JBIDE-12918 at 10/24/12 5:02 AM: --------------------------------------------------------------------- I don't think this issue has something with the case Finish button is enabled also if server is not selected. But thanks for discovering this incorrect behaviour. I logged Enhancement jira for that [JBIDE-12931|https://issues.jboss.org/browse/JBIDE-12931]) was (Author: jjankovi): I don't think this issue has something with the case Finish button is enabled also if server is not selected. But thanks for noting this behaviour. I logged Enhancement jira for that [JBIDE-12931|https://issues.jboss.org/browse/JBIDE-12931]) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-12918?page=com.atlassian.jira.plugi... ] Nick Boldt updated JBIDE-12918: ------------------------------- Fix Version/s: (was: 4.0.x) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-12918?page=com.atlassian.jira.plugi... ] Denis Golovin commented on JBIDE-12918: --------------------------------------- The problem is in .pakages file. In attached project it has the same {code}<property name="org.jboss.ide.eclipse.as.core.packages.ModuleIDPropertyKey" value="1350308437788"/>{code} for both archives. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-12918?page=com.atlassian.jira.plugi... ] Max Rydahl Andersen commented on JBIDE-12918: --------------------------------------------- was this created by copying verbatim or done by the UI ? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-12918?page=com.atlassian.jira.plugi... ] Rob Stryker commented on JBIDE-12918: ------------------------------------- jaroslav: Given the project you are providing, you are 100% that this is replicatable, but my question is, how did you get such a project? The code that generates these id's is as follows: {code} protected static String getStamp(IArchive pack, boolean create) { String propVal = pack.getProperty(MODULE_ID_PROPERTY_KEY); if( propVal == null && create ) { propVal = "" + new Date().getTime();//$NON-NLS-1$ } return propVal; } {code} The id is set to new Date().getTime(), which returns number of milliseconds since epoch. Even if this project was somehow generated programatically, it seems almost impossible that the id's would be the same. In fact, if I run this by hand, creating a java project, then adding one archive, then a second, I am unable to get duplicate id's. I even tried it programatically and cannot get duplicate id's. Is this project created before JBIDE-12813 was fixed? JBIDE-12813 was creating an error where projects were persisted with no id's at all. However I've even tested that. I've just modified the project you gave, and removed all such id's, and I still got different auto-generated id's upon the project import, differing by up to 10 ms. For example, if I import a project like: {code} <packages version="1.3"> <package exploded="false" inWorkspace="true" name="jp11a.jar" todir="outs" type="jar"> <properties/> </package> <package exploded="false" inWorkspace="true" name="jp11b.jar" todir="outs" type="jar"> <properties/> </package> </packages> {code} then after the import, the .packages file looks like this: {code} <packages version="1.3"> <package exploded="false" inWorkspace="true" name="jp11a.jar" todir="outs" type="jar"> <properties> <property name="org.jboss.ide.eclipse.as.core.packages.ModuleIDPropertyKey" value="1351665877040"/> </properties> </package> <package exploded="false" inWorkspace="true" name="jp11b.jar" todir="outs" type="jar"> <properties> <property name="org.jboss.ide.eclipse.as.core.packages.ModuleIDPropertyKey" value="1351665877050"/> </properties> </package> <properties/> </packages> {code} As you can see, the two id's are 1351665877040 and 1351665877050 in this case. So the real question here is, how did you get a single project that has two identical id's? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-12918?page=com.atlassian.jira.plugi... ] Denis Golovin commented on JBIDE-12918: --------------------------------------- {quote}So the real question here is, how did you get a single project that has two identical id's?{quote} Grab Intel i7 Quad Core 3.2GHz and try it. I got equal values for your scenario above. I cannot understand why do you need this ID if file names should be unique anyway? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-12918?page=com.atlassian.jira.plugi... ] Jaroslav Jankovič updated JBIDE-12918: -------------------------------------- Assignee: Rob Stryker (was: Jaroslav Jankovič) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-12918?page=com.atlassian.jira.plugi... ] Max Rydahl Andersen commented on JBIDE-12918: --------------------------------------------- The current mechanism obviously fails and there is no checks for duplicate id generation or setup within even the same file - that is broken! Why aren't the relative workspace location of the .archive folder + a truly unique field (i.e. the name or an id?) within this single file enough ? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-12918?page=com.atlassian.jira.plugi... ] Rob Stryker reassigned JBIDE-12918: ----------------------------------- Assignee: Denis Golovin (was: Rob Stryker) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-12918?page=com.atlassian.jira.plugi... ] Denis Golovin updated JBIDE-12918: ---------------------------------- Assignee: Rob Stryker (was: Denis Golovin) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-12918?page=com.atlassian.jira.plugi... ] Jaroslav Jankovič commented on JBIDE-12918: ------------------------------------------- Rob I have found out, why archive identifiers had the same value. Packages file from my original test project is: {code} <?xml version="1.0" encoding="UTF-8"?><packages version="1.3"> <package exploded="false" inWorkspace="true" name="pr3a.jar"> <properties/> </package> <package exploded="false" inWorkspace="true" name="pr3b.jar"> <properties/> </package> <properties/> </packages> {code} As you can see, there are no archive identifiers. So when importing such a project into workspace, these identifiers were generated with the same values because there were generated at the same time I guess. My question is: how can be generated such a project where there are no identifiers? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-12918?page=com.atlassian.jira.plugi... ] Jaroslav Jankovič closed JBIDE-12918. ------------------------------------- Verified in JBT 4.0.0.CR1-v20121125-0706-B9. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira