[ https://jira.jboss.org/jira/browse/JBIDE-5699?page=com.atlassian.jira.plu... ] Maxim Areshkau commented on JBIDE-5699: --------------------------------------- look like a rezult of JBIDE-5666. Denis, please deals with it. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-5699?page=com.atlassian.jira.plu... ] Victor Rubezhny commented on JBIDE-5699: ---------------------------------------- I guess that the reason is the modification of JSPMultiPageEditorPart related to JBIDE-5666: The base class was changed from EditorPart to MultiPageEditorPart, but the private implementation of some methods was not restored. For example, the setFocus() method was used to re-initialize the key bindings for the active editor - this functionality is lost now. I guess that this is the reason why the CA activation is broken within the editors. Some other methods were modified a bit (for example getActiveEditor() method may return null in some cases which may result in NullPointerException's). pageChange() method in MultiPageEditorPart contains significant modifications against the method was previously implemented, so it's hard to me to figure out what functionality will be broken because of this change. And so on. Probably we shall rollback the changes made for JBIDE-5666 and wait untill the 3.1.0 release? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-5699?page=com.atlassian.jira.plu... ] Denis Maliarevich commented on JBIDE-5699: ------------------------------------------ It appeared that our old JSPMultiPageEditorPart had more importance that I supposed. This class hasn't been changed for a long time therefore inheriting current MultiPageEditorPart cause some problems with logic. Up-to-date MultiPageEditorPart has significant changes in API and we need to update our JBDS to fit it. It turned out that simple inheriting isn't enough. As a solution we can try the following: 1) leave JSPMultiPageEditorPart as it but update some methods from the fresh eclipse's MultiPageEditorPart. JBDS will work properly without any changes to the whole model. 2) use the standard eclipse's MultiPageEditorPart and update our classes to interact correctly with it. This will entain more work on our side. All of it is the point for other issues I think. After the release. For now this blocker could be closed I suppose. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-5699?page=com.atlassian.jira.plu... ] Maxim Areshkau commented on JBIDE-5699: --------------------------------------- Verified, CA works now. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira