[ https://jira.jboss.org/jira/browse/JBIDE-5983?page=com.atlassian.jira.plu... ] Brian Fitzpatrick commented on JBIDE-5983: ------------------------------------------ There are a bunch of odds-n-ends from the previous incarnation of the Smooks editor (prior to what we did for JBT 3.1) left in the Smooks codebase that should be cleaned up as dead ends or old, unused code. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-5983?page=com.atlassian.jira.plu... ] Brian Fitzpatrick reassigned JBIDE-5983: ---------------------------------------- Assignee: Tom Fennelly (was: Xue Peng) Tom, can you look at this for Dart? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-5983?page=com.atlassian.jira.plu... ] Tom Fennelly commented on JBIDE-5983: ------------------------------------- Dart... can you recreate the patch file please. Seems to be something out of sync with the repo. When I try to apply the patch, it tries to patch src/org/jboss/tools/smooks/configuration/editors/csv12/CSVDataParser.java, which doesn't exist locally or in the repo. What does exist however is src/org/jboss/tools/smooks/configuration/editors/csv/CSVDataParser.java. So looks like the csv/csv12 packages are out of whack. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-5983?page=com.atlassian.jira.plu... ] Tom Fennelly commented on JBIDE-5983: ------------------------------------- Okay Dart... I committed that patch to trunk (rev 21173). Nice work... I see lots of stuff has been removed :) I still see the following code in the ui plugin: - calc - dbrouting - filerouting - groovy - input (not sure what this one is) - jms12 - persistence12 - rule10 - validation10 - xsl To the best of my knowledge, we're not using the code in these packages, right? If so, can we get rid of these too? The code is not lost (is always there in SVN history if we need it again), so if we need any of it we can always get it back. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-5983?page=com.atlassian.jira.plu... ] Brian Fitzpatrick commented on JBIDE-5983: ------------------------------------------ Tom, I sent you this via IM, but I think it might be good for Dart as well... Here's a good tool to use in Eclipse to look for unused code - http://www.ucdetector.org/. I heard about it at the conference and am going to take a look at it eventually. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-5983?page=com.atlassian.jira.plu... ] Tom Fennelly commented on JBIDE-5983: ------------------------------------- Dart... after verifying what I did... can we continue to remove all code that is not in use... even if we think it might be used down the line. Lets try get a cleaner slate here!! -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBIDE-5983?page=com.atlassian.jira.plugin.s... ] Tom Fennelly resolved JBIDE-5983. --------------------------------- Resolution: Won't Fix This will be done as part of the model refactoring work taking place on the smooks-dmb branch. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira