[ https://issues.jboss.org/browse/JBIDE-11831?page=com.atlassian.jira.plugi... ] Max Rydahl Andersen updated JBIDE-11831: ---------------------------------------- Fix Version/s: 3.3.0.CR1 (was: 3.3.0.Beta3) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-11831?page=com.atlassian.jira.plugi... ] Martin Malina commented on JBIDE-11831: --------------------------------------- Our tooling uses the shutdown command and this returns a value - 0 on success and 1 otherwise. We should be able to use that. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-11831?page=com.atlassian.jira.plugi... ] Martin Malina commented on JBIDE-11831: --------------------------------------- I don't know how you call the command but there should be some return value, no? For example if I run a command using "ssh user@host command", the ssh command returns the exit code of the command or 255 if an error occurred while processing request via ssh session. But I don't know how you call this command in the code. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-11831?page=com.atlassian.jira.plugi... ] Max Rydahl Andersen updated JBIDE-11831: ---------------------------------------- Assignee: Max Rydahl Andersen (was: Rob Stryker) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-11831?page=com.atlassian.jira.plugi... ] Max Rydahl Andersen commented on JBIDE-11831: --------------------------------------------- comments for clarification: Can singleUseShell now be null or is that just an extra guard added now ? What happens if server can't be stopped - it stays in running state ? what if I stop the server manually, won't it return failure to stop and then still be in running state even though now it is for sure not running ? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-11831?page=com.atlassian.jira.plugi... ] Rob Stryker updated JBIDE-11831: -------------------------------- Attachment: 305306.v3.patch Additions from this patch are the following: 1) a force stop in rse still somehow fell into the graceful stop due to a lack of 'return' 2) Added a synchronous one-time poll before sending the remote stop command over the wire. This way if the server is already stopped, we'll find out. 3) Moved a method to a util class (the one-time synchronous poll check) 4) The poll thread was never actually canceled if the shutdown command fails. This lead to issues with pollers sticking around polling. 5) A possible race condition, where the stop command is sent, but the return value takes a while to come back. If the poller recognized the server was stopped at the time, and set server to stopped, the non-zero return value indicating a failed shutdown then set it to started. This of course should not happen. In short, I feel the new patch is much more robust, cleans up where appropriate, takes more care in all situations, and should be accepted. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-11831?page=com.atlassian.jira.plugi... ] Rob Stryker commented on JBIDE-11831: ------------------------------------- As #2 says, at the initiation of a stop() command, we do a one-time poll, before launching an appropriate poll thread, to just verify if the server is up or down once. If the actual server is down, we simply set the server to stopped without sending any remote command. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-11831?page=com.atlassian.jira.plugi... ] Rob Stryker resolved JBIDE-11831. --------------------------------- Resolution: Done committed to cr1 and trunk.... changed pollthread.cancel() to add a null check. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira