[ http://jira.jboss.com/jira/browse/JBIDE-644?page=comments#action_12371958 ] Denis Golovin commented on JBIDE-644: ------------------------------------- New content type with content describer should be used for it. There is two strategies for it: 1. One content type for all xml files that can be edited in RH Xml Editor and one content describer with several parameters each declare DTD or schema. Content describer will check opened xml for DTD and Schemas defined in parameters. 2. Every known xml should have its content type first, then RH Xml Editor is binded to it. XMLRootElementContentDescriber can be used as example to fix xml editor problem. Slava what do you think? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBIDE-644?page=comments#action_12371966 ] Max Andersen commented on JBIDE-644: ------------------------------------ +1 lets register every specific file we know how to handle and don't bind to all .xml files. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBIDE-644?page=comments#action_12371978 ] Viacheslav Kabanovich commented on JBIDE-644: --------------------------------------------- But I think we can do nothing to binding WTP Faces Config editor. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBIDE-644?page=comments#action_12372083 ] Denis Golovin commented on JBIDE-644: ------------------------------------- I have problems in trying to solve this bug. If in extension 'org.eclipse.ui.editors' attribute 'extension' or 'filenames' is set, then editor is always added to 'Open With...' menu for files matching these values, no matter what contentTypeBinding elements say. On the other hand, if attributes 'extension' and 'filenames' are not set, than content of 'Open With...' menu depends on what content type is computed by Eclipse. And we cannot always secure that our content type will be returned by IDE.getContentType(file). For example, for web.xml it returns org.eclipse.jst.j2ee.webDD; and for faces-config.xml it returns org.eclipse.jst.jsf.facesconfig.facesConfigFile. If our content type has as base-type org.eclipse.core.runtime.xml than other content types ignore it and our editor is not included into 'Open With...' menu! I cannot see other solution than to add to editor declaration contentTypeBinding elements for possible content types. I tried that for content types listed above, and it works, but I think it is not a nice solution. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBIDE-644?page=comments#action_12372200 ] Viacheslav Kabanovich commented on JBIDE-644: --------------------------------------------- If customer adds some third-party plugins with specific editor declaring one more specific type for, e.g. web.xml, then Eclipse can use it and our editor will not be let into 'Open With...' menu. As it is now, our xml editor is bound with xml extension that guarantees its presence. The question is what is a bigger evil? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBIDE-644?page=comments#action_12372205 ] Max Andersen commented on JBIDE-644: ------------------------------------ Note: It is not the open with menu i'm too concerned about it is the fact that our generic editor overrules the more specific ones. wtp faces-config.xml editor seem to mange to be in the open with menu for .xml without being installed as the default editor. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira