]
Max Rydahl Andersen commented on JBIDE-18397:
---------------------------------------------
sure you can add an empty profile but it should never be knowingly wrong (which if you
have null for outputdirectory it iwill be).
I assume you mean we should ask the user that we could *not* determine the output folder ?
That depends - afaik this would be the case for 90% of the application types ? Then I
would have it it in the main flow so not showing up as dialog constantly.
For CR2 I would just start by ensuring we dont generate something we know is broken.
Application wizard: openshift maven profile for WildFly cartridge
generates <outputDirectory>null</outputDirectory>
-------------------------------------------------------------------------------------------------------------------
Key: JBIDE-18397
URL:
https://issues.jboss.org/browse/JBIDE-18397
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: openshift
Affects Versions: 4.2.0.CR1
Reporter: Fred Bricon
Assignee: Andre Dietisheim
Priority: Critical
Labels: application_wizard
Fix For: 4.2.0.CR2, 4.3.x
- Create a new maven war project testapp
- Add custom index.html
- Create new openshift application with WildFly 8.1 quickstart
- deploy testapp on openshift
- ASSERT your changes are published online
-> FAIL the default Wildfly 8 cartridge app is shown
This is caused by openshift tooling generating an invalid outputDirectory value (null)
instead of the expected one (deployments)
{noformat}<profile>
<!-- When built in OpenShift the openshift profile will be used when invoking mvn.
-->
<!-- Use this profile for any OpenShift specific customization your app will need.
-->
<!-- By default that is to put the resulting archive into the deployments folder.
-->
<!--
http://maven.apache.org/guides/mini/guide-building-for-different-environm... -->
<id>openshift</id>
<build>
<finalName>testapp</finalName>
<plugins>
<plugin>
<artifactId>maven-war-plugin</artifactId>
<version>2.4</version>
<configuration>
<outputDirectory>null</outputDirectory>
<warName>ROOT</warName>
</configuration>
</plugin>
</plugins>
</build>
</profile>
{noformat}