[ https://jira.jboss.org/browse/JBIDE-7361?page=com.atlassian.jira.plugin.s... ] Alexey Kazakov updated JBIDE-7361: ---------------------------------- Assignee: Victor Rubezhny (was: Alexey Kazakov) Fix Version/s: 3.2.0.Beta2 Affects Version/s: 3.2.0.Beta1 (was: LATER) Viktor, "Open Seam Component" button should be showed only in Seam perspective. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBIDE-7361?page=com.atlassian.jira.plugin.s... ] Victor Rubezhny updated JBIDE-7361: ----------------------------------- Fix Version/s: LATER (was: 3.2.0.Beta2) Component/s: UpStream -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-7361?page=com.atlassian.jira.plugin... ] Victor Rubezhny commented on JBIDE-7361: ---------------------------------------- Do we need to completely hide "Open Seam Component" toolbar button as well as "Navigate->Open Seam Component", "Search->Find Seam References" and "Search->Find Seam Declarations" menu items from all the perspectives others than "Seam" perspective? I mean if I'll do this trick, the listed button and menu items will not be available to be shown on perspectives other than "Seam" perspective. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-7361?page=com.atlassian.jira.plugin... ] Victor Rubezhny commented on JBIDE-7361: ---------------------------------------- I mean the trick with "visible when" and actionSet definition which were provided by you for runBrowserSim command in issue JBIDE-10417. Without this trick we cannot show "Open Seam Component" toolbar button only in Seam Perspective (and not to show for other perspectives). But we can hide it for each perspective using "RClick->Customize Perspective" Toolbar context menu. (We can't hide it by default for all the perspectives other than Seam, but a user can hide it later at run time.) Using an action set defined for perspective to define visibility of the toolbar button (to make it visible only in Seam perspective) prevents us from a possibility to make it visible on other perspective using "RClick->Customize Perspective" Toolbar context menu (the command will be listed there only for Seam perspective). Do not understand question about Java contributions... Java toolbar/menu items are always visible, but their visibility could be edited by "RClick->Customize Perspective" Toolbar context menu. But have an opposite case for Seam-related stuff: we need to hide it from toolbars/menues when non-Seam perspective is active. And if we're hiding it by default (for non-Seam perspectives) - there is no way for a user to make them visible again (the only way is to activate Seam perspective). Is that we want? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-7361?page=com.atlassian.jira.plugin... ] Max Rydahl Andersen commented on JBIDE-7361: -------------------------------------------- The java contribution "Open Type..." is not shown in unrelated perspectives. The requirement is not that Open Seam... is only visible when Seam perspective is there - it is that the only place we should enable it by default is in Seam Perspective, only if users ask for it should it be shown. Similar to what "Open Type..." is. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-7361?page=com.atlassian.jira.plugin... ] Victor Rubezhny commented on JBIDE-7361: ---------------------------------------- Max, "Open Type... " command/toolbar button/ Navigate Menu item is always enabled (at least I couldn't find a perspective where this button/menu item is hidden). This is not a Command, but action in Action Set associated with many Action Set Parts (all are defined in JDT UI) like Compilation Unit Editor, Package Explorer and even Poperties File Editor. So, this button/menu item is almost always visible and enabled (unless it is configured to be hidden in Customize Perspective Dialog). But... If I: 1) open Java perspective 2) then disable visibility of Open Type action in Customize Perspective Dialog 3) then switch to Resource Perspective (Not Debug perspective, 'cause it seems that it defines its own instance of the same action) Then I couldn't enable Open Type action (make it visible) because - See CannotEnableOpenType.png screenshot. So, all I can improve is, probably, associate "org.jboss.tools.seam.ui.actionSet" (which is used to hide/show "Open Seam Component" command's toolbar button/menu items) with more UI Parts like Visual Page Editor, JBoss Perspective etc. But in this case it (Open Seam Component toolbar button/menu item) will be enabled and visible by default if any of such part is activated (even if Seam Perspective is not opened). WDYT? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-7361?page=com.atlassian.jira.plugin... ] Max Rydahl Andersen commented on JBIDE-7361: -------------------------------------------- Open Type is not visible when I open Git perspective. I haven't used "selective enablement" at view/editor level - how is that done ? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-7361?page=com.atlassian.jira.plugin... ] Victor Rubezhny edited comment on JBIDE-7361 at 12/22/11 4:18 PM: ------------------------------------------------------------------ I'm sorry Max. It works and could be made visible on any perspective. Due to enable Open Seam Component handler in Toolbar/Menu you have to enable "Seam UI" command group first and then you'll be able to enable the command itself. It confused me because it required me to close "Customize Perspective..." dialog by pressing "OK" button before "Open Seam Component" has become able to be enabled. So, the enablement on perspectives 'others than Seam perspective' works. On "selective enablement"... If I understand your question right: The "Open Type" in JDT is enabled when "org.eclipse.jdt.ui.JavaActionSet" is enabled. "org.eclipse.jdt.ui.JavaActionSet" in its turn has Part Association defined as follows: {code} <extension point="org.eclipse.ui.actionSetPartAssociations"> <actionSetPartAssociation targetID="org.eclipse.jdt.ui.JavaActionSet"> <part id="org.eclipse.jdt.ui.PackageExplorer"> </part> <part id="org.eclipse.jdt.ui.TypeHierarchy"> </part> <part id="org.eclipse.jdt.ui.CompilationUnitEditor"> </part> <part id="org.eclipse.jdt.ui.ClassFileEditor"> </part> <part id="org.eclipse.jdt.ui.PropertiesFileEditor"> </part> <part id="org.eclipse.jdt.ui.ProjectsView"> </part> <part id="org.eclipse.jdt.ui.PackagesView"> </part> <part id="org.eclipse.jdt.ui.TypesView"> </part> <part id="org.eclipse.jdt.ui.MembersView"> </part> <part id="org.eclipse.jdt.ui.SourceView"> </part> <part id="org.eclipse.jdt.callhierarchy.view"> </part> </actionSetPartAssociation> </extension> {code} And it is enabled if any of these parts is active. So, "Open Type" action will be visible in toolbar if any of associated View/Editor Parts is active. was (Author: vrubezhny): "Open Type is not visible when I open Git perspective." --- And?.. Can you make it visible by "Customize Perspective" dialog? (Right-click on toolbar and select "Customize Perspective" in pop-up menu, then find "Open Type" action and (if found, it should be grayed as "not enabled") try to check it to enable.) On "selective enablement"... If I understand your question right: The "Open Type" in JDT is enabled when "org.eclipse.jdt.ui.JavaActionSet" is enabled. "org.eclipse.jdt.ui.JavaActionSet" in its turn has Part Association defined as follows: {code} <extension point="org.eclipse.ui.actionSetPartAssociations"> <actionSetPartAssociation targetID="org.eclipse.jdt.ui.JavaActionSet"> <part id="org.eclipse.jdt.ui.PackageExplorer"> </part> <part id="org.eclipse.jdt.ui.TypeHierarchy"> </part> <part id="org.eclipse.jdt.ui.CompilationUnitEditor"> </part> <part id="org.eclipse.jdt.ui.ClassFileEditor"> </part> <part id="org.eclipse.jdt.ui.PropertiesFileEditor"> </part> <part id="org.eclipse.jdt.ui.ProjectsView"> </part> <part id="org.eclipse.jdt.ui.PackagesView"> </part> <part id="org.eclipse.jdt.ui.TypesView"> </part> <part id="org.eclipse.jdt.ui.MembersView"> </part> <part id="org.eclipse.jdt.ui.SourceView"> </part> <part id="org.eclipse.jdt.callhierarchy.view"> </part> </actionSetPartAssociation> </extension> {code} And it is enabled if any of these parts is active. So, "Open Type" action will be visible in toolbar if any of associated View/Editor Parts is active. So, we can make something like this for "Open Seam Component", but associations will be different. But this means that if any of associated part will be active then "Open Seam Component" button vill be visible and enabled in toolbar, otherwise it will be hidden and disabled (and cannot be enabled thru "Customize Perspective" dialog). Don't know other ways to do enablement for toolbar/menu items. There is method when handler is responsible to calculate its visibility (by specifying <visibleWhen checkEnabled="true" />). But in this case I don't know also how it can be made "invisible by default, but able to be made visible by "Customise Perspective". -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-7361?page=com.atlassian.jira.plugin... ] Victor Rubezhny commented on JBIDE-7361: ---------------------------------------- Now, the Seam-toolbar action is visible as grayed (disabled) in "Customize Perspective..." dialog for any perspective (unless it's not the Seam one. For Seam-perspective it's enabled). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-7361?page=com.atlassian.jira.plugin... ] Martin Malina closed JBIDE-7361. -------------------------------- I verified the behavior for Seam perspective and other perspectives, but not Teiid since we don't have a soa build. But with how it works now I am confident the issue with Teiid menu bar is gone, too. (jbosstools-3.3_stable_branch.aggregate-Update-2012-02-24_23-15-15-H93.zip) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira