[
https://issues.jboss.org/browse/JBIDE-13821?page=com.atlassian.jira.plugi...
]
Nick Boldt commented on JBIDE-13821:
------------------------------------
To answer your question (asked in
https://github.com/jbosstools/jbosstools-build/pull/77
):
"I don't understand why anyone would need to set/override this property from
external scripts. which usecase is that since there are only one tpc.version to set
?"
The value of the property is passed from Jenkins to
jbosstools-build-sites/aggregate/build.xml via two poms (for the JBT core agg site and the
webtools agg site poms) so that we can generate pretty HTML pages reporting on what was
used to produce the build.
publish.sh also receives these Jenkins properties so that this information can be captured
in log files and fed back to the Jenkins view, via the Build Description configuration in
the jobs.
Because -Pmaximum is a shorthand way of setting the selected TP version to the default
maximum, and we would rather explicitly state the version when building via Jenkins (so
that as above we can capture the information in results.html, logs, and Build
Description), I've removed it from the 4.1/7.0/master/trunk jobs. I've left it in
the 4.0/6.0 jobs because I can't be arsed and because less changes in maintenance
branch are better than more. As you say, it's better to change less there so as to
ensure builds are more reproducible.
----
As to the statement above that "the old property has zero effect", that's
NOW true, but yesterday was false because these files depended on it:
https://svn.jboss.org/repos/devstudio/trunk/hudson-jobs/cache/https/jenki...
https://svn.jboss.org/repos/devstudio/trunk/hudson-jobs/cache/https/jenki...
https://github.com/jbosstools/jbosstools-build-sites/tree/master/aggregate (pom.xml files
and build.xml, indirectly)
Before stating that something is not used, you might want to grep through the code looking
for references.
Anyway, I can now remove TARGET_PLATFORM_VERSION-maximum from the parent pom in favour of
TARGET_PLATFORM_VERSION_MAXIMUM. I'll leave it in the 40x branch, since it doesn't
hurt anything and again, less change there is good.
I will remove it from master as part of thhe further cleanup effort in JBIDE-13452.
CI runs tests against minimum instead of maximum
------------------------------------------------
Key: JBIDE-13821
URL:
https://issues.jboss.org/browse/JBIDE-13821
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: Build/Releng
Affects Versions: 4.0.x, 4.1.0.Alpha2
Reporter: Mickael Istria
Assignee: Nick Boldt
Priority: Critical
Fix For: 4.0.1.Final, 4.1.0.Alpha2
As Maven executions set a value for the TARGET_PLATFORM_VERSION value, this property is
not overriden by the maximum profile.
Maven order to set properties is
# look a -D... to set property, if not found
# look at active profiles to set property, if not found
# look at default value of property to set it
This makes that in mvn execution for tests, the TARGET_PLATFORM_VERSION is set to minimal
is CI jobs, whereas with using the -Pmaximun profile, we expect maximum.
This is a critical issue since it caused hours of confusions to debug on 4.0.x branch.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:
http://www.atlassian.com/software/jira