[
https://jira.jboss.org/jira/browse/JBIDE-4417?page=com.atlassian.jira.plu...
]
Vitali Yemialyanchyk commented on JBIDE-4417:
---------------------------------------------
I'm trying to review the code with the current thread classloader - I didn't see
something wrong here.
Of course there are possible enhancements here - Ejb3Configuration changes was mentioned,
but conceptually I didn't see errors here.
Moreover, it is seems OpenMappingUtils->searchInMappingFiles (it uses Eclipse mechanism
directly to find mapping file) has conceptual errors.
My point of view Hibernate Console Configuration has all information about mappings (not
Eclipse project!),
Hibernate Console Configuration could exist without Eclipse project at all.
In generall case, we could have rather complex combinations of Eclipse projects,
Configuration files and Hibernate Console Configuration,
of course we have classpath and we could locate hibernate mapping files in there,
but in general it seems like something wrong here - cause Hibernate Console Configuration
based on compiled result (in bin folder - like example), so the right way (as I imagine
it) - get paths to config files from Hibernate Console Configuration and
only then we could try to collate Hibernate Console Configuration paths to current Eclipse
workspace paths.
Is it possible situation when there is only Hibernate Console Configuration in the current
workspace? (no prjects)
Is it be correct to open right mapping here?
Scanning jars and using eclipses classloader is not good to do in
OpenMappingFileUtilEjb3
-----------------------------------------------------------------------------------------
Key: JBIDE-4417
URL:
https://jira.jboss.org/jira/browse/JBIDE-4417
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: Hibernate
Affects Versions: 3.1.0.M1
Reporter: Max Rydahl Andersen
Assignee: Vitali Yemialyanchyk
Fix For: 3.1.0.M2
Why are we using the current thread classloader (eclipses classloader) and jarvisitor to
load resources when Eclipse already got all this info ?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira