[ http://jira.jboss.com/jira/browse/JBIDE-1433?page=all ] Denis Golovin updated JBIDE-1433: --------------------------------- Attachment: tld import on JBoss Palette.jpg The same problem with tld import on JBoss Palette. I cannot see what is behind taglib.tld item in tree -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBIDE-1433?page=all ] Max Andersen updated JBIDE-1433: -------------------------------- Fix Version/s: 2.1 -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBIDE-1433?page=all ] Denis Golovin reassigned JBIDE-1433: ------------------------------------ Assignee: Viacheslav Kabanovich -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBIDE-1433?page=comments#action_12400869 ] Viacheslav Kabanovich commented on JBIDE-1433: ---------------------------------------------- Format for extension improved: 1) Variable has got description (as for CVS decorator dariables) 2) Object examples added for preview on the preference page. Now example extension looks as: <extension point="org.jboss.tools.common.model.ui.labelDecorator"> <labelDecorator entities="FileTLD_PRO,FileTLD_1_2,FileTLD_2_0,FileTLD_2_1" name="File TLD" partition="Tag Libraries" defaultValue="{name} [{shortname}]"> <variable name="shortname" description="attribute of taglib node"/> <variable name="uri" description="attribute of taglib node"/> <variable name="display-name" description="attribute of taglib node"/> <example entity="FileTLD_1_2"> <put name="name" value="taglib"/> <put name="shortname" value="c"/> <put name="uri" value="http://java.sun.com/jstl/core"/> <put name="display-name" value="JSTL Core"/> </example> </labelDecorator> </extension> -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBIDE-1433?page=comments#action_12401126 ] Max Andersen commented on JBIDE-1433: ------------------------------------- if we are going to do extension points for this why not use standard eclipse 3.3 functionallity like <enablements> ? And shouldn't this be an *internal* extension point ? ....and this extension points feels *very* detailed and like programming in xml....again what is all this extra information used for ? A screenshot could help me at least :) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBIDE-1433?page=all ] Viacheslav Kabanovich updated JBIDE-1433: ----------------------------------------- Attachment: Label Decorations preference page.jpg -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBIDE-1433?page=comments#action_12401210 ] Viacheslav Kabanovich commented on JBIDE-1433: ---------------------------------------------- Label Decorations preference page.jpg Our contribution to navigator contains objects implementing XModelObject interface, which are finely adjusted with meta data. This provides for an easy way to let users of Studio to customize presentation of objects in navigators. Usually, to build label text, we use the value of object attribute that identifies it in the best way, and restrain from encumbering the label with values of other attributes. But other object attributes may be quite useful in customizing the label, just user needs an instrument to help him adjust it as he likes. Presentation of taglib node is a good example, but I think it is not the only case where customizing label may be needed. We have trees for tld, web.xml, faces-config, tiles, seam components, struts-config, hibernate, etc. As just one more case, many xml nodes have attribute 'display-name', and while we cannot rely upon it in building label text, as most often it is left empty; some users who painstakingly fill presentation-like attributes might wish to see them it tree instead of 'name'. I had seen two ways to implement this functionality: either add some new sections to internal *.meta files, or do it in the open Eclipse-style way that would depend on internal meta minimally. I did not mean to create some obscure xml language, but included to extension point definition what seemed necessary. 1) partition. Preference page contains tree with customizable decorations, the first level is partition to group together decorations for objects used in the same kind of file (seems most natural grouping principal to me); the second level - contains object decorations. 2) name. Just name of decoration to be shown in preference page. 3) entities The point of connection to meta data, - we need to list names of objects declared in meta data for which this decoration is relevant. 4) defaultValue The default value of the format to be used to build object label. For TLD file object, it looks like a good solution to addby default 'shortname' attribute to the file name. 5) <variable> As in CVS and SVN preferences pages for text decoration, there is a trivial formatting language "text1{var1}text2{var2}" We need to specify variables and define how they work. In CVS, the variety of objects is rather limited and they can be satisfied with several common variables. In our case, set of variables depends on object, of which we have a lot. Like in CVS, I decided that variable needs name and description. User does not need to remember variables that can be used to decorate text presentation, so 'Add Variable...' command is used. (see Select Variable for formatting label.jpg) 6) <example> Is not it good for a user to see immediately the result of his modifications to the format of a selected object decoration. Here, we have to provide a test object populated with values of attributes used as variables. That is all about the xml structure. About enablement. I have thought about making tree with decorations check-box tree with check boxes for enabling/disabling each separate rule or entire partition. I postponed that because now implemented decorations do not do anything especial by default, and algorithm for applying them is quite fast. About making this extension point *internal*. It can be internal, but also we can make it public by providing in docs information of object entities and their attributes, that is by opening as needed interface to our internal model. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBIDE-1433?page=all ] Max Andersen resolved JBIDE-1433. --------------------------------- Resolution: Done Closing since it works, but this extension point really should be internal. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira