[ https://issues.jboss.org/browse/JBIDE-11567?page=com.atlassian.jira.plugi... ] Lucia Jelinkova commented on JBIDE-11567: ----------------------------------------- I don't like changing UI because of tests either but the programmatic approach should not be used in UI testing. The tests need to cover the behaviour after clicking the button including the search for runtimes. Let's not think of my request as changing the UI for tests but rather than unifying the behaviour of Add and Edit buttons. As I've written before, Edit dialog contains the possibility to set the path into the text field that can be easily performed by SWTBot. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-11567?page=com.atlassian.jira.plugi... ] Lucia Jelinkova commented on JBIDE-11567: ----------------------------------------- I understand I can solve this using programmatic solution or by combining Edit & Search buttons. But these UI tests will not guarantee that clicking Add button actually works or does not throw any exception. I'd like to have the opportunity to test the Add button because apart from adding the path there is also performed automatic runtime search. I have no intention in testing native dialogs. Dialogs displayed after clicking Add and Edit buttons are not the same. After clicking Add button the file selection dialog is open but when you click Edit button a different dialog is open. I suggest to display the same dialog in both cases (the one that is displayed after clicking the Edit button). I don't like the idea of merging Add and Edit buttons into one. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-11567?page=com.atlassian.jira.plugi... ] Lucia Jelinkova commented on JBIDE-11567: ----------------------------------------- But when the Browse button triggers search and the change of the value in text field does not, I would consider that as a bug. Those two should trigger the same actions. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-11567?page=com.atlassian.jira.plugi... ] Snjezana Peco edited comment on JBIDE-11567 at 4/22/12 8:31 AM: ---------------------------------------------------------------- {quote} But when the Browse button triggers search and the change of the value in text field does not, I would consider that as a bug. Those two should trigger the same actions. {quote} The change of the value doesn't trigger search intentionally. The JBoss Tools can contain a lot of runtime detectors (currently four) which, mainly, search a file system and take a long time. We wouldn't like the UI to become unresponsive or that we have to start the progress dialog when a user enters a key. That is the reason why the Refresh button has been added. was (Author: snjeza): {quote} But when the Browse button triggers search and the change of the value in text field does not, I would consider that as a bug. Those two should trigger the same actions. {quote} The change of the value doesn't triger search intentinally. The JBoss Tools can contain a lot of runtime detectors (currently four) which, mainly, search a file system and take a long time. We wouldn't like the UI to become unresponsive or that we have to start the progress dialog when a user enters a key. That is the reason why the Refresh button has been added. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-11567?page=com.atlassian.jira.plugi... ] Snjezana Peco resolved JBIDE-11567. ----------------------------------- Resolution: Rejected Len, I'm not sure what "old behavior" you are talking about. The Runtime UI has been made according to Max's mockup attached in JBIDE-7527. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-11567?page=com.atlassian.jira.plugi... ] Snjezana Peco commented on JBIDE-11567: --------------------------------------- The only change that was made in the UI in the last year was adding the Download button. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira