[ http://jira.jboss.com/jira/browse/JBIDE-2121?page=all ] Anton Klimkovich updated JBIDE-2121: ------------------------------------ Attachment: Ctrl+G.PNG NavigateMenu.PNG -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBIDE-2121?page=comments#action_12410283 ] Anton Klimkovich commented on JBIDE-2121: ----------------------------------------- Sorry, but when I look at Navigate menu(Navigate.png) and see Hot keys for actions I expect that the search result will be equal irrespective from how this actions were called. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBIDE-2121?page=comments#action_12410289 ] Max Rydahl Andersen commented on JBIDE-2121: -------------------------------------------- I agree with Anton....the short cuts are wrong here for Seam Find ref/decl. It is also not right that they are under Navigate...they should be under Search if anything. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBIDE-2121?page=comments#action_12410328 ] Victor Rubezhny commented on JBIDE-2121: ---------------------------------------- OK. So, the solution may be the following: Save the key combinations for the "Find Seam..." actions and... - Move the actions to the Search menu. - Hide/Disable the "Find Seam...." actions invokation by the hot-keys if the Java-editor is activated - Or - Change the key combinations for the "Find Seam..." actions and... - Move the actions to the Search menu. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBIDE-2121?page=comments#action_12410340 ] Victor Rubezhny commented on JBIDE-2121: ---------------------------------------- "Find Seam..." actions are relevant for any Seam EL-s in any editors. The problems are: - Key combination conflict in the Java Editor (but "Find Seam..." actions are to work for Seam EL in Java strings as well) - There is no common way to separate Seam EL tokens from all the other words in editor, so "Find Seam..." action will try to interpret any text under the cursor as Seam EL token. (for compare the Java Search will try to interpret any word under the cursor as IJavaElement. If it can't find a IJavaElement by the name (a word under the cursor) it fails and shows an error message like "The operation is unavailable on the current selection. Prease select a valid Java element name". We aren't showing such messages for "Find Seam..." actions) -It may be a problem to assign/deassign the hot-key combination dynamically depending on the editor activated. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBIDE-2121?page=comments#action_12410371 ] Victor Rubezhny commented on JBIDE-2121: ---------------------------------------- The "Find Seam..." action and the one that is used via Ctrl+1 are the same. Not a command (Command isn't used when you invoke it via Ctrl+1). The "Find Seam..." actions are linked (via its definitionId attribute) to the the commands which defined for the Java Editor (Find ... in workspace) - that's why the Java search actions are invoked in Java-editor, but not the "Find Seam..." actions. And this allows to invoke "Find Seam ..." actions for all the other editors. Snjezana did it for a certain editor (JSP/HTML Multipage Editor), but not for all the editors. We need "Find Seam..." actions to work for any editor. I can modify the JBoss editors, but I cannot modify the Java Editor. By the way the "Find Seam... " actions are to be enabled even the Java editor is activated. (Only hot-keys shoud invoke the Java Search actions but not the "Find Seam..." actions in this case. IMHO, what can be done is an additional checking for the type of the document (what editor is activated) and assigning/deassigning the hot keys for the "Find Seam... " actions depending on the check result. Probably, an Error Message Dialog is to be added as it's done for the Java Search actions to exclude non-Seam EL words from search (but it's not always possible to determine is the word under the cursor a Seam EL token). And off course, the "Find Seam..." actions should be moved to Search menu. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBIDE-2121?page=comments#action_12410376 ] Snjezana Peco commented on JBIDE-2121: -------------------------------------- You can add those actions to work for any text editor using the org.eclipse.ui.textEditorScope context. I intentionally made my actions work only in the VPE editor and created the new context: org.jboss.tools.vpe.editorContext An example of changing a context is in the VpeEditorPart$ActivationListener class. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBIDE-2121?page=comments#action_12410599 ] Snjezana Peco commented on JBIDE-2121: -------------------------------------- If you want a command to be executed in the WTP editors, you need to use the org.eclipse.wst.sse.ui.structuredTextEditorScope context. This context is active in all structured text editors. You don't have to define/activate/deactivate this context. I had to define a new context because splitter actions were supposed to work only in the VPE editor. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBIDE-2121?page=all ] Victor Rubezhny resolved JBIDE-2121. ------------------------------------ Resolution: Done -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBIDE-2121?page=comments#action_12410881 ] Victor Rubezhny commented on JBIDE-2121: ---------------------------------------- Max, It seems that "Design" Page is opened by default in your editor. It has no Structured Text selection and this results into disabling the "Find Seam..." actions. So, the "Find Seam..." actions are selection sensitive... I see this situation in my environment, but when I switch to the "Source" page the "Find Seam..." actions become enabled (because of active editor on the "Source" Tab has Sturctured Text selection). -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBIDE-2121?page=comments#action_12410915 ] Victor Rubezhny commented on JBIDE-2121: ---------------------------------------- I don't know about some differences between these files from Eclipse or JBDS editors point of view All works here on two workstations. The only one things is the selection: If you opened some editor and then select something in the Projects View Tree (for example) your editor will loose the focuse and the current selected Item will be the Tree item, but not the text selection. In this case the "Find Seam..." actions will be "grayed". But if you'll select the editor (doesn't matter how: by clicking to some position in the text or by clicking to the "Source" tab) the actions become enabled. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBIDE-2121?page=all ] Victor Rubezhny reopened JBIDE-2121: ------------------------------------ -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBIDE-2121?page=all ] Victor Rubezhny reopened JBIDE-2121: ------------------------------------ -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBIDE-2121?page=all ] Victor Rubezhny resolved JBIDE-2121. ------------------------------------ Resolution: Done -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBIDE-2121?page=all ] Max Rydahl Andersen resolved JBIDE-2121. ---------------------------------------- Fix Version/s: 2.1.1 (was: 2.1.x) (was: 2.1.0.GA) Resolution: Done -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBIDE-2121?page=all ] Anton Klimkovich closed JBIDE-2121. ----------------------------------- Verified on: (2.1.2) 200806192021-nightly and (3.0 alpha) 200806192047-nightly -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira