6:22 a.m.
Yahor Radtsevich created JBIDE-12948:
----------------------------------------
Summary: SelectionBar uses too much CPU resources
Key: JBIDE-12948
URL: https://issues.jboss.org/browse/JBIDE-12948
Project: Tools (JBoss Tools)
Issue Type: Sub-task
Components: Visual Page Editor core
Affects Versions: 4.0.0.Beta1
Reporter: Yahor Radtsevich
Assignee: Yahor Radtsevich
Fix For: 4.0.0.CR1
While profiling VPE JUnits it seems that up to 70% of all time of their execution is
performed in the method
org.jboss.tools.jst.jsp.selection.bar.SelectionBar.setVisible(boolean):
{code}
public void setVisible(boolean visible) {
if (visible) {
splitter.setVisible(realBar, true);
splitter.setVisible(emptyBar, false);
} else {
splitter.setVisible(realBar, false);
splitter.setVisible(emptyBar, true);
}
/* JBIDE-7387:
* By default toolbar size is set to fit regular button ToolItems.
* But drop-down items are a little bigger and do not
* fit in the default-size toolbars (at least under Windows XP).
* This temporary ToolItem is needed to set enough size to the toolbar.*/
ToolItem tempItem = new ToolItem(toolbar, SWT.DROP_DOWN);
tempItem.setText(" "); //$NON-NLS-1$
tempItem.setEnabled(false);
this.getParent().layout(true, true);
tempItem.dispose();
}
{code}
The call of {{this.getParent().layout(true, true);}} is very expensive.
I could suggest two fixes here:
# The panel should know if it is already visible or not. If the same state is requested,
the method should do nothing.
# [Optionally!] Calculate the height of the toolbar only once, and then just pass this
height to the layout manager.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:24 a.m.
[
https://issues.jboss.org/browse/JBIDE-12948?page=com.atlassian.jira.plugi...
]
Yahor Radtsevich reassigned JBIDE-12948:
----------------------------------------
Assignee: (was: Yahor Radtsevich)
SelectionBar uses too much CPU resources
----------------------------------------
Key: JBIDE-12948
URL: https://issues.jboss.org/browse/JBIDE-12948
Project: Tools (JBoss Tools)
Issue Type: Sub-task
Components: Visual Page Editor core
Affects Versions: 4.0.0.Beta1
Reporter: Yahor Radtsevich
Fix For: 4.0.0.CR1
While profiling VPE JUnits it seems that up to 70% of all time of their execution is
performed in the method
org.jboss.tools.jst.jsp.selection.bar.SelectionBar.setVisible(boolean):
{code}
public void setVisible(boolean visible) {
if (visible) {
splitter.setVisible(realBar, true);
splitter.setVisible(emptyBar, false);
} else {
splitter.setVisible(realBar, false);
splitter.setVisible(emptyBar, true);
}
/* JBIDE-7387:
* By default toolbar size is set to fit regular button ToolItems.
* But drop-down items are a little bigger and do not
* fit in the default-size toolbars (at least under Windows XP).
* This temporary ToolItem is needed to set enough size to the toolbar.*/
ToolItem tempItem = new ToolItem(toolbar, SWT.DROP_DOWN);
tempItem.setText(" "); //$NON-NLS-1$
tempItem.setEnabled(false);
this.getParent().layout(true, true);
tempItem.dispose();
}
{code}
The call of {{this.getParent().layout(true, true);}} is very expensive.
I could suggest two fixes here:
# The panel should know if it is already visible or not. If the same state is requested,
the method should do nothing.
# [Optionally!] Calculate the height of the toolbar only once, and then just pass this
height to the layout manager.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:24 a.m.
[
https://issues.jboss.org/browse/JBIDE-12948?page=com.atlassian.jira.plugi...
]
Yahor Radtsevich updated JBIDE-12948:
-------------------------------------
Assignee: Denis Maliarevich
SelectionBar uses too much CPU resources
----------------------------------------
Key: JBIDE-12948
URL: https://issues.jboss.org/browse/JBIDE-12948
Project: Tools (JBoss Tools)
Issue Type: Sub-task
Components: Visual Page Editor core
Affects Versions: 4.0.0.Beta1
Reporter: Yahor Radtsevich
Assignee: Denis Maliarevich
Fix For: 4.0.0.CR1
While profiling VPE JUnits it seems that up to 70% of all time of their execution is
performed in the method
org.jboss.tools.jst.jsp.selection.bar.SelectionBar.setVisible(boolean):
{code}
public void setVisible(boolean visible) {
if (visible) {
splitter.setVisible(realBar, true);
splitter.setVisible(emptyBar, false);
} else {
splitter.setVisible(realBar, false);
splitter.setVisible(emptyBar, true);
}
/* JBIDE-7387:
* By default toolbar size is set to fit regular button ToolItems.
* But drop-down items are a little bigger and do not
* fit in the default-size toolbars (at least under Windows XP).
* This temporary ToolItem is needed to set enough size to the toolbar.*/
ToolItem tempItem = new ToolItem(toolbar, SWT.DROP_DOWN);
tempItem.setText(" "); //$NON-NLS-1$
tempItem.setEnabled(false);
this.getParent().layout(true, true);
tempItem.dispose();
}
{code}
The call of {{this.getParent().layout(true, true);}} is very expensive.
I could suggest two fixes here:
# The panel should know if it is already visible or not. If the same state is requested,
the method should do nothing.
# [Optionally!] Calculate the height of the toolbar only once, and then just pass this
height to the layout manager.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:26 a.m.
[
https://issues.jboss.org/browse/JBIDE-12948?page=com.atlassian.jira.plugi...
]
Yahor Radtsevich commented on JBIDE-12948:
------------------------------------------
Denis, please measure the time of JUnits execution before and after you fix this issue (it
should be enough run only a part of them).
SelectionBar uses too much CPU resources
----------------------------------------
Key: JBIDE-12948
URL: https://issues.jboss.org/browse/JBIDE-12948
Project: Tools (JBoss Tools)
Issue Type: Sub-task
Components: Visual Page Editor core
Affects Versions: 4.0.0.Beta1
Reporter: Yahor Radtsevich
Assignee: Denis Maliarevich
Fix For: 4.0.0.CR1
While profiling VPE JUnits it seems that up to 70% of all time of their execution is
performed in the method
org.jboss.tools.jst.jsp.selection.bar.SelectionBar.setVisible(boolean):
{code}
public void setVisible(boolean visible) {
if (visible) {
splitter.setVisible(realBar, true);
splitter.setVisible(emptyBar, false);
} else {
splitter.setVisible(realBar, false);
splitter.setVisible(emptyBar, true);
}
/* JBIDE-7387:
* By default toolbar size is set to fit regular button ToolItems.
* But drop-down items are a little bigger and do not
* fit in the default-size toolbars (at least under Windows XP).
* This temporary ToolItem is needed to set enough size to the toolbar.*/
ToolItem tempItem = new ToolItem(toolbar, SWT.DROP_DOWN);
tempItem.setText(" "); //$NON-NLS-1$
tempItem.setEnabled(false);
this.getParent().layout(true, true);
tempItem.dispose();
}
{code}
The call of {{this.getParent().layout(true, true);}} is very expensive.
I could suggest two fixes here:
# The panel should know if it is already visible or not. If the same state is requested,
the method should do nothing.
# [Optionally!] Calculate the height of the toolbar only once, and then just pass this
height to the layout manager.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:34 a.m.
[
https://issues.jboss.org/browse/JBIDE-12948?page=com.atlassian.jira.plugi...
]
Denis Maliarevich commented on JBIDE-12948:
-------------------------------------------
So the fix is:
1) initialize the toolbar size once on the creation time.
2) do not call {{this.getParent().layout(true, true);}} if the visibilty has not been
changed.
It helped to reduce the time for running JsfAllTest from "652.178s" to
"345.834s" on my machine (almost 2x faster).
SelectionBar uses too much CPU resources
----------------------------------------
Key: JBIDE-12948
URL: https://issues.jboss.org/browse/JBIDE-12948
Project: Tools (JBoss Tools)
Issue Type: Sub-task
Components: Visual Page Editor core
Affects Versions: 4.0.0.Beta1
Reporter: Yahor Radtsevich
Assignee: Denis Maliarevich
Fix For: 4.0.0.CR1
While profiling VPE JUnits it seems that up to 70% of all time of their execution is
performed in the method
org.jboss.tools.jst.jsp.selection.bar.SelectionBar.setVisible(boolean):
{code}
public void setVisible(boolean visible) {
if (visible) {
splitter.setVisible(realBar, true);
splitter.setVisible(emptyBar, false);
} else {
splitter.setVisible(realBar, false);
splitter.setVisible(emptyBar, true);
}
/* JBIDE-7387:
* By default toolbar size is set to fit regular button ToolItems.
* But drop-down items are a little bigger and do not
* fit in the default-size toolbars (at least under Windows XP).
* This temporary ToolItem is needed to set enough size to the toolbar.*/
ToolItem tempItem = new ToolItem(toolbar, SWT.DROP_DOWN);
tempItem.setText(" "); //$NON-NLS-1$
tempItem.setEnabled(false);
this.getParent().layout(true, true);
tempItem.dispose();
}
{code}
The call of {{this.getParent().layout(true, true);}} is very expensive.
I could suggest two fixes here:
# The panel should know if it is already visible or not. If the same state is requested,
the method should do nothing.
# [Optionally!] Calculate the height of the toolbar only once, and then just pass this
height to the layout manager.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:38 a.m.
[
https://issues.jboss.org/browse/JBIDE-12948?page=com.atlassian.jira.plugi...
]
Denis Maliarevich commented on JBIDE-12948:
-------------------------------------------
Another solution is to *HIDE* SelectionBarby default while running JUnits. Those ones who
need it -- should enable it on the runtime.
SelectionBar uses too much CPU resources
----------------------------------------
Key: JBIDE-12948
URL: https://issues.jboss.org/browse/JBIDE-12948
Project: Tools (JBoss Tools)
Issue Type: Sub-task
Components: Visual Page Editor core
Affects Versions: 4.0.0.Beta1
Reporter: Yahor Radtsevich
Assignee: Denis Maliarevich
Fix For: 4.0.0.CR1
While profiling VPE JUnits it seems that up to 70% of all time of their execution is
performed in the method
org.jboss.tools.jst.jsp.selection.bar.SelectionBar.setVisible(boolean):
{code}
public void setVisible(boolean visible) {
if (visible) {
splitter.setVisible(realBar, true);
splitter.setVisible(emptyBar, false);
} else {
splitter.setVisible(realBar, false);
splitter.setVisible(emptyBar, true);
}
/* JBIDE-7387:
* By default toolbar size is set to fit regular button ToolItems.
* But drop-down items are a little bigger and do not
* fit in the default-size toolbars (at least under Windows XP).
* This temporary ToolItem is needed to set enough size to the toolbar.*/
ToolItem tempItem = new ToolItem(toolbar, SWT.DROP_DOWN);
tempItem.setText(" "); //$NON-NLS-1$
tempItem.setEnabled(false);
this.getParent().layout(true, true);
tempItem.dispose();
}
{code}
The call of {{this.getParent().layout(true, true);}} is very expensive.
I could suggest two fixes here:
# The panel should know if it is already visible or not. If the same state is requested,
the method should do nothing.
# [Optionally!] Calculate the height of the toolbar only once, and then just pass this
height to the layout manager.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:38 a.m.
[
https://issues.jboss.org/browse/JBIDE-12948?page=com.atlassian.jira.plugi...
]
Denis Maliarevich edited comment on JBIDE-12948 at 10/26/12 12:37 PM:
----------------------------------------------------------------------
Another solution is to *HIDE* SelectionBar by default while running JUnits. Those ones who
need it -- should enable it on the runtime.
was (Author: dmaliarevich):
Another solution is to *HIDE* SelectionBarby default while running JUnits. Those ones
who need it -- should enable it on the runtime.
SelectionBar uses too much CPU resources
----------------------------------------
Key: JBIDE-12948
URL: https://issues.jboss.org/browse/JBIDE-12948
Project: Tools (JBoss Tools)
Issue Type: Sub-task
Components: Visual Page Editor core
Affects Versions: 4.0.0.Beta1
Reporter: Yahor Radtsevich
Assignee: Denis Maliarevich
Fix For: 4.0.0.CR1
While profiling VPE JUnits it seems that up to 70% of all time of their execution is
performed in the method
org.jboss.tools.jst.jsp.selection.bar.SelectionBar.setVisible(boolean):
{code}
public void setVisible(boolean visible) {
if (visible) {
splitter.setVisible(realBar, true);
splitter.setVisible(emptyBar, false);
} else {
splitter.setVisible(realBar, false);
splitter.setVisible(emptyBar, true);
}
/* JBIDE-7387:
* By default toolbar size is set to fit regular button ToolItems.
* But drop-down items are a little bigger and do not
* fit in the default-size toolbars (at least under Windows XP).
* This temporary ToolItem is needed to set enough size to the toolbar.*/
ToolItem tempItem = new ToolItem(toolbar, SWT.DROP_DOWN);
tempItem.setText(" "); //$NON-NLS-1$
tempItem.setEnabled(false);
this.getParent().layout(true, true);
tempItem.dispose();
}
{code}
The call of {{this.getParent().layout(true, true);}} is very expensive.
I could suggest two fixes here:
# The panel should know if it is already visible or not. If the same state is requested,
the method should do nothing.
# [Optionally!] Calculate the height of the toolbar only once, and then just pass this
height to the layout manager.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:31 p.m.
[
https://issues.jboss.org/browse/JBIDE-12948?page=com.atlassian.jira.plugi...
]
Denis Maliarevich updated JBIDE-12948:
--------------------------------------
Attachment: 12948a.patch
Patch is attached.
SelectionBar uses too much CPU resources
----------------------------------------
Key: JBIDE-12948
URL: https://issues.jboss.org/browse/JBIDE-12948
Project: Tools (JBoss Tools)
Issue Type: Sub-task
Components: Visual Page Editor core
Affects Versions: 4.0.0.Beta1
Reporter: Yahor Radtsevich
Assignee: Denis Maliarevich
Fix For: 4.0.0.CR1
Attachments: 12948a.patch
While profiling VPE JUnits it seems that up to 70% of all time of their execution is
performed in the method
org.jboss.tools.jst.jsp.selection.bar.SelectionBar.setVisible(boolean):
{code}
public void setVisible(boolean visible) {
if (visible) {
splitter.setVisible(realBar, true);
splitter.setVisible(emptyBar, false);
} else {
splitter.setVisible(realBar, false);
splitter.setVisible(emptyBar, true);
}
/* JBIDE-7387:
* By default toolbar size is set to fit regular button ToolItems.
* But drop-down items are a little bigger and do not
* fit in the default-size toolbars (at least under Windows XP).
* This temporary ToolItem is needed to set enough size to the toolbar.*/
ToolItem tempItem = new ToolItem(toolbar, SWT.DROP_DOWN);
tempItem.setText(" "); //$NON-NLS-1$
tempItem.setEnabled(false);
this.getParent().layout(true, true);
tempItem.dispose();
}
{code}
The call of {{this.getParent().layout(true, true);}} is very expensive.
I could suggest two fixes here:
# The panel should know if it is already visible or not. If the same state is requested,
the method should do nothing.
# [Optionally!] Calculate the height of the toolbar only once, and then just pass this
height to the layout manager.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:53 p.m.
[
https://issues.jboss.org/browse/JBIDE-12948?page=com.atlassian.jira.plugi...
]
Alexey Kazakov reassigned JBIDE-12948:
--------------------------------------
Assignee: Yahor Radtsevich (was: Denis Maliarevich)
Yahor, could you review the PR? If it's ok I will merge it to master.
SelectionBar uses too much CPU resources
----------------------------------------
Key: JBIDE-12948
URL: https://issues.jboss.org/browse/JBIDE-12948
Project: Tools (JBoss Tools)
Issue Type: Sub-task
Components: Visual Page Editor core
Affects Versions: 4.0.0.Beta1
Reporter: Yahor Radtsevich
Assignee: Yahor Radtsevich
Fix For: 4.0.0.CR1
Attachments: 12948a.patch
While profiling VPE JUnits it seems that up to 70% of all time of their execution is
performed in the method
org.jboss.tools.jst.jsp.selection.bar.SelectionBar.setVisible(boolean):
{code}
public void setVisible(boolean visible) {
if (visible) {
splitter.setVisible(realBar, true);
splitter.setVisible(emptyBar, false);
} else {
splitter.setVisible(realBar, false);
splitter.setVisible(emptyBar, true);
}
/* JBIDE-7387:
* By default toolbar size is set to fit regular button ToolItems.
* But drop-down items are a little bigger and do not
* fit in the default-size toolbars (at least under Windows XP).
* This temporary ToolItem is needed to set enough size to the toolbar.*/
ToolItem tempItem = new ToolItem(toolbar, SWT.DROP_DOWN);
tempItem.setText(" "); //$NON-NLS-1$
tempItem.setEnabled(false);
this.getParent().layout(true, true);
tempItem.dispose();
}
{code}
The call of {{this.getParent().layout(true, true);}} is very expensive.
I could suggest two fixes here:
# The panel should know if it is already visible or not. If the same state is requested,
the method should do nothing.
# [Optionally!] Calculate the height of the toolbar only once, and then just pass this
height to the layout manager.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:59 p.m.
[
https://issues.jboss.org/browse/JBIDE-12948?page=com.atlassian.jira.plugi...
]
Yahor Radtsevich reassigned JBIDE-12948:
----------------------------------------
Assignee: Alexey Kazakov (was: Yahor Radtsevich)
Looks OK for me.
SelectionBar uses too much CPU resources
----------------------------------------
Key: JBIDE-12948
URL: https://issues.jboss.org/browse/JBIDE-12948
Project: Tools (JBoss Tools)
Issue Type: Sub-task
Components: Visual Page Editor core
Affects Versions: 4.0.0.Beta1
Reporter: Yahor Radtsevich
Assignee: Alexey Kazakov
Fix For: 4.0.0.CR1
Attachments: 12948a.patch
While profiling VPE JUnits it seems that up to 70% of all time of their execution is
performed in the method
org.jboss.tools.jst.jsp.selection.bar.SelectionBar.setVisible(boolean):
{code}
public void setVisible(boolean visible) {
if (visible) {
splitter.setVisible(realBar, true);
splitter.setVisible(emptyBar, false);
} else {
splitter.setVisible(realBar, false);
splitter.setVisible(emptyBar, true);
}
/* JBIDE-7387:
* By default toolbar size is set to fit regular button ToolItems.
* But drop-down items are a little bigger and do not
* fit in the default-size toolbars (at least under Windows XP).
* This temporary ToolItem is needed to set enough size to the toolbar.*/
ToolItem tempItem = new ToolItem(toolbar, SWT.DROP_DOWN);
tempItem.setText(" "); //$NON-NLS-1$
tempItem.setEnabled(false);
this.getParent().layout(true, true);
tempItem.dispose();
}
{code}
The call of {{this.getParent().layout(true, true);}} is very expensive.
I could suggest two fixes here:
# The panel should know if it is already visible or not. If the same state is requested,
the method should do nothing.
# [Optionally!] Calculate the height of the toolbar only once, and then just pass this
height to the layout manager.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
4954
days inactive
4972
days old
jbosstools-issues@lists.jboss.org
9 comments
3 participants
participants (3)
-
Alexey Kazakov (JIRA) -
Denis Maliarevich (JIRA)
-
Yahor Radtsevich (JIRA)