[ https://issues.jboss.org/browse/JBIDE-12319?page=com.atlassian.jira.plugi... ] Viacheslav Kabanovich updated JBIDE-12319: ------------------------------------------ Attachment: InappropriateTemporaryMarker.png -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-12319?page=com.atlassian.jira.plugi... ] Viacheslav Kabanovich commented on JBIDE-12319: ----------------------------------------------- EXECUTE: Create bean as in InappropriateTemporaryMarker.png. ASSERT: Marker is present in the line with @Inject. EXECUTE: Select annotation @Inject and delete it by Del. ASSERT: The marker is replaced by a temporary disabled marker. EXECUTE: Invoke Undo. ASSERT: Initial marker is returned. FAILURE: The temporary disabled marker persists. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-12319?page=com.atlassian.jira.plugi... ] Victor Rubezhny commented on JBIDE-12319: ----------------------------------------- I've made As-You-Type validation to work regardless of editor "Dirty" status after the Editor's content is modified. So, at the moment: - Build's validation result markers/annotations are shown right after the editor is opened; - As-You-Type annotations are shown after the content is changed (even if content is saved after a change and editor status is "non-Dirty") -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-12319?page=com.atlassian.jira.plugi... ] Viacheslav Kabanovich commented on JBIDE-12319: ----------------------------------------------- I have found new use-case with the same file. 1. Open the file - marker is available - ok. 2. Comment the line with the marker (Ctrl+/) - temporary disabled marker - ok. 3. Select @Inject and delete it (Del) - temporary disabled marker is available still - ok. 4. Uncomment the line (Ctrl+/), the line gets empty - temporary marker disappears - I am not sure if it is ok, I would prefer to see it. 5. Undo (Ctrl+Z), line gets commented, it looks as after (3) - temporary marker is missing - bug. 6. One more undo (Ctrl+Z), line looks as after (2) - temporary marker is missing - bug. 7. One more undo (Ctrl+Z), line looks as after (1) - marker is available - ok. 8. Repeat step (2) - temporary disabled marker does not appear - bug. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-12319?page=com.atlassian.jira.plugi... ] Alexey Kazakov commented on JBIDE-12319: ---------------------------------------- I can't reproduce the last use case. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-12319?page=com.atlassian.jira.plugi... ] Victor Rubezhny edited comment on JBIDE-12319 at 8/3/12 2:32 PM: ----------------------------------------------------------------- I can reproduce the issue. But... The problem here is that our DisabledAnnotation ruler annotation is removed by the OverviewRuler on positions update because its Position is removed from the Document. We can't predict such ruler annotation removal. As such, we cannot restore initial MarkerAnnotation ruler annotation (which is replaced by DisabledAnnotation on previous validation step) or the same DisabledAnnotation in that Position due to show it to a user. IMHO, Java As-You-Type validation behaves exactly the same way (Disabled ruler annotation disappears when some part of text (where the Disabled ruler annotation is placed in) is removed and at the same time the document partitioning is changed). So, IMO these is nothing to do with this case. Alexey, Slava - WDYT? was (Author: vrubezhny): I can reproduce the issue. But... The problem here is that our DisabledAnnotation ruler annotation is removed by the OverviewRuler on positions update because its Position is removed from the Document. We can't predict such ruler annotation removal. As such, we cannot restore initial MarkerAnnotation ruler annotation (which is replaced by DisabledAnnotation on previous validation step) or the same DisabledAnnotation in that Position due to show it to a user. IMHO, Java As-You-Type validation behaves exactly the same way (Disabled ruler annotation disappears when some part of text (where the Disabled ruler annotation is placed in) is removed and at the same time the document partitioning is changed). So, IMO these is nothing to do with this case. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-12319?page=com.atlassian.jira.plugi... ] Alexey Kazakov commented on JBIDE-12319: ---------------------------------------- I agree with Victor. The last use case is not critical. Let's fix only the first one. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira