[
https://issues.jboss.org/browse/JBIDE-22138?page=com.atlassian.jira.plugi...
]
Andre Dietisheim edited comment on JBIDE-22138 at 6/22/18 1:11 PM:
-------------------------------------------------------------------
[~fbricon], [~rawb] to me this smells like a bug:
Setting the maven profile for my project wont change the module name. I have to go into
the project properties and have a look at some module related items and hit "Apply
and Close" to see the module being renamed:
See here:
https://youtu.be/A-N3D_VYqfk
# EXE: "hello" project: Propererties > Maven > "Active Maven Profile:
set it to "openshift"
(I see WebProjectConfiguratorDelegate#configureDeployedName - which is inherited from
AbstractProjectConfiguratorDelegate - being invoked with the correct deployedFileName
"ROOT". See
https://github.com/eclipse/m2e.wtp/blob/master/org.eclipse.m2e.wtp/src/or...)
# EXEC: "Servers" view: select OpenShift server adapter, pick "Add and
Remove..." in the ctx menu and look at the available modules
# ASSERT: "hello" project is still listed as "hello" (where it should
be "hello (ROOT)").
# EXEC: open properties for project "hello", selet ex. "Web Content
Settings" and hit "Apply and Close".
# EXEC: in "Servers" view: select OpenShift server adapter, pick "Add and
Remove..." in ctx menu and check the "Available" modules.
# ASSERT: module name now is "hello (ROOT)"
Any idea what's the issue here?
was (Author: adietish):
[~fbricon], [~rawb] to me this smells like a bug:
As soon as I set the maven profile to "openshift" in the project properties
(hello project), I see WebProjectConfiguratorDelegate#configureDeployedName (which is
inherited from AbstractProjectConfiguratorDelegate) being invoked with the correct
deployedFileName "ROOT". See
https://github.com/eclipse/m2e.wtp/blob/master/org.eclipse.m2e.wtp/src/or...
When I then get to the OpenShift server adapter (or any other server adapter) and pick
"Add and Remove...", where I see all available modules listed in
"Available", the hello project is still listed as "hello" (where it
should be "hello (ROOT)"). To fix this I have to go into the properties for
project "hello", look at ex. "Web Content Settings" and hit
"Apply and Close". Once I did that I now see the correct module name
"hello (ROOT)" in "Add and Remove...".
See here:
https://youtu.be/A-N3D_VYqfk
Any idea what's the issue here?
Server adapter: doesn't respect openshift maven profile
-------------------------------------------------------
Key: JBIDE-22138
URL:
https://issues.jboss.org/browse/JBIDE-22138
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: openshift
Environment: JBoss Developer Studio (Core Features) 9.1.0.GA-v20160403-1700-B477
Openshift plugin 3.1.0.Final-v20160401-2357-B263
Reporter: Rafael Benevides
Assignee: Andre Dietisheim
Labels: openshift_v3, server_adapter
Fix For: 4.6.0.Final
Attachments: image-2018-06-22-19-02-57-247.png
This is a follow up on JBIDE-22128.
The maven profile is never read to determine the actual archive name. That will require
more coupling to m2e, in order to load the pom.xml model using the openshift profile, if
it exists, in order to determine the archive name. This will be a long running operation
and will require more significant changes
steps:
# EXEC: follow steps outlined in
https://github.com/redhat-helloworld-msa/helloworld-msa/blob/master/hello... (deploying
with fabric8 maven plugin doesn't work, you end up having the pod failing with
ImagePullBack error. You need to take the alternative road where you deploy via "oc
new-build", "oc new-app", "oc expose" etc.)
# EXEC: import the app into your Eclipse workspace
# EXEC: "hello" (workspace) project: Properties > Maven > Active Maven
Profile: set "openshift"
# EXEC: create a server adapter and start it
# ASSERT: adapter starts syncing, verify what war is used
Result:
The war that's created locally and then synced to the pod is "hello.war"
even though the profile specifies "ROOT.war"
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)