[ https://issues.jboss.org/browse/JBIDE-8208?page=com.atlassian.jira.plugin... ] Snjezana Peco commented on JBIDE-8208: -------------------------------------- I have tried to create a project based on the org.jboss.weld.archetypes:jboss-javaee6-webapp:1.0.1.Beta2 archetype and noticed two issues: 1) CDI and JSF facet aren't added when creating a project (a bug in the JBoss Maven configurators. They don't check transitive dependencies.). See JBIDE-8252. 2) JDT Maven configurator breaks annotation processing so that it removes the target/generated-sources/annotations directory (annotation processor source directory) from the classpath. This can be reproduced as follows: - create a javaee6 project and enable annotation processing as Dan Allen described in https://issues.jboss.org/browse/WELD-835?focusedCommentId=12577274&pa... - right-click the project, select Maven>Update Project Configuration Annotation processing won't work because the Maven JDT Configurator has removed the target/generated-sources/annotations directory from the classpath. There are several issues related to the way m2eclipse configures a classpath. See https://issues.sonatype.org/browse/MNGECLIPSE-2367 The problem can be solved by right-clicking the project, selecting Properties>Java Compiler>Annotation Processing, unchecking Enable annotation processing, clicking Apply, checking Enable annotation processing and clicking Apply again. However, calling Maven>Update Project Configurator will break annotation processing again. A solution would be to create a maven configurator (or change the maven hibernate configurator) that would check for existing the org.hibernate:hibernate-jpamodelgen dependency and if exists, the configurator would enable annotation processing and would add the correspondent factory path. In this case, .factorypath and .settings, Dan added to the archetype, wouldn't be necessary. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-8208?page=com.atlassian.jira.plugin... ] Max Rydahl Andersen updated JBIDE-8208: --------------------------------------- Fix Version/s: 3.2.1.CR1 (was: 3.2.1.M1) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-8208?page=com.atlassian.jira.plugin... ] Fred Bricon updated JBIDE-8208: ------------------------------- Component/s: UpStream -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-8208?page=com.atlassian.jira.plugin... ] Max Rydahl Andersen commented on JBIDE-8208: -------------------------------------------- assigning to you just so it doesnt looks unassigned. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-8208?page=com.atlassian.jira.plugin... ] Fred Bricon updated JBIDE-8208: ------------------------------- Fix Version/s: 3.3.0.M3 (was: 3.3.0.M2) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-8208?page=com.atlassian.jira.plugin... ] Fred Bricon updated JBIDE-8208: ------------------------------- Fix Version/s: 3.3.0.Beta1 (was: 3.3.0.M4) Pushing back -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-8208?page=com.atlassian.jira.plugin... ] Fred Bricon updated JBIDE-8208: ------------------------------- Fix Version/s: 3.3.0.Beta1 (was: 3.3.0.M5) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-8208?page=com.atlassian.jira.plugin... ] Max Rydahl Andersen commented on JBIDE-8208: -------------------------------------------- Plan: * make github/jbosstools/m2e-apt have an stable update site * get it included into m2e discovery * integrate https://github.com/excilys/m2e-extras's approach into it * if/when possible make mvn-exec the default, option for incremental APT (mainly because of "correctness" over "speed" with respect to controlling diff output folders. * provide it via jboss central when "ready" -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-8208?page=com.atlassian.jira.plugin... ] Fred Bricon updated JBIDE-8208: ------------------------------- Candidate m2e-apt build available from http://download.jboss.org/jbosstools/updates/requirements/m2eclipse/m2e-a... Waiting for JBIDE-11700 (integration to JBT extras/JBDS installer) resolution before closing this issue. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-8208?page=com.atlassian.jira.plugin... ] Sanne Grinovero edited comment on JBIDE-8208 at 5/1/12 5:34 AM: ---------------------------------------------------------------- Thanks fbricon! downloading candidate. This is extremely important for contributors of our projects! (including my own sanity of mind when needing to switch branches, update project, etc.. so I have to fix the project settings a couple of times per hour every day) was (Author: sannegrinovero): Thanks fbricon! downloading candidate. This extremely important for contributors of our projects! (including my own sanity of mind when needing to switch branches, update project, etc.. so I have to fix the project settings a couple of times per hour every day) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-8208?page=com.atlassian.jira.plugin... ] Fred Bricon updated JBIDE-8208: ------------------------------- Release Notes Text: With m2e-apt, you can now automatically enable annotation processing support for maven projects, based on their classpath dependencies (Requires Java >= 1.6). m2e-apt supports both annotation processing set on the maven-compiler-plugin or the [maven-processor-plugin|http://code.google.com/p/maven-annotation-plugin/] (the latter takes precedence over the former). For example, to enable the JPA modelgen annotation processor, you can either set : <plugin> <artifactId>maven-compiler-plugin</artifactId> <version>2.4</version> <configuration> <source>1.6</source> <target>1.6</target> </configuration> <dependencies> <dependency> <groupId>org.hibernate</groupId> <artifactId>hibernate-jpamodelgen</artifactId> <version>1.2.0.Final</version> </dependency> </dependencies> </plugin> or <plugin> <artifactId>maven-compiler-plugin</artifactId> <version>2.4</version> <configuration> <source>1.6</source> <target>1.6</target> <compilerArgument>-proc:none</compilerArgument> </configuration> </plugin> <plugin> <groupId>org.bsc.maven</groupId> <artifactId>maven-processor-plugin</artifactId> <version>2.0.5</version> <executions> <execution> <id>process</id> <goals> <goal>process</goal> </goals> <phase>generate-sources</phase> </execution> </executions> <dependencies> <dependency> <groupId>org.hibernate</groupId> <artifactId>hibernate-jpamodelgen</artifactId> <version>1.2.0.Final</version> </dependency> </dependencies> </plugin> The generated source folders (target/generated-sources/annotation for maven-compiler-plugin; target/generated-sources/apt or maven-processor-plugin) are automatically added to the project classpath. Since Annotation Processing is managed by Eclipse JDT APT by default, a change in your source classes triggers incremental processing automatically. The downside of using JDT APT is, there's no separation between main and test classes (the way maven-processor-plugin handles them). To mitigate that limitation, you can change the workspace or project preferences to delegate annotation processing to maven, instead of JDT APT (Note this only works when using maven-processor-plugin). This will result in slower incremental builds (all classes will be processed) but will provide identical results to maven command line builds. Automatic Annotation Processing configuration from the maven pom.xml can also be disabled altogether. In this case, your manual settings for Eclipse JDT APT will remain untouched. Go to Window > Preferences > Maven > Annotation processing or right-click on your project > Properties > Maven > Annotation processing to select the Annotation Processing strategy of your choice. was: With m2e-apt, you can now automatically enable annotation processing support for maven projects, based on their classpath dependencies (Requires Java >= 1.6). m2e-apt supports both annotation processing set on the maven-compiler-plugin or the [maven-processor-plugin|http://code.google.com/p/maven-annotation-plugin/] (the latter takes precedence over the former). For example, to enable the JPA modelgen annotation processor, you can either set : {code:xml} <plugin> <artifactId>maven-compiler-plugin</artifactId> <version>2.4</version> <configuration> <source>1.6</source> <target>1.6</target> </configuration> <dependencies> <dependency> <groupId>org.hibernate</groupId> <artifactId>hibernate-jpamodelgen</artifactId> <version>1.2.0.Final</version> </dependency> </dependencies> </plugin> {code} or {code:xml} <plugin> <artifactId>maven-compiler-plugin</artifactId> <version>2.4</version> <configuration> <source>1.6</source> <target>1.6</target> <compilerArgument>-proc:none</compilerArgument> </configuration> </plugin> <plugin> <groupId>org.bsc.maven</groupId> <artifactId>maven-processor-plugin</artifactId> <version>2.0.5</version> <executions> <execution> <id>process</id> <goals> <goal>process</goal> </goals> <phase>generate-sources</phase> </execution> </executions> <dependencies> <dependency> <groupId>org.hibernate</groupId> <artifactId>hibernate-jpamodelgen</artifactId> <version>1.2.0.Final</version> </dependency> </dependencies> </plugin> {code} The generated source folders (target/generated-sources/annotation for maven-compiler-plugin; target/generated-sources/apt or maven-processor-plugin) are automatically added to the project classpath. Since Annotation Processing is managed by Eclipse JDT APT by default, a change in your source classes triggers incremental processing automatically. The downside of using JDT APT is, there's no separation between main and test classes (the way maven-processor-plugin handles them). To mitigate that limitation, you can change the workspace or project preferences to delegate annotation processing to maven, instead of JDT APT (Note this only works when using maven-processor-plugin). This will result in slower incremental builds (all classes will be processed) but will provide identical results to maven command line builds. Automatic Annotation Processing configuration from the maven pom.xml can also be disabled altogether. In this case, your manual settings for Eclipse JDT will remain untouched. Go to Window > Preferences > Maven > Annotation processing or right-click on your project > Properties > Maven > Annotation processing to select the Annotation Processing strategy of your choice. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-8208?page=com.atlassian.jira.plugin... ] Sanne Grinovero commented on JBIDE-8208: ---------------------------------------- Hi Fred, I've been trying the link you posted on 30 of April (a while back when it still existed) and it didn't seem to work (but I was in a hurry to investigate). Today I've tried again from http://download.jboss.org/jbosstools/updates/requirements/m2eclipse/m2e-a... , and I see the options under Preferences/Maven/Annotation Processor to select a strategy. It looks like I should use the second option, as we use org.bsc.maven:maven-processor-plugin , but even trying the other two options nothing new is happening? The annotation processor still needs manual setup. I can't find any exception in Eclipse's Error Log (I cleared the log, deleted the projects and tried to import Hibernate Search from scratch..) Any suggestion? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-8208?page=com.atlassian.jira.plugin... ] Rastislav Wagner closed JBIDE-8208. ----------------------------------- verified in jbdevstudio-product-universal-5.0.0.v201205141759M-H140-Beta3 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira