[ https://issues.jboss.org/browse/JBIDE-12911?page=com.atlassian.jira.plugi... ] Denis Golovin updated JBIDE-12911: ---------------------------------- Fix Version/s: 4.0.0.CR1 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-12911?page=com.atlassian.jira.plugi... ] Max Rydahl Andersen updated JBIDE-12911: ---------------------------------------- Assignee: Rob Stryker -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-12911?page=com.atlassian.jira.plugi... ] Martin Malina reassigned JBIDE-12911: ------------------------------------- Assignee: Andre Dietisheim (was: Rob Stryker) Andre, can you please verify this and close? Or will you yell again when you see any more problems and I can just close this for now? ;) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-12911?page=com.atlassian.jira.plugi... ] Andre Dietisheim commented on JBIDE-12911: ------------------------------------------ I had a quick look and checked the classes listed above in an exemplary manner. I still se quite some cases where I'm not sure that the code does its best to handle errors. I'd seek for input on these and close this issue if there are valid arguments: * Is catching plain Exception and swallowing all possible errors really the best way to go? {code:title=AS7DeploymentScannerUtility#updateDeploymentScannerInterval} try { executeWithResult(server, request); } catch(Exception e) { return false; } {code} {code:title=AS7DeploymentScannerUtility#getDeploymentScannerIntervals} try { response = executeWithResult(server, request); } catch(Exception e) { return new HashMap<String, Integer>(); } {code} {code:title=AS7DeploymentScannerUtility#getDeploymentScannersFromServer} try { response = executeWithResult(server, request); } catch(Exception e) { return new HashMap<String, String>(); } {code} * empty catch block? {code:title=ModelChangeListenerWithRefresh#postChange} try { // refresh infinitely in case the output is exploded res.refreshLocal(IResource.DEPTH_INFINITE, new NullProgressMonitor()); } catch( CoreException ce ) { } {code} {code:title=ModelChangeListenerWithRefresh#postChange} try { proj.getFile(new Path(IArchiveModel.DEFAULT_PACKAGES_FILE)).refreshLocal(IResource.DEPTH_ONE, new NullProgressMonitor()); } catch( CoreException ce ) { } {code} {code:title=JBossSARFacetInstallationDelegate#execute} try{ IFolder srcFolder = ws.getRoot().getFolder(cpe.getPath()); IVirtualResource[] virtualResource = ComponentCore.createResources(srcFolder); //create link for source folder only when it is not mapped if( virtualResource.length == 0 ){ jbiRoot.createLink(cpe.getPath().removeFirstSegments(1), 0, null); } } catch(Exception e){ // TODO } {code} {code:title=RSEDeploymentPreferenceUI} try { method.getFileService(); method.ensureConnection(new NullProgressMonitor()); IHostFile file = method.getFileService().getFile(remoteFolder.removeLastSegments(1).toOSString(), remoteFolder.lastSegment(), new NullProgressMonitor()); String path = remoteFolder.toString(); IRemoteFile rf = method.getFileServiceSubSystem().getRemoteFileObject(path, null); SystemShowInTableAction act = new SystemShowInTableAction(Display.getDefault().getActiveShell()); act.setSelectedObject(rf); act.run(); } catch(SystemMessageException e) { } catch(CoreException ce) { } {code} * printStackTrace? {code:title=JBossSARFacetInstallationDelegate#createProjectStructure} try { node.flush(); } catch (BackingStoreException e) { e.printStackTrace(); } {code} {code:title=NewMessageDrivenBeanWizardPage#createType} try { UndoEdit undo = edit.apply(doc); String source = doc.get(); beanUnit.getBuffer().setContents(source); beanUnit.getBuffer().save(monitor, true); } catch (BadLocationException e) { e.printStackTrace(); } {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-12911?page=com.atlassian.jira.plugi... ] Rob Stryker commented on JBIDE-12911: ------------------------------------- For all instances of AS7DeploymentScannerUtility listed, the caller is expecting return values and do not wish to see exceptions. Any caller wishing to be informed of errors (and as of now there are none) would need to request a new API to see such. Again, the callers here simply do not wish to see such exceptions. They just want the answers. For ModelChangeListenerWithRefresh, in one instance you have specifically ignored the comment indicating an intentional lack of reporting: // Also do not log. One instance of ModelChangeListenerWithRefresh has an error on the setPersistentPRoperty (though the code is nested and could be cleaned up a bit). This will only fail if the project or file does not exist, a situation which is not requiring error handling. It may require if-statements before it, but the general idea of this code is to refresh something *IF* its available, or set the property *IF* its available. If it's not, do nothing. Hence, ignore the exception. DO not log it to confuse the users. The error in JBossSARFacetInstallationDelegate was most likely there as debugging when I was testing a runtime exception which was an error of my own code. The entire try / catch portion can be removed, as there are no checked exceptions there. The second in that class should simply be logged, as not being able to communicate witht he backing store is critical but also not a common occurance. I would imagine the errors in RSEDeploymentPreferenceUI should be logged. NewMessageDrivenBeanWizardPage is very old code nad probably needs to be revisted. The intent and the cause of the exception is unclear based on a quick view. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira