[ https://jira.jboss.org/browse/JBIDE-6723?page=com.atlassian.jira.plugin.s... ] Vitali Yemialyanchyk updated JBIDE-6723: ---------------------------------------- Attachment: screenshot-1.jpg -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBIDE-6723?page=com.atlassian.jira.plugin.s... ] Vitali Yemialyanchyk commented on JBIDE-6723: --------------------------------------------- look like these names means nothing... -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBIDE-6723?page=com.atlassian.jira.plugin.s... ] Vitali Yemialyanchyk commented on JBIDE-6723: --------------------------------------------- a rely names in brakets [] (property name for exporter) is a ant attribute name - but this not a true generally - so Export to ant codegen has a bug... the question is - what is a right way to fix it... generally it would be nice if property name for exporter will be exactly ant attribute name - for example ( <property description="For each" name="for_each" ) be a ant attribute forEach, ( <property description="Output directory" name="outputdir" ) be a ant attribute destdir and several other... so imo it be more clean if we have the same names... but I did not sure is this possible cause all documentation point screenshots with old names. i.e. there are 2 ways to fix issue: 1) change these names in plugin.xml (will it have influence to users codegen launch configs?) 2) use property name to ant attribute mapper in code (the drawback -> it will complicate code of ant exporter..) what way is better? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBIDE-6723?page=com.atlassian.jira.plugin.s... ] Vitali Yemialyanchyk commented on JBIDE-6723: --------------------------------------------- the bug test case: 1) create Hibernate Codegen config, select "Generic Exporter" and setup its 2 properties as screenshot-2, save Hibernate Codegen config; 2) Export this Hibernate Codegen config as Ant Code Generation script; 3) the result script is: <project name="CodeGen" default="JdbcCodeGen"> .... <target name="JdbcCodeGen" depends="generateHibernatePropeties"> <taskdef name="hibernatetool" classname="org.hibernate.tool.ant.HibernateToolTask" classpathref="toolslib"/> <hibernatetool destdir="${build.dir}"> <configuration configurationFile="C:\RHDS\_ws\runtime-hibernate_plugins4\qwert\src\hibernate.cfg.xml_4_rename" propertyFile="${hibernatePropFile}"> <fileset dir="." id="id"> <include name="C:\RHDS\_ws\runtime-hibernate_plugins4\qwert\src\com\indexbg\delo\db\AdmProcEtap.hbm.xml"/> <include name="C:\RHDS\_ws\runtime-hibernate_plugins4\qwert\src\com\indexbg\delo\db\AdmProcEtapIzp.hbm.xml"/> </fileset> </configuration> <classpath> <path location="${build.dir}"/> </classpath> <hbmtemplate for_each="entity" outputdir="c:\temp"/> </hibernatetool> </target> </project> 4) <hbmtemplate for_each="entity" outputdir="c:\temp"/> - has a wrong attributes "for_each" and "outputdir" should be "foreach" and "destdir" -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBIDE-6723?page=com.atlassian.jira.plugin.s... ] Vitali Yemialyanchyk updated JBIDE-6723: ---------------------------------------- Summary: Ant codegen use exporter description from pluging.xml to extract attributes (was: Exporters properties names are very strange names in compare with Hibernate Tools core Ant names) Description: Ant codegen use exporter description from pluging.xml to extract attributes names - this is not correct, there is test case demo in comments below. (was: can someone here explain what does mean name(s) in square brackets? (screenshot-1)) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBIDE-6723?page=com.atlassian.jira.plugin.s... ] Vitali Yemialyanchyk updated JBIDE-6723: ---------------------------------------- Parent: JBIDE-6518 Issue Type: Sub-task (was: Bug) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBIDE-6723?page=com.atlassian.jira.plugin.s... ] Max Rydahl Andersen commented on JBIDE-6723: -------------------------------------------- this is not minor - this is critical. the description field should *NEVER* be used for anything like this. And it is not possible to simply add an extra field for this since there is no such direct mapping. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira