[ http://jira.jboss.com/jira/browse/JBIDE-2093?page=comments#action_12409678 ] Snjezana Peco commented on JBIDE-2093: -------------------------------------- JBoss\JBoss v4.2 (1) is a WTP server that supports launching in profile mode (see the org.eclipse.wst.server.ui.launchConfigurationType extension point). JBoss, a division of Red Hat\JBoss AS 4.2 (2) is a JBoss Tools server that doesn't support this feature (see the org.jboss.ide.eclipse.as.core.server.startupConfiguration ext point). If we want to add this feature, we need to add profile mode to the org.jboss.ide.eclipse.as.core.server.startupConfiguration extension point and implement the org.eclipse.jst.server.core.serverProfilers extension point. The org.eclipse.jst.server.core.serverProfilers extension point for JBoss\JBoss v4.2 is implemented in the org.eclipse.tptp.platform.profile.server.wst plugin within the TPTP project. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBIDE-2093?page=comments#action_12409696 ] Snjezana Peco commented on JBIDE-2093: -------------------------------------- Profiling requires a dependency on TPTP (or some other profiler), but it can be optional. This can be performed by creating a separate plugin that would depend on TPTP, but would be loaded only if TPTP exists. Another solution would be to add optional dependencies on TPTP to an existing plugin. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBIDE-2093?page=all ] Snjezana Peco reassigned JBIDE-2093: ------------------------------------ Assignee: Snjezana Peco -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBIDE-2093?page=comments#action_12418979 ] Snjezana Peco commented on JBIDE-2093: -------------------------------------- In order to add this feature, I did the following: 1) changed the org.jboss.ide.eclipse.as.core plugin - added the profile action to the the org.jboss.ide.eclipse.as.core.server.startupConfiguration extension point - changed the AbstractJBossLaunchConfigType class so that it handles profile mode These changes don't introduce any dependency on TPTP. 2) created the org.jboss.tools.eclipse.as.tptp plugin It defines the org.eclipse.hyades.trace.ui.launchConfigMechanismAssociator extension point that makes the associations between the launch configurations and the TPTP data collectors. This plugin depends on TPTP. The org.jboss.tools.eclipse.as.tptp plugin won't be loaded and the profile action won't be available if a user doesn't have TPTP installed. JBoss Tools will work as usually. If the user has TPTP installed, he will have the profile action. Profiling WTP's Tomcat and Generic server works this way. Max, can I commit my changes? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBIDE-2093?page=comments#action_12421062 ] Max Rydahl Andersen commented on JBIDE-2093: -------------------------------------------- Yes, please commit. I assume TPTP is still an optional dependency - correct? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-2093?page=com.atlassian.jira.plu... ] Denis Golovin updated JBIDE-2093: --------------------------------- Affects: [Documentation (Ref Guide, User Guide, etc.)] -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira