[ https://issues.jboss.org/browse/JBIDE-10068?page=com.atlassian.jira.plugi... ] Andre Dietisheim edited comment on JBIDE-10068 at 10/27/11 1:19 PM: -------------------------------------------------------------------- I moved the client and it's test to github at https://github.com/adietish/openshift-java-client The client there is a plain java project and has no references to eclipse classes any more. The next step in this issue is to embed this client into a plug-in in tools or to provide a pom that would be able to build an osgi bundle (maven bundle plugin). was (Author: adietish): I moved the client and it's test to github at https://github.com/adietish/openshift-java-client The client there is a plain java project and has no references to eclipse classes any more. The next step in this issue is to embed this client into a plug-in in tools or to provide a pom that would be able to build an osgi bundle (maven bundle plugin). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-10068?page=com.atlassian.jira.plugi... ] Nick Boldt commented on JBIDE-10068: ------------------------------------ Embedding is bad -- ask the Modeshape/Teiid guys how often Max complains about them embedding upstream non-osgi jars in their downstream plugins. (It's a huge pain in the ass and requires manual effort to update.) You want to provide your upstream client as a plugin wrapped w/ a feature on an update site. Then it can be installed/updated via downstream automatically. Much easier for development and for end-users, too. Same way Openshift depends on AS depends on WTP depends on Indigo. :) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-10068?page=com.atlassian.jira.plugi... ] Andre Dietisheim edited comment on JBIDE-10068 at 10/28/11 12:02 PM: --------------------------------------------------------------------- ok, so the way to handle that would be to build a hybrid bundle (bundle consumable as bundle and as plain jar) and build an update site in the github git repo, right? you would then just add that repo to the 3rd party repo in our aggregate site? was (Author: adietish): ok, so the way to handle that would be to build a hybrid bundle (bundle consumable as bundle and as plain jar) and build an update site in the github git repo, right? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-10068?page=com.atlassian.jira.plugi... ] Andre Dietisheim commented on JBIDE-10068: ------------------------------------------ sure, i chose bad wording. I "could" use the maven bundle plug-in to generate the bundle-manifest or just edit by hand. Both ways the enriched manifest is a perfect fit in both worlds since non-osgi systems would just ignore the osgi specific entries. The part I'm not sure about is the update-site and aggregation. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-10068?page=com.atlassian.jira.plugi... ] Andre Dietisheim commented on JBIDE-10068: ------------------------------------------ I have moved the client to github and the build seems fine. I also uploaded 2 jars - a non-osgi-jar with all dependencies and an osgi-bundle-jar. Now we would have to hook up our jenkins to build the update site? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-10068?page=com.atlassian.jira.plugi... ] Nick Boldt commented on JBIDE-10068: ------------------------------------ Per discussion in IRC today, we have a working build for this, which is coupled to your existing openshift component build: https://hudson.qa.jboss.com/hudson/job/openshift-java-client-master/ https://hudson.qa.jboss.com/hudson/job/jbosstools-3.3_trunk.component--op... How will openshift component pick up the new client jar? Is the assumption that it'll see it on the trunk composite site [1] and therefore build against that? If so, then you'll want to add your new component's staging folder [2] and previous staging folder [3] to the composite site in SVN [4], then kick an rsync [5] to push the SVN change to [1]. [1] http://download.jboss.org/jbosstools/builds/staging/_composite_/trunk/ [2] http://download.jboss.org/jbosstools/builds/staging/openshift-java-client... [3] http://download.jboss.org/jbosstools/builds/staging.previous/openshift-ja... [4] https://svn.jboss.org/repos/jbosstools/trunk/download.jboss.org/jbosstool... [5] http://hudson.qa.jboss.com/hudson/view/DevStudio/view/DevStudio_All/job/j... If not, please clarify. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-10068?page=com.atlassian.jira.plugi... ] Andre Dietisheim commented on JBIDE-10068: ------------------------------------------ I definitely wanted to serve new client jars by our composite update site. At least I believe that you strongly suggested that and I have no better alternative. Proceeding with your steps then. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-10068?page=com.atlassian.jira.plugi... ] Andre Dietisheim edited comment on JBIDE-10068 at 11/4/11 8:40 AM: ------------------------------------------------------------------- I just added {code} <child location='http://download.jboss.org/jbosstools/builds/staging/openshi... <child location='http://download.jboss.org/jbosstools/builds/staging.previou... {code} to both compositeArtifacts.xml and compositeContent.xml and committed both files to the svn. I then launched a jenkins job that obviously did the rsync successfully: https://hudson.qa.jboss.com/hudson/view/DevStudio/view/DevStudio_All/job/... {code} Checking out a fresh workspace because /mnt/hudson_workspace/workspace/jbosstools-download.jboss.org-rsync-from-svn/jbosstools doesn't exist Cleaning workspace /mnt/hudson_workspace/workspace/jbosstools-download.jboss.org-rsync-from-svn ... A builds/staging/_composite_/trunk/compositeArtifacts.xml ... A builds/staging/_composite_/trunk/compositeContent.xml ... [jbosstools-download.jboss.org-rsync-from-svn] $ bash -xe /tmp/hudson6404190195901411177.sh + rsync -arz --rsh=ssh --protocol=28 --exclude '*.sh' /mnt/hudson_workspace/workspace/jbosstools-download.jboss.org-rsync-from-svn/jbosstools/builds /mnt/hudson_workspace/workspace/jbosstools-download.jboss.org-rsync-from-svn/jbosstools/examples /mnt/hudson_workspace/workspace/jbosstools-download.jboss.org-rsync-from-svn/jbosstools/index.html /mnt/hudson_workspace/workspace/jbosstools-download.jboss.org-rsync-from-svn/jbosstools/requirements /mnt/hudson_workspace/workspace/jbosstools-download.jboss.org-rsync-from-svn/jbosstools/updates /mnt/hudson_workspace/workspace/jbosstools-download.jboss.org-rsync-from-svn/jbosstools/web tools@filemgmt.jboss.org:/downloads_htdocs/tools/ Deleting project workspace... done Finished: SUCCESS {code} was (Author: adietish): I just added {code} <child location='http://download.jboss.org/jbosstools/builds/staging/openshi... <child location='http://download.jboss.org/jbosstools/builds/staging.previou... {code} to both compositeArtifacts.xml and compositeContent.xml and committed both files to the svn. I then launched a jenkins job that obviously did the rsync successfully: https://hudson.qa.jboss.com/hudson/view/DevStudio/view/DevStudio_All/job/... {code} Checking out a fresh workspace because /mnt/hudson_workspace/workspace/jbosstools-download.jboss.org-rsync-from-svn/jbosstools doesn't exist Cleaning workspace /mnt/hudson_workspace/workspace/jbosstools-download.jboss.org-rsync-from-svn ... A builds/staging/_composite_/trunk/compositeArtifacts.xml ... A builds/staging/_composite_/trunk/compositeArtifacts.xml ... [jbosstools-download.jboss.org-rsync-from-svn] $ bash -xe /tmp/hudson6404190195901411177.sh + rsync -arz --rsh=ssh --protocol=28 --exclude '*.sh' /mnt/hudson_workspace/workspace/jbosstools-download.jboss.org-rsync-from-svn/jbosstools/builds /mnt/hudson_workspace/workspace/jbosstools-download.jboss.org-rsync-from-svn/jbosstools/examples /mnt/hudson_workspace/workspace/jbosstools-download.jboss.org-rsync-from-svn/jbosstools/index.html /mnt/hudson_workspace/workspace/jbosstools-download.jboss.org-rsync-from-svn/jbosstools/requirements /mnt/hudson_workspace/workspace/jbosstools-download.jboss.org-rsync-from-svn/jbosstools/updates /mnt/hudson_workspace/workspace/jbosstools-download.jboss.org-rsync-from-svn/jbosstools/web tools@filemgmt.jboss.org:/downloads_htdocs/tools/ Deleting project workspace... done Finished: SUCCESS {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-10068?page=com.atlassian.jira.plugi... ] Andre Dietisheim updated JBIDE-10068: ------------------------------------- Attachment: openshift-express-client.png -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-10068?page=com.atlassian.jira.plugi... ] Andre Dietisheim commented on JBIDE-10068: ------------------------------------------ we now only have to verify the build works fine (local and jenkins). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-10068?page=com.atlassian.jira.plugi... ] Andre Dietisheim resolved JBIDE-10068. -------------------------------------- Resolution: Done -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-10068?page=com.atlassian.jira.plugi... ] Andre Dietisheim edited comment on JBIDE-10068 at 11/5/11 5:11 PM: ------------------------------------------------------------------- I now also removed both openshift express bundles (client and tests) from the plugin and tests poms and respun the openshift component. build #26 is now green (blue) again. was (Author: adietish): I now also removed both openshift express client (plugin and tests) bundle from the bundle and tests poms and respun the openshift component. build #26 is now green (blue) again. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-10068?page=com.atlassian.jira.plugi... ] Max Rydahl Andersen commented on JBIDE-10068: --------------------------------------------- Just to explain the reasons for this: The primary reason why we were moving openshift client code to github was to make it easy for openshift team and others who are *not* using eclipse nor osgi for their work to pick it up maintain and use it. Plus we did not want to spend time setting up hudson ci tycho builds which would need to change anyway, plus this library would now need to be manually installed and having to explain this and keeping under control for right branches/trunks just wasn't worth doing. And this scenario is *not* the same as teiid/modeshape - teiid/modeshape is a problem because of the hard coupling of the internal .jar to a specific runtime. This is not the case of the openshift library - we can and will be able to build and use this jar independent of any runtime release. Of course if OpenShift server side breaks it breaks us too but that is independent on where the openshift jar lives. Thus we (Andre, Rob and me) settled on keeping the .client openshift plugin on jboss tools side in svn and then just embed the openshift client jar inside it thus not requiring to change every devs setup and to keep the github client jar simple (non-eclipse/tycho). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-10068?page=com.atlassian.jira.plugi... ] Andre Dietisheim commented on JBIDE-10068: ------------------------------------------ I now committed a wrapper bundle org.jboss.tools.openshift.express.client that holds the github client jar and its dependency (jboss-dmr) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-10068?page=com.atlassian.jira.plugi... ] Nick Boldt commented on JBIDE-10068: ------------------------------------ uh, if people want to fetch github sources and just build the single non-osgi jar, they TOTALLY can. The "pollution", as you call it, of having this upstream plugin packaged up as an osgi jar, wrapped w/ a feature, wrapped with a site.xml, published to our _composite_ site, meant we could consume it like we do any other upstream plugin. Why is that bad? And why would you rather the overhead of manually committing embedded jars in SVN when you can just pull them from upstream via our existing Jenkins build infra? You've railed for years about the suck of Modeshape/Teiid having to commit binaries into SVN, yet unless I'm mistaken, that's exactly what you're proposing here. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-10068?page=com.atlassian.jira.plugi... ] Nick Boldt edited comment on JBIDE-10068 at 11/7/11 2:27 PM: ------------------------------------------------------------- -uh, if people want to fetch github sources and just build the single non-osgi jar, they TOTALLY can. The "pollution", as you call it, of having this upstream plugin packaged up as an osgi jar, wrapped w/ a feature, wrapped with a site.xml, published to our _composite_ site, meant we could consume it like we do any other upstream plugin. - -Why is that bad? And why would you rather the overhead of manually committing embedded jars in SVN when you can just pull them from upstream via our existing Jenkins build infra? You've railed for years about the suck of Modeshape/Teiid having to commit binaries into SVN, yet unless I'm mistaken, that's exactly what you're proposing here.- Can we move the OpenShift component code to a second github repo, so that the work done here can be reused? If nothing else, it would allow us to start gradually moving components out of SVN and into git. was (Author: nickboldt): uh, if people want to fetch github sources and just build the single non-osgi jar, they TOTALLY can. The "pollution", as you call it, of having this upstream plugin packaged up as an osgi jar, wrapped w/ a feature, wrapped with a site.xml, published to our _composite_ site, meant we could consume it like we do any other upstream plugin. Why is that bad? And why would you rather the overhead of manually committing embedded jars in SVN when you can just pull them from upstream via our existing Jenkins build infra? You've railed for years about the suck of Modeshape/Teiid having to commit binaries into SVN, yet unless I'm mistaken, that's exactly what you're proposing here. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-10068?page=com.atlassian.jira.plugi... ] Andre Dietisheim commented on JBIDE-10068: ------------------------------------------ setting fix version to LATER since there's no urgency for now. We have a lot of far more urgent issues to deal with until we go GA -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-10068?page=com.atlassian.jira.plugi... ] Max Rydahl Andersen updated JBIDE-10068: ---------------------------------------- Fix Version/s: 3.3.0.Beta1 (was: 3.3.x) Andre - isn't this already done and the issue can be resolved ? What is left? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-10068?page=com.atlassian.jira.plugi... ] Max Rydahl Andersen commented on JBIDE-10068: --------------------------------------------- thats an separate issue. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-10068?page=com.atlassian.jira.plugi... ] Andre Dietisheim resolved JBIDE-10068. -------------------------------------- Resolution: Done the client was moved to github: https://github.com/adietish/openshift-java-client we kept a wrapping bundle for now and investigate if we should keep the bundle on github, too: JBIDE-10136 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira