[ http://jira.jboss.com/jira/browse/JBIDE-2244?page=all ] Max Rydahl Andersen updated JBIDE-2244: --------------------------------------- Assignee: Max Rydahl Andersen -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBIDE-2244?page=comments#action_12416693 ] Dima Geraskov commented on JBIDE-2244: -------------------------------------- Yes, I like to take a stab. The Dali documentation says about "org.eclipse.dali.*" extension points, but I didn't find them. http://wiki.eclipse.org/index.php/Dali_Developer_Documentation#Dali_Plug-ins I try to understand how Dali connected with jpt jars. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBIDE-2244?page=comments#action_12416717 ] Dima Geraskov commented on JBIDE-2244: -------------------------------------- I use jpt 2.0.0 and I havent schema/jpaPlatform.exsd. It is rather strange... -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBIDE-2244?page=comments#action_12416972 ] Dima Geraskov commented on JBIDE-2244: -------------------------------------- Yes, schemas not needed for extensions, but it is difficult to guess what parameter should present and it is a waste of time. I found *.exsd shcemas for the extension points (int their CVS): *** Host dev.eclipse.org Repository Paths /cvsroot/webtools User anonymous Password (leave blank) Connection Type pserver ***(To whom who can't find it) and put the schemas into my jars (core and ui), and decided temporarily put them into our new plugins, that everybody could easily do the same thing. So, simple implementation is done: 2 plugins created, own subclasses added, plugin.xml files changed to implement 'Hibernate' platform. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBIDE-2244?page=comments#action_12416985 ] Dima Geraskov commented on JBIDE-2244: -------------------------------------- I use Ganymede M6 - there is not schema files. I'm going to install Ganymede M7 today, when I check I'll answer to the question and remove unnecessary files from plugins. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBIDE-2244?page=comments#action_12416987 ] Max Rydahl Andersen commented on JBIDE-2244: -------------------------------------------- M6 is really old, M7 is old ...use the RC4 candidate. About commit then yes, if these are seperate plugins then just commit them when you have something that works as a basis. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBIDE-2244?page=comments#action_12417020 ] Max Rydahl Andersen commented on JBIDE-2244: -------------------------------------------- jpt folder ? why not just under the existing hibernateools/plugins dir ? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBIDE-2244?page=comments#action_12417027 ] Max Rydahl Andersen commented on JBIDE-2244: -------------------------------------------- the modules in trunk is functionally related grouping. These plugins you are writing relates to hibernate, where we just uses jpt. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBIDE-2244?page=comments#action_12417374 ] Dima Geraskov commented on JBIDE-2244: -------------------------------------- Max, do you want to use our reverse engeneering entities generation here? This means provide our wizard to select catalog/schema/tables and run something like SeamGenerate entities or something other(see JBIDE-1178)? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBIDE-2244?page=comments#action_12419278 ] Dima Geraskov commented on JBIDE-2244: -------------------------------------- Our console configuration doesn't able to work with dtp connection profile. To build a temporary console configuration at runtime we should (1 of 4): a) have necessary properties specified in persistence.xml (like driver, url, user name etc) b) have line <property name="hibernate.ejb.cfgfile" value="/hibernate.cfg.xml"/> in persistence.xml and right hibernate.cfg.xml c) create hibernate.properties file with the properties from dtp connection profile (we can do not delete this file when delete temporary configuration, just rewrite it on each run, so we need hide the file from project) d) teach our console configuration to work with dtp connection profile. *a* and *b* variants doesn't require selection of connection profile for generating( owing to flexibily loss and duplication of connection settings). We can change core plugin's code to create necessary content in persistence xml at the time of project creation. IMHO *d* variant is the most far-sighted and flexible, and I know that Vitali had worked on it (JBIDE-719), but the code still be only a patch, but not applied code. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBIDE-2244?page=comments#action_12421109 ] Dima Geraskov commented on JBIDE-2244: -------------------------------------- I've researched possibility to use a) and b) and had an inference that it is not possible now. All methods which lead us to persistence.xml generation have 'private' visibility. And according to "Dali Developer Documentation" at http://wiki.eclipse.org/index.php/Dali_Developer_Documentation#Major_Inte... the extension point to persistence.xml properties marked as "Future Extension points". About my comment at c). First of all I want to notice that all a)-d) variants is only for generating with connection profile selection-in this case we haven't existing console configuration and need to find a way to create it at runtime. c) - variant propose to create temporary hibernate.properties file with connection properties from connection profile and create temporary console configuration and use it for entity/ddl generating. All this work should be invisible for the user. When user prefer to use existing console configuration we haven't any problems at all. This approach have beed realized by me already. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-2244?page=com.atlassian.jira.plu... ] Max Rydahl Andersen commented on JBIDE-2244: -------------------------------------------- thanks Ed - if you find more things Eclipse is putting warnings/error markers on that it shouldn't let us know. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-2244?page=com.atlassian.jira.plu... ] Max Rydahl Andersen updated JBIDE-2244: --------------------------------------- Fix Version/s: 3.0.0.alpha (was: 3.0.0.beta1) Dima - wasn't th einitial version of this supposed to be in alpha1 ? I can't see it in Alpha1 build - I only see Generic and EclipseLink... -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-2244?page=com.atlassian.jira.plu... ] Max Rydahl Andersen commented on JBIDE-2244: -------------------------------------------- I added the plugins to feature.xml - not sure more is required for it. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-2244?page=com.atlassian.jira.plu... ] Dima Geraskov reopened JBIDE-2244: ---------------------------------- Denis, we can't close the issue while patch for JBIDE-719 is not applied. Because in this case new plugins can't work with connection profile. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-2244?page=com.atlassian.jira.plu... ] Dima Geraskov commented on JBIDE-2244: -------------------------------------- In the wizard we can choose to use existing console configuration or connection profile. If we select connection profile, then I create temporary console configuration and generate necessary file on it. Without patch 719 our temporary console configuration can't be build if it use connection profile settings. So without the patch isssue can to work only with existing cc. I can disable second choice( and I'll do it right now), but we still can't close the issue as it is not fully integrated in this case(we'll not able to use connection profile). -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-2244?page=com.atlassian.jira.plu... ] Dima Geraskov closed JBIDE-2244. -------------------------------- Resolution: Done -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira