[JBoss JIRA] Created: (JBIDE-3033) Generate Hibernate/JPA - ManyToOne is more preferable choice than OneToOne
1:26 p.m.
Generate Hibernate/JPA - ManyToOne is more preferable choice than OneToOne
--------------------------------------------------------------------------
Key: JBIDE-3033
URL: https://jira.jboss.org/jira/browse/JBIDE-3033
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Affects Versions: 3.0.0.beta1
Reporter: Vitali Yemialyanchyk
Assignee: Vitali Yemialyanchyk
Fix For: 3.0.0.cr1
OneToOne relation is much more constrained than ManyToOne.
So if there is no back reference - it is more likely this is ManyToOne relation.
In the case of back reference existence - ManyToOne will always be a safe bet,
so in this ambiguous case ManyToOne seems is a better choice -
but this is thing for discussion - there are some questions here.
+ may be we should add some comments into sources.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:38 p.m.
New subject: [JBoss JIRA] Updated: (JBIDE-3033) Generate Hibernate/JPA - ManyToOne is more preferable choice than OneToOne
[
https://jira.jboss.org/jira/browse/JBIDE-3033?page=com.atlassian.jira.plu...
]
Max Rydahl Andersen updated JBIDE-3033:
---------------------------------------
Fix Version/s: 3.0.0.beta1
(was: 3.0.0.cr1)
need to be fixed since it will generate wrong code 90% of the time.
Generate Hibernate/JPA - ManyToOne is more preferable choice than
OneToOne
--------------------------------------------------------------------------
Key: JBIDE-3033
URL: https://jira.jboss.org/jira/browse/JBIDE-3033
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Affects Versions: 3.0.0.beta1
Reporter: Vitali Yemialyanchyk
Assignee: Vitali Yemialyanchyk
Fix For: 3.0.0.beta1
OneToOne relation is much more constrained than ManyToOne.
So if there is no back reference - it is more likely this is ManyToOne relation.
In the case of back reference existence - ManyToOne will always be a safe bet,
so in this ambiguous case ManyToOne seems is a better choice -
but this is thing for discussion - there are some questions here.
+ may be we should add some comments into sources.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:30 a.m.
New subject: [JBoss JIRA] Commented: (JBIDE-3033) Generate Hibernate/JPA - ManyToOne is more preferable choice than OneToOne
[
https://jira.jboss.org/jira/browse/JBIDE-3033?page=com.atlassian.jira.plu...
]
Vitali Yemialyanchyk commented on JBIDE-3033:
---------------------------------------------
currently ManyToOne is the annotation by default - it should be enough for beta1;
but for more complex cases - like
org.hibernate.eclipse.jdt.ui.test\res\specimen\test\annotated\Person.java
org.hibernate.eclipse.jdt.ui.test\res\specimen\test\annotated\Foto.java
- now here is ManyToOne on both sides - it is workable,
but - i expect here should be One2One relation with
OneToOne annotations on both sides.
Also now it does not take into account user suggestion with mappedBy...
Generate Hibernate/JPA - ManyToOne is more preferable choice than
OneToOne
--------------------------------------------------------------------------
Key: JBIDE-3033
URL: https://jira.jboss.org/jira/browse/JBIDE-3033
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Affects Versions: 3.0.0.beta1
Reporter: Vitali Yemialyanchyk
Assignee: Vitali Yemialyanchyk
Fix For: 3.0.0.beta1
OneToOne relation is much more constrained than ManyToOne.
So if there is no back reference - it is more likely this is ManyToOne relation.
In the case of back reference existence - ManyToOne will always be a safe bet,
so in this ambiguous case ManyToOne seems is a better choice -
but this is thing for discussion - there are some questions here.
+ may be we should add some comments into sources.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:23 a.m.
New subject: [JBoss JIRA] Commented: (JBIDE-3033) Generate Hibernate/JPA - ManyToOne is more preferable choice than OneToOne
[
https://jira.jboss.org/jira/browse/JBIDE-3033?page=com.atlassian.jira.plu...
]
Vitali Yemialyanchyk commented on JBIDE-3033:
---------------------------------------------
Update - currently i take into account user suggestions.
Example which i describe before - i propose live this feature till cr1.
Generate Hibernate/JPA - ManyToOne is more preferable choice than
OneToOne
--------------------------------------------------------------------------
Key: JBIDE-3033
URL: https://jira.jboss.org/jira/browse/JBIDE-3033
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Affects Versions: 3.0.0.beta1
Reporter: Vitali Yemialyanchyk
Assignee: Vitali Yemialyanchyk
Fix For: 3.0.0.beta1
OneToOne relation is much more constrained than ManyToOne.
So if there is no back reference - it is more likely this is ManyToOne relation.
In the case of back reference existence - ManyToOne will always be a safe bet,
so in this ambiguous case ManyToOne seems is a better choice -
but this is thing for discussion - there are some questions here.
+ may be we should add some comments into sources.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:25 a.m.
New subject: [JBoss JIRA] Updated: (JBIDE-3033) Generate Hibernate/JPA - ManyToOne is more preferable choice than OneToOne
[
https://jira.jboss.org/jira/browse/JBIDE-3033?page=com.atlassian.jira.plu...
]
Vitali Yemialyanchyk updated JBIDE-3033:
----------------------------------------
Fix Version/s: 3.0.0.cr1
(was: 3.0.0.beta1)
Generate Hibernate/JPA - ManyToOne is more preferable choice than
OneToOne
--------------------------------------------------------------------------
Key: JBIDE-3033
URL: https://jira.jboss.org/jira/browse/JBIDE-3033
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Affects Versions: 3.0.0.beta1
Reporter: Vitali Yemialyanchyk
Assignee: Vitali Yemialyanchyk
Fix For: 3.0.0.cr1
OneToOne relation is much more constrained than ManyToOne.
So if there is no back reference - it is more likely this is ManyToOne relation.
In the case of back reference existence - ManyToOne will always be a safe bet,
so in this ambiguous case ManyToOne seems is a better choice -
but this is thing for discussion - there are some questions here.
+ may be we should add some comments into sources.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:28 a.m.
New subject: [JBoss JIRA] Updated: (JBIDE-3033) Generate Hibernate/JPA - ManyToOne is more preferable choice than OneToOne
[
https://jira.jboss.org/jira/browse/JBIDE-3033?page=com.atlassian.jira.plu...
]
Max Rydahl Andersen updated JBIDE-3033:
---------------------------------------
Component/s: Hibernate
Generate Hibernate/JPA - ManyToOne is more preferable choice than
OneToOne
--------------------------------------------------------------------------
Key: JBIDE-3033
URL: https://jira.jboss.org/jira/browse/JBIDE-3033
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Hibernate
Affects Versions: 3.0.0.beta1
Reporter: Vitali Yemialyanchyk
Assignee: Vitali Yemialyanchyk
Fix For: 3.0.0.cr1
OneToOne relation is much more constrained than ManyToOne.
So if there is no back reference - it is more likely this is ManyToOne relation.
In the case of back reference existence - ManyToOne will always be a safe bet,
so in this ambiguous case ManyToOne seems is a better choice -
but this is thing for discussion - there are some questions here.
+ may be we should add some comments into sources.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:33 a.m.
New subject: [JBoss JIRA] Resolved: (JBIDE-3033) Generate Hibernate/JPA - ManyToOne is more preferable choice than OneToOne
[
https://jira.jboss.org/jira/browse/JBIDE-3033?page=com.atlassian.jira.plu...
]
Vitali Yemialyanchyk resolved JBIDE-3033.
-----------------------------------------
Resolution: Done
Assignee: Anton Klimkovich (was: Vitali Yemialyanchyk)
Generate Hibernate/JPA - ManyToOne is more preferable choice than
OneToOne
--------------------------------------------------------------------------
Key: JBIDE-3033
URL: https://jira.jboss.org/jira/browse/JBIDE-3033
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Hibernate
Affects Versions: 3.0.0.beta1
Reporter: Vitali Yemialyanchyk
Assignee: Anton Klimkovich
Fix For: 3.0.0.cr1
OneToOne relation is much more constrained than ManyToOne.
So if there is no back reference - it is more likely this is ManyToOne relation.
In the case of back reference existence - ManyToOne will always be a safe bet,
so in this ambiguous case ManyToOne seems is a better choice -
but this is thing for discussion - there are some questions here.
+ may be we should add some comments into sources.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:01 a.m.
New subject: [JBoss JIRA] Commented: (JBIDE-3033) Generate Hibernate/JPA - ManyToOne is more preferable choice than OneToOne
[
https://jira.jboss.org/jira/browse/JBIDE-3033?page=com.atlassian.jira.plu...
]
Vitali Yemialyanchyk commented on JBIDE-3033:
---------------------------------------------
OneToOne should be tested more attentively...
http://java.sun.com/javaee/5/docs/api/javax/persistence/OneToOne.html
it preference is example 1 from reference above
is JoinColumn obligatory annotation here?
for simplest case i expected it is not.
Generate Hibernate/JPA - ManyToOne is more preferable choice than
OneToOne
--------------------------------------------------------------------------
Key: JBIDE-3033
URL: https://jira.jboss.org/jira/browse/JBIDE-3033
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Hibernate
Affects Versions: 3.0.0.beta1
Reporter: Vitali Yemialyanchyk
Assignee: Anton Klimkovich
Fix For: 3.0.0.cr1
OneToOne relation is much more constrained than ManyToOne.
So if there is no back reference - it is more likely this is ManyToOne relation.
In the case of back reference existence - ManyToOne will always be a safe bet,
so in this ambiguous case ManyToOne seems is a better choice -
but this is thing for discussion - there are some questions here.
+ may be we should add some comments into sources.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:42 a.m.
New subject: [JBoss JIRA] Commented: (JBIDE-3033) Generate Hibernate/JPA - ManyToOne is more preferable choice than OneToOne
[
https://jira.jboss.org/jira/browse/JBIDE-3033?page=com.atlassian.jira.plu...
]
Max Rydahl Andersen commented on JBIDE-3033:
--------------------------------------------
Vitali - I did not understand your last comment ?
Generate Hibernate/JPA - ManyToOne is more preferable choice than
OneToOne
--------------------------------------------------------------------------
Key: JBIDE-3033
URL: https://jira.jboss.org/jira/browse/JBIDE-3033
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Hibernate
Affects Versions: 3.0.0.beta1
Reporter: Vitali Yemialyanchyk
Assignee: Anton Klimkovich
Fix For: 3.0.0.cr1
OneToOne relation is much more constrained than ManyToOne.
So if there is no back reference - it is more likely this is ManyToOne relation.
In the case of back reference existence - ManyToOne will always be a safe bet,
so in this ambiguous case ManyToOne seems is a better choice -
but this is thing for discussion - there are some questions here.
+ may be we should add some comments into sources.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:37 a.m.
New subject: [JBoss JIRA] Commented: (JBIDE-3033) Generate Hibernate/JPA - ManyToOne is more preferable choice than OneToOne
[
https://jira.jboss.org/jira/browse/JBIDE-3033?page=com.atlassian.jira.plu...
]
Vitali Yemialyanchyk commented on JBIDE-3033:
---------------------------------------------
I check result of my One2One generation - and have got an error - "Relationship must
have an owner"
currently in one2one case i genarate smth. like this:
====
class Person
...
@OneToOne(mappedBy="person")
private Foto foto;
...
+++
public class Foto
...
@OneToOne(mappedBy="foto")
private Person person;
...
====
should be
====
class Person
...
@OneToOne(mappedBy="person")
private Foto foto;
...
+++
public class Foto
...
@OneToOne
@JoinColumn(name="fPersonId")
...
====
there are several unclear things here
1) which entity should be relationship owner - random selection is possible?
2) JoinColumn -> name - is not easy define correct value here...
so I doubt - should i return this case back to ManyToOne or change it to correct OneToOne
generation
where 1) is random selection; 2) @JoinColumn(name="?") - generate this
Generate Hibernate/JPA - ManyToOne is more preferable choice than
OneToOne
--------------------------------------------------------------------------
Key: JBIDE-3033
URL: https://jira.jboss.org/jira/browse/JBIDE-3033
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Hibernate
Affects Versions: 3.0.0.beta1
Reporter: Vitali Yemialyanchyk
Assignee: Anton Klimkovich
Fix For: 3.0.0.cr1
OneToOne relation is much more constrained than ManyToOne.
So if there is no back reference - it is more likely this is ManyToOne relation.
In the case of back reference existence - ManyToOne will always be a safe bet,
so in this ambiguous case ManyToOne seems is a better choice -
but this is thing for discussion - there are some questions here.
+ may be we should add some comments into sources.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5698
days inactive
5727
days old
jbosstools-issues@lists.jboss.org
9 comments
2 participants
participants (2)
-
Max Rydahl Andersen (JIRA) -
Vitali Yemialyanchyk (JIRA)