[ https://jira.jboss.org/jira/browse/JBIDE-4655?page=com.atlassian.jira.plu... ] Snjezana Peco commented on JBIDE-4655: -------------------------------------- Sorry for the mistake. The problem isn't in WTP 3.1, but in JBoss Tools and m2eclipse. I think it was introduced by fixing JBDS-4507 (06/18/2009) If you try the following test case: - import test1.zip archive to the workspace using Import>Existing Projects in Workspace you will get the test1 dynamic web project and the test1EAR ear project - create an EAR file (right-click test1EAR and Export>Java EE>EAR file you will get an archive file with the following structure test1EAR.ear - test1.war The problem is deploying this application to the JBoss Tools server. If you use JBDS 2.1.0 or some JBoss Tools<20090618, you will get the following structure: test1EAR.ear - test1-0.0.1.war If you use JBoss Tools (>20090618), you will get the following structure: test1EAR.ear - test1.war The problem is caused by the following line: ... <wb-module deploy-name="test1-0.0.1"> ... in test1/.settings/org.eclipse.wst.common.component.xml Because of the way JBoss Tools was working until 06/18/2009, the problem with m2eclipse wasn't reproducible. Now, it can be reproduced in the following way: - import the test.zip archive using Import>Existing Projects in Workspace you will get the test dynamic web project and the testEAR ear project - create an EAR file (right-click test1EAR and Export>Java EE>EAR file you will get an archive file with the following structure testEAR.ear - test.war The application is invalid because application.xml contains the following: <module> <web> <web-uri>test-0.0.1-SNAPSHOT.war</web-uri> <context-root>test</context-root> </web> </module> and because test-0.0.1-SNAPSHOT.war module doesn't exist (the EAR file contains test.war). If you deploy testEAR to some JBoss Tools server using JDBS 2.1.0, you will get the following structure: testEAR.ear - test-0.0.1-SNAPSHOT.war and the application will work correctly. If you deploy testEAR with the latest JBoss Tools (>20090618), you will get: testEAR.ear - test.war It seems that JBIDE-4507 fixes inconsistencies between WTP and JBoss Tools related to the deployment. However, there is an inconsistency between JBDS 2.0.0/2.1.0 and the current JBoss Tools. If we keep the current way of deploying EAR applications, the application.xml can be fixed. There is yet another problem in m2eclipse that can be reproduced as follows: - close the test project from the test.zip archive - open the test project - create an EAR file (or deploy on the JBoss Tools server using the JBoss Tools trunk) You will get the following structure: testEAR.ear - test-0.0.1-SNAPSHOT.war - close the testEAR project - open the testEAR project - create an EAR file (or deploy on the JBoss Tools server using the JBoss Tools trunk) You will get the following EAR file: testEAR.ear - test.war I could try to create a patch for m2eclipse, but need to know in what way we will solve the problem of inconsistency between JBDS 2.0.0/2.1.0 and the current JBoss Tools. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-4655?page=com.atlassian.jira.plu... ] Rob Stryker commented on JBIDE-4655: ------------------------------------ definitely related to https://bugs.eclipse.org/bugs/show_bug.cgi?id=276825 There's a difference between getName() and getDeployName() and it seems the publisher is using the wrong one. I will test this tomorrow and see if it's an issue I can raise upstream. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-4655?page=com.atlassian.jira.plu... ] Snjezana Peco commented on JBIDE-4655: -------------------------------------- The main problem for me here is different behaviour of JBoss deployer in JBDS 2.x/JBoss Tools 3.0.x and in JBoss Tools 3.1. That's why I can't create mavenized booking example that would work in JBDS 2.1 and in JBoss Tools 3.1. This will be possible if the m2eclipse team fixes https://issues.sonatype.org/browse/MNGECLIPSE-1564 and the issue described on http://archive.m2eclipse.codehaus.org/lists/org.codehaus.m2eclipse.dev/ms... or if we resolve JBIDE-4507 in the jbosstools-3.0.x branch. Rob, Is it possible to resolve JBIDE-4507 in the jbosstools-3.0.x branch? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-4655?page=com.atlassian.jira.plu... ] Max Rydahl Andersen commented on JBIDE-4655: -------------------------------------------- i.e. does WTP server adapters have the same problem ? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-4655?page=com.atlassian.jira.plu... ] Max Rydahl Andersen commented on JBIDE-4655: -------------------------------------------- Snjezana, now that JBIDE-4507 is fixed in 3.0.x is this issue then fixable ? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-4655?page=com.atlassian.jira.plu... ] Max Rydahl Andersen updated JBIDE-4655: --------------------------------------- Assignee: Rob Stryker (was: Snjezana Peco) so Rob needs to take a look again on this issue. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-4655?page=com.atlassian.jira.plu... ] Rob Stryker commented on JBIDE-4655: ------------------------------------ I've looked over the WTP code and there's simply no way to get it to be able to check the referenced project's component.xml for it's deploy-name. It would be a huge amount of work to do by hand (re-parsing the descriptors in the getURI() method, where it should do no such thing), and also since it's not conformant with any written spec, it'd be not the right thing to do. I'm extremely curious where these test / zip files came from. In case you weren't aware, there's no UI for the user to change the "deploy-name" attribute of the wb-module tag inside a component.xml, which means anyone who has changed this has done it by hand or via their own custom plugin and API. Where did these mavenized project examples come from? Are they our examples? If they're our examples, then we should change them, and I'll show you how to do that. If they're not ours I'd like to know where they came from. I also don't believe any of our project wizards are setting that attribute, and if they are, they shouldn't be. There was never any contract or agreement that that attribute would ever be looked at. It was only looked at in the past as a bug in my code because I wasn't conforming to the parentModule.getURI(childModule) pattern. If these are our projects / test zip files, there are two possible ways to fix it. 1) In the web project's component.xml, CHANGE <web-uri>test-0.0.1-SNAPSHOT.war</web-uri> TO <web-uri>test.war</web-uri> * or * 2) In the ear project's component.xml, modify as follows: CHANGE <dependent-module deploy-path="/" handle="module:/resource/test/test"> TO <dependent-module archiveName="test-0.0.1-SNAPSHOT.war" deploy-path="/" handle="module:/resource/test/test"> -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-4655?page=com.atlassian.jira.plu... ] Rob Stryker commented on JBIDE-4655: ------------------------------------ My results are as follows: 1: Current (TRUNK) JBTools *CUSTOM* server adapter results in testEAR.ear/test.war 2: Current (TRUNK) JBTools using GENERIC server adapter results in testEAR.ear/test.war 3: Current (TRUNK) JBTools * exporting * the ear project results in testEAR.ear/test.war 4: JBT branch (3.0.x) using generic server results in testEAR.ear/test.war 5: JBT branch (3.0.x) using export operation results in testEAR.ear/test.war 6: JBT branch (3.0.x) *CUSTOM* generic server results in testEAR.ear/test-0.0.1-SNAPSHOT.war All I can conclude is that the absolute only case that's different at all is jbt-branch and older jbtools implementations which incorrectly performed getName() on the child module. HOWEVER: It seems very strange to me that out of 6 possibilities, the application.xml contains a value that matches *only* the jbosstools branch and not export, generic server adapter, or jbosstools trunk. Fixing the branch would be very difficult as there were many outstanding getModuleURI() bugs at that time especially dealing with binary modules. The code in the branch does several things to specifically get around several of these errors. If at all possible, if we control these projects, I would very much recommend changing the following portions of the project: 1) In file testEAR/EarContent/META-INF/application.xml REPLACE <web-uri>test-0.0.1-SNAPSHOT.war</web-uri> WITH <web-uri>test.war</web-uri> 2) In file test/.settings/org.eclipse.wst.common.component REPLACE <wb-module deploy-name="test-0.0.1-SNAPSHOT"> WITH <wb-module deploy-name="test"> This would align all issues across all versions and make the project work everywhere. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-4655?page=com.atlassian.jira.plu... ] Rob Stryker updated JBIDE-4655: ------------------------------- Assignee: Snjezana Peco (was: Rob Stryker) great it looks like they've acknowledged it. That's wonderful. Passing back to you since you'll know how to make use of it once they fix it. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-4655?page=com.atlassian.jira.plu... ] Snjezana Peco commented on JBIDE-4655: -------------------------------------- The m2eclipse teem seems to fix https://issues.sonatype.org/browse/MNGECLIPSE-1564 in M2Eclipse 0.9.9.20090820 ( the latest build on http://m2eclipse.sonatype.org/update-dev/). Now I can configure the mavenized booking example to work in JBDS 2.0/2.1 and in JBT 3.0/3.1. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-4655?page=com.atlassian.jira.plu... ] Denis Golovin commented on JBIDE-4655: -------------------------------------- It should be updated in releng, now it uses m2eclipse-0.9.9.200907071528.zip -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira