[ http://jira.jboss.com/jira/browse/JBDS-259?page=all ] Andy Conn updated JBDS-259: --------------------------- Attachment: template.xhtml menu.xhtml display.xhtml -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBDS-259?page=comments#action_12401691 ] Snjezana Peco commented on JBDS-259: ------------------------------------ I can reproduce this case (including note 2) in JBoss Tools 2.0.0 The issue doesn't exist in the latest CVS. it has been fixed within JBIDE-1105. However, there is a memory leak when entering some jsf html tag (<h:form>, for instance). The memory is released when clicking Refresh or closing the editor. This leak is caused by the VpePageContext.addBundleDependency(Element sourceNode) method. The Element class doesn't implement equals/hashCode and the bundleDependencySet set will be continuously increasing until the user clicks Refresh or closes the editor (calling the VpeVisualDomBuilder.rebuildDom() method). Attached is a patch for this issue. I have also noticed that there is a leak when dragging an element from the palette to the source editor. I haven't found a test case for this issue yet, but will try to find and fix it. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBIDE-1896?page=all ] Max Andersen moved JBDS-259 to JBIDE-1896: ------------------------------------------ Project: Tools (JBoss Tools) (was: Developer Studio) Key: JBIDE-1896 (was: JBDS-259) Component/s: Visual Page Editor (was: visualeditor) Affects Version/s: 2.0.0.GA (was: 1.0.0.GA) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBIDE-1896?page=comments#action_12402592 ] Snjezana Peco commented on JBIDE-1896: -------------------------------------- You can reproduce this issue in the following way: - create some JSF project - add the attached edit.xhtml file to the WebContent/layout directory - add the attached test.xhtml file to the WebContent directory - try to add <h:form></h:form> around line 290, after <h:commandLink> Editing is slow. I have found two ways to speed up this editing: 1) In the VpeDefineContainerTemplate class, a file that is defined in <ui:define>, is opened for reading and closed every time it is accessed. A similar issue is described in http://jira.jboss.com/jira/browse/JBIDE-1105#action_12394448, issue 3. The attached patch fixes this issue as well and contains the memory leak patch from the previous comment (http://jira.jboss.com/jira/browse/JBIDE-1896#action_12401691). This speeds up editing the file about 3 times. 2) The <h:form> tag contains a lot of children.This node (or some other node that contains a lot of children) can be splited into sections using the <div> tag. Attached is the testdiv.xhtml file to illustrate this case. Editing is very fast with no delay. Users can split a node into sections manually (Andy, you can try this within JBoss Tools 2.0.0/JBDS 1.0). We can also automatically split big nodes into sections. I suppose that there is the same issue in the VpeCreatorUtil.getFacetType() method that calls the getModelForRead/releaseFromRead methods. I will try to find a test case. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBIDE-1896?page=comments#action_12403920 ] Snjezana Peco commented on JBIDE-1896: -------------------------------------- I have tested the VPE editor for memory leaks. The following functions have been tested: - opening and closing the editor - editing and CA - editing and D&D from the Palette view - editing within the Properties view - the Outline View I have found and fixed several memory leaks. 1) IDropCommand adds the DropData class to the execute (DropData data) method, but doesn't clear it. 2) The ValueHelper class is created in different places in the code. It contains a reference to the visualEditor and sometimes causes leaks. I have changed that code in order this class to be used as a local variable. 3) Wizards of the type IDropWizard register the PropertyChangeListener class, but don't remove it. 4) The TagAttributeWizardPage class registers PropertyChangeListener and 2 selection listeners, but doesn't remove them. 5) TagAttributeComposite registers PropertyChangeListener and doesn't remove it. 6) The ConfigurableContentOutlinePage.dispose() method calls setConfiguration(NULL_CONFIGURATION) (line 412) This method tries to remove keyListener (line 506), DragSourceListener (lines 534-543) and DropTargetListener (lines 544-553). Because the control, fDragSource and fDropTarget widgets have already been disposed, these listeners aren't removed. Since this is a bug in the Web Tools project, one way to fix it would be to copy the class and fix removing these listeners. 7) WTPTextJspKbConnector (line 85) registers a node adapter, but doesn't remove it. 8) Line 133 in the XulRunnerEditor // getWebBrowser().removeWebBrowserListener(XulRunnerEditor.this, nsIWebProgressListener.NS_IWEBPROGRESSLISTENER_IID); is commented because it doesn't work on Mac. I have replaced the code with: if (!Platform.getOS().equals(Platform.OS_MACOSX)) { nsIServiceManager serviceManager = Mozilla.getInstance().getServiceManager(); nsIWebProgress webProgress = (nsIWebProgress) serviceManager .getServiceByContractID(&quot;(a)mozilla.org/docloaderservice;1&quot;, // $NON-NLS-1$ nsIWebProgress.NS_IWEBPROGRESS_IID); webProgress.removeProgressListener(XulRunnerEditor.this); } in order the listener to be removed on Linux and Windows. Since the way of adding this listener has been changed within JBIDE-1329, it is possible that the new code works on Mac as well. 9) The VPE editor's objects aren't released when using the following case scenario: - close all editors - open some file in the VPE editor - select some attribute in the Properties view (it can be an attribute of some object from the Package Explorer view) - close the editor without activating it The editor's objects will be released by opening some new editor which doesn't have to be the VPE editor. This happens because global actions (Save, SaveAs, etc) aren't deactivated when closing the editor. This behavior is the same for any editor (Java editor, for instance). In my opinion, this is a minor issue. The changes are in the following plugins: org.jboss.tools.common.model.ui org.jboss.tools.jst.jsp org.jboss.tools.jsf.ui org.jboss.tools.vpe org.jboss.tools.vpe.xulrunner There are some more issues (AttributeDescriptor objects are leaked sometimes, an issue in the VpeCreatorUtil.getFacetType() method ...). It would be good to commit the above mentioned changes before fixing the issues with AttributeDescriptor, VpeCreatorUtil.getFacetType()... -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBIDE-1896?page=all ] Max Andersen updated JBIDE-1896: -------------------------------- Assignee: Snjezana Peco (was: Max Andersen) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBIDE-1896?page=all ] Snjezana Peco resolved JBIDE-1896. ---------------------------------- Fix Version/s: 2.1 (was: 2.2.x) Resolution: Done I haven't entered a bug yet into the webtools project. I have checked their HEAD. The bug still exists. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira