10:55 p.m.
New decorator from existing Web Bean
------------------------------------
Key: JBIDE-3136
URL: https://jira.jboss.org/jira/browse/JBIDE-3136
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: webbeans
Reporter: Dan Allen
Fix For: LATER
Suppose we have an interface that represents accounts:
public interface Account {
public BigDecimal getBalance();
public User getOwner();
public void withdraw(BigDecimal amount);
public void deposit(BigDecimal amount);
}
A decorator is a simple Web Bean that implements the type it decorates and is annotated
@Decorator.
@Decorator
public abstract class LargeTransactionDecorator
implements Account {
@Decorates Account account;
@PersistenceContext EntityManager em;
public void withdraw(BigDecimal amount) {
account.withdraw(amount);
if ( amount.compareTo(LARGE_AMOUNT)>0 ) {
em.persist( new LoggedWithdrawl(amount) );
}
}
public void deposit(BigDecimal amount);
account.deposit(amount);
if ( amount.compareTo(LARGE_AMOUNT)>0 ) {
em.persist( new LoggedDeposit(amount) );
}
}
}
The tooling would not only help you create the class that acts as the decorator, but make
sure that it implements the same interfaces as the Web Beans and injects the Web Bean into
a @Decorate field.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:57 p.m.
New subject: [JBoss JIRA] Updated: (JBIDE-3136) New decorator from existing Web Bean
[
https://jira.jboss.org/jira/browse/JBIDE-3136?page=com.atlassian.jira.plu...
]
Dan Allen updated JBIDE-3136:
-----------------------------
Description:
Suppose we have an interface that represents accounts:
public interface Account {
public BigDecimal getBalance();
public User getOwner();
public void withdraw(BigDecimal amount);
public void deposit(BigDecimal amount);
}
A decorator is a simple Web Bean that implements the type it decorates and is annotated
@Decorator.
@Decorator
public abstract class LargeTransactionDecorator
implements Account {
@Decorates Account account;
@PersistenceContext EntityManager em;
public void withdraw(BigDecimal amount) {
account.withdraw(amount);
if ( amount.compareTo(LARGE_AMOUNT)>0 ) {
em.persist( new LoggedWithdrawl(amount) );
}
}
public void deposit(BigDecimal amount);
account.deposit(amount);
if ( amount.compareTo(LARGE_AMOUNT)>0 ) {
em.persist( new LoggedDeposit(amount) );
}
}
}
The tooling would not only help you create the class that acts as the decorator, but make
sure that it implements the same interfaces as the Web Beans and injects the Web Bean into
a @Decorates field.
was:
Suppose we have an interface that represents accounts:
public interface Account {
public BigDecimal getBalance();
public User getOwner();
public void withdraw(BigDecimal amount);
public void deposit(BigDecimal amount);
}
A decorator is a simple Web Bean that implements the type it decorates and is annotated
@Decorator.
@Decorator
public abstract class LargeTransactionDecorator
implements Account {
@Decorates Account account;
@PersistenceContext EntityManager em;
public void withdraw(BigDecimal amount) {
account.withdraw(amount);
if ( amount.compareTo(LARGE_AMOUNT)>0 ) {
em.persist( new LoggedWithdrawl(amount) );
}
}
public void deposit(BigDecimal amount);
account.deposit(amount);
if ( amount.compareTo(LARGE_AMOUNT)>0 ) {
em.persist( new LoggedDeposit(amount) );
}
}
}
The tooling would not only help you create the class that acts as the decorator, but make
sure that it implements the same interfaces as the Web Beans and injects the Web Bean into
a @Decorate field.
New decorator from existing Web Bean
------------------------------------
Key: JBIDE-3136
URL: https://jira.jboss.org/jira/browse/JBIDE-3136
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: webbeans
Reporter: Dan Allen
Fix For: LATER
Suppose we have an interface that represents accounts:
public interface Account {
public BigDecimal getBalance();
public User getOwner();
public void withdraw(BigDecimal amount);
public void deposit(BigDecimal amount);
}
A decorator is a simple Web Bean that implements the type it decorates and is annotated
@Decorator.
@Decorator
public abstract class LargeTransactionDecorator
implements Account {
@Decorates Account account;
@PersistenceContext EntityManager em;
public void withdraw(BigDecimal amount) {
account.withdraw(amount);
if ( amount.compareTo(LARGE_AMOUNT)>0 ) {
em.persist( new LoggedWithdrawl(amount) );
}
}
public void deposit(BigDecimal amount);
account.deposit(amount);
if ( amount.compareTo(LARGE_AMOUNT)>0 ) {
em.persist( new LoggedDeposit(amount) );
}
}
}
The tooling would not only help you create the class that acts as the decorator, but make
sure that it implements the same interfaces as the Web Beans and injects the Web Bean into
a @Decorates field.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:18 p.m.
New subject: [JBoss JIRA] Commented: (JBIDE-3136) New decorator from existing Web Bean
[
https://jira.jboss.org/jira/browse/JBIDE-3136?page=com.atlassian.jira.plu...
]
Dan Allen commented on JBIDE-3136:
----------------------------------
My focus is on getting that @Decorates field created at the time the class is created
through the use of an Eclipse form. It's also I think about raising awareness for the
decorator.
So the idea would be, I have a Web Bean open and a right click on an interface and say
"create decorator for interface". Then I get the standard class-from-interface
dialogs. But when the class is created, it has a
@Decorates field that matches the Web Bean I had opened. Perhaps I can even pick which
methods I want to decorate and the body is filled out with a call to the target method.
New decorator from existing Web Bean
------------------------------------
Key: JBIDE-3136
URL: https://jira.jboss.org/jira/browse/JBIDE-3136
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: webbeans
Reporter: Dan Allen
Fix For: LATER
Suppose we have an interface that represents accounts:
public interface Account {
public BigDecimal getBalance();
public User getOwner();
public void withdraw(BigDecimal amount);
public void deposit(BigDecimal amount);
}
A decorator is a simple Web Bean that implements the type it decorates and is annotated
@Decorator.
@Decorator
public abstract class LargeTransactionDecorator
implements Account {
@Decorates Account account;
@PersistenceContext EntityManager em;
public void withdraw(BigDecimal amount) {
account.withdraw(amount);
if ( amount.compareTo(LARGE_AMOUNT)>0 ) {
em.persist( new LoggedWithdrawl(amount) );
}
}
public void deposit(BigDecimal amount);
account.deposit(amount);
if ( amount.compareTo(LARGE_AMOUNT)>0 ) {
em.persist( new LoggedDeposit(amount) );
}
}
}
The tooling would not only help you create the class that acts as the decorator, but make
sure that it implements the same interfaces as the Web Beans and injects the Web Bean into
a @Decorates field.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:02 a.m.
New subject: [JBoss JIRA] Commented: (JBIDE-3136) New decorator from existing Web Bean
[
https://jira.jboss.org/jira/browse/JBIDE-3136?page=com.atlassian.jira.plu...
]
Max Rydahl Andersen commented on JBIDE-3136:
--------------------------------------------
Thanks for the examples - makes it much easier to relate ;)
It is definitly possible to create a "New Decorator wizard" that will pick up
the current selection and add the Decorates field.
Alternatively we could just let users use the default "implement interface"
wizard and have a refactor operation that checks that the class fullfill the Decorator
needs and if somethings are missing add them (i.e. @Decorator and @Decorates)
New decorator from existing Web Bean
------------------------------------
Key: JBIDE-3136
URL: https://jira.jboss.org/jira/browse/JBIDE-3136
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: webbeans
Reporter: Dan Allen
Fix For: LATER
Suppose we have an interface that represents accounts:
public interface Account {
public BigDecimal getBalance();
public User getOwner();
public void withdraw(BigDecimal amount);
public void deposit(BigDecimal amount);
}
A decorator is a simple Web Bean that implements the type it decorates and is annotated
@Decorator.
@Decorator
public abstract class LargeTransactionDecorator
implements Account {
@Decorates Account account;
@PersistenceContext EntityManager em;
public void withdraw(BigDecimal amount) {
account.withdraw(amount);
if ( amount.compareTo(LARGE_AMOUNT)>0 ) {
em.persist( new LoggedWithdrawl(amount) );
}
}
public void deposit(BigDecimal amount);
account.deposit(amount);
if ( amount.compareTo(LARGE_AMOUNT)>0 ) {
em.persist( new LoggedDeposit(amount) );
}
}
}
The tooling would not only help you create the class that acts as the decorator, but make
sure that it implements the same interfaces as the Web Beans and injects the Web Bean into
a @Decorates field.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:37 a.m.
New subject: [JBoss JIRA] Updated: (JBIDE-3136) New decorator from existing Web Bean
[
https://jira.jboss.org/browse/JBIDE-3136?page=com.atlassian.jira.plugin.s...
]
Viacheslav Kabanovich updated JBIDE-3136:
-----------------------------------------
Fix Version/s: 3.2.0.M2
(was: LATER)
New decorator from existing Web Bean
------------------------------------
Key: JBIDE-3136
URL: https://jira.jboss.org/browse/JBIDE-3136
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: cdi (jsr-299)
Reporter: Dan Allen
Assignee: Viacheslav Kabanovich
Fix For: 3.2.0.M2
Suppose we have an interface that represents accounts:
public interface Account {
public BigDecimal getBalance();
public User getOwner();
public void withdraw(BigDecimal amount);
public void deposit(BigDecimal amount);
}
A decorator is a simple Web Bean that implements the type it decorates and is annotated
@Decorator.
@Decorator
public abstract class LargeTransactionDecorator
implements Account {
@Decorates Account account;
@PersistenceContext EntityManager em;
public void withdraw(BigDecimal amount) {
account.withdraw(amount);
if ( amount.compareTo(LARGE_AMOUNT)>0 ) {
em.persist( new LoggedWithdrawl(amount) );
}
}
public void deposit(BigDecimal amount);
account.deposit(amount);
if ( amount.compareTo(LARGE_AMOUNT)>0 ) {
em.persist( new LoggedDeposit(amount) );
}
}
}
The tooling would not only help you create the class that acts as the decorator, but make
sure that it implements the same interfaces as the Web Beans and injects the Web Bean into
a @Decorates field.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:37 a.m.
New subject: [JBoss JIRA] Updated: (JBIDE-3136) New decorator from existing Web Bean
[
https://jira.jboss.org/browse/JBIDE-3136?page=com.atlassian.jira.plugin.s...
]
Viacheslav Kabanovich updated JBIDE-3136:
-----------------------------------------
Labels: new_and_noteworthy (was: )
New decorator from existing Web Bean
------------------------------------
Key: JBIDE-3136
URL: https://jira.jboss.org/browse/JBIDE-3136
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: cdi (jsr-299)
Reporter: Dan Allen
Assignee: Viacheslav Kabanovich
Fix For: 3.2.0.M2
Suppose we have an interface that represents accounts:
public interface Account {
public BigDecimal getBalance();
public User getOwner();
public void withdraw(BigDecimal amount);
public void deposit(BigDecimal amount);
}
A decorator is a simple Web Bean that implements the type it decorates and is annotated
@Decorator.
@Decorator
public abstract class LargeTransactionDecorator
implements Account {
@Decorates Account account;
@PersistenceContext EntityManager em;
public void withdraw(BigDecimal amount) {
account.withdraw(amount);
if ( amount.compareTo(LARGE_AMOUNT)>0 ) {
em.persist( new LoggedWithdrawl(amount) );
}
}
public void deposit(BigDecimal amount);
account.deposit(amount);
if ( amount.compareTo(LARGE_AMOUNT)>0 ) {
em.persist( new LoggedDeposit(amount) );
}
}
}
The tooling would not only help you create the class that acts as the decorator, but make
sure that it implements the same interfaces as the Web Beans and injects the Web Bean into
a @Decorates field.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:39 a.m.
New subject: [JBoss JIRA] Resolved: (JBIDE-3136) New decorator from existing Web Bean
[
https://jira.jboss.org/browse/JBIDE-3136?page=com.atlassian.jira.plugin.s...
]
Viacheslav Kabanovich resolved JBIDE-3136.
------------------------------------------
Resolution: Done
New decorator from existing Web Bean
------------------------------------
Key: JBIDE-3136
URL: https://jira.jboss.org/browse/JBIDE-3136
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: cdi (jsr-299)
Reporter: Dan Allen
Assignee: Viacheslav Kabanovich
Fix For: 3.2.0.M2
Suppose we have an interface that represents accounts:
public interface Account {
public BigDecimal getBalance();
public User getOwner();
public void withdraw(BigDecimal amount);
public void deposit(BigDecimal amount);
}
A decorator is a simple Web Bean that implements the type it decorates and is annotated
@Decorator.
@Decorator
public abstract class LargeTransactionDecorator
implements Account {
@Decorates Account account;
@PersistenceContext EntityManager em;
public void withdraw(BigDecimal amount) {
account.withdraw(amount);
if ( amount.compareTo(LARGE_AMOUNT)>0 ) {
em.persist( new LoggedWithdrawl(amount) );
}
}
public void deposit(BigDecimal amount);
account.deposit(amount);
if ( amount.compareTo(LARGE_AMOUNT)>0 ) {
em.persist( new LoggedDeposit(amount) );
}
}
}
The tooling would not only help you create the class that acts as the decorator, but make
sure that it implements the same interfaces as the Web Beans and injects the Web Bean into
a @Decorates field.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:24 a.m.
New subject: [JBoss JIRA] Updated: (JBIDE-3136) New decorator from existing Web Bean
[
https://jira.jboss.org/browse/JBIDE-3136?page=com.atlassian.jira.plugin.s...
]
Alexey Kazakov updated JBIDE-3136:
----------------------------------
Attachment: decorator.png
New decorator from existing Web Bean
------------------------------------
Key: JBIDE-3136
URL: https://jira.jboss.org/browse/JBIDE-3136
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: cdi (jsr-299)
Reporter: Dan Allen
Assignee: Viacheslav Kabanovich
Fix For: 3.2.0.M2
Attachments: decorator.png
Suppose we have an interface that represents accounts:
public interface Account {
public BigDecimal getBalance();
public User getOwner();
public void withdraw(BigDecimal amount);
public void deposit(BigDecimal amount);
}
A decorator is a simple Web Bean that implements the type it decorates and is annotated
@Decorator.
@Decorator
public abstract class LargeTransactionDecorator
implements Account {
@Decorates Account account;
@PersistenceContext EntityManager em;
public void withdraw(BigDecimal amount) {
account.withdraw(amount);
if ( amount.compareTo(LARGE_AMOUNT)>0 ) {
em.persist( new LoggedWithdrawl(amount) );
}
}
public void deposit(BigDecimal amount);
account.deposit(amount);
if ( amount.compareTo(LARGE_AMOUNT)>0 ) {
em.persist( new LoggedDeposit(amount) );
}
}
}
The tooling would not only help you create the class that acts as the decorator, but make
sure that it implements the same interfaces as the Web Beans and injects the Web Bean into
a @Decorates field.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:10 a.m.
New subject: [JBoss JIRA] Closed: (JBIDE-3136) New decorator from existing Web Bean
[
https://jira.jboss.org/browse/JBIDE-3136?page=com.atlassian.jira.plugin.s...
]
Lukas Jungmann closed JBIDE-3136.
---------------------------------
v. in v201008232021N-H413-M2
New decorator from existing Web Bean
------------------------------------
Key: JBIDE-3136
URL: https://jira.jboss.org/browse/JBIDE-3136
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: cdi (jsr-299)
Reporter: Dan Allen
Assignee: Viacheslav Kabanovich
Fix For: 3.2.0.M2
Attachments: decorator.png
Suppose we have an interface that represents accounts:
public interface Account {
public BigDecimal getBalance();
public User getOwner();
public void withdraw(BigDecimal amount);
public void deposit(BigDecimal amount);
}
A decorator is a simple Web Bean that implements the type it decorates and is annotated
@Decorator.
@Decorator
public abstract class LargeTransactionDecorator
implements Account {
@Decorates Account account;
@PersistenceContext EntityManager em;
public void withdraw(BigDecimal amount) {
account.withdraw(amount);
if ( amount.compareTo(LARGE_AMOUNT)>0 ) {
em.persist( new LoggedWithdrawl(amount) );
}
}
public void deposit(BigDecimal amount);
account.deposit(amount);
if ( amount.compareTo(LARGE_AMOUNT)>0 ) {
em.persist( new LoggedDeposit(amount) );
}
}
}
The tooling would not only help you create the class that acts as the decorator, but make
sure that it implements the same interfaces as the Web Beans and injects the Web Bean into
a @Decorates field.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5726
days inactive
6383
days old
jbosstools-issues@lists.jboss.org
8 comments
5 participants
participants (5)
-
Alexey Kazakov (JIRA) -
Dan Allen (JIRA)
-
Lukas Jungmann (JIRA)
-
Max Rydahl Andersen (JIRA)
-
Viacheslav Kabanovich (JIRA)