[ https://issues.jboss.org/browse/JBDS-1602?page=com.atlassian.jira.plugin.... ] Bill Meyer updated JBDS-1602: ----------------------------- Attachment: Jira - JBDS-1602.zip JBDS Project file containing the example Web Service -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBDS-1602?page=com.atlassian.jira.plugin.... ] Brian Fitzpatrick commented on JBDS-1602: ----------------------------------------- Thanks Bill. I'll take a look and get back to you. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBDS-1602?page=com.atlassian.jira.plugin.... ] Brian Fitzpatrick commented on JBDS-1602: ----------------------------------------- I am able to reproduce this even on a SOA-P 5.1 runtime, so you definitely found an interesting bug. I'll see if I can figure out what's going on. I've used many different services and not hit this one before, so I'm not sure what's up. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBDS-1602?page=com.atlassian.jira.plugin.... ] Brian Fitzpatrick commented on JBDS-1602: ----------------------------------------- Lukas, I can't get your patch to work with either the 3.2.x branch or trunk. Can you resync and recreate it? -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBDS-1602?page=com.atlassian.jira.plugin.... ] Lukas Jungmann edited comment on JBDS-1602 at 4/12/11 3:09 PM: --------------------------------------------------------------- The problem here is that tester does not handle XML schema's elementFormDefault attribute correctly. Currently it generates: ... <soap:Body> <getStockQuoteBySymbol xmlns = "http://www.jboss.com/webservices/StockQuoteService"> <arg0>?</arg0> </getStockQuoteBySymbol> </soap:Body> ... which is wrong since according to xml namespace inheritance rules - if I understand them correctly - arg0 element belongs to "http://www.jboss.com/webservices/StockQuoteService" namespace whereas in xml schema, there is defined that it should be in default/no namespace (some ws-stacks with disabled(?) xml message validation can handle this) For elementFormDefault="unqualified" (default value) the generated message should be: ... <soap:Body> <ns1:getStockQuoteBySymbol xmlns:ns1 = "http://www.jboss.com/webservices/StockQuoteService"> <arg0>?</arg0> </ns1:getStockQuoteBySymbol> </soap:Body> ... and for elementFormDefault="qualified" it should be: ... <soap:Body> <ns1:getStockQuoteBySymbol xmlns:ns1 = "http://www.jboss.com/webservices/StockQuoteService"> <ns1:arg0>?</ns1:arg0> </ns1:getStockQuoteBySymbol> </soap:Body> ... I attached a patch which should fix this issue for WSDL files I have around (contains also a fix for test, which needs to be applied). There are still these TODO's: 1) I did not touch code where I can not get (in the other words only code I know I can reach was fixed - code coverage was used to find such code) 2) it may happen that message contains elements from more than one namespace - attached patch assumes that there's only one namespace (test case is needed for fixing this) 3) usage of XML Schema's attributeFormDefault attribute may cause similar issue - attached patch does not take this into account was (Author: jlukas): The problem here is that tester does not handle XML schema's elementFormDefault attribute correctly. Currently it generates: ... <soap:Body> <getStockQuoteBySymbol xmlns = "http://www.jboss.com/webservices/StockQuoteService"> <arg0>?</arg0> </getStockQuoteBySymbol> </soap:Body> ... which is wrong since according to xml namespace inheritance rules arg0 element belongs to "http://www.jboss.com/webservices/StockQuoteService" namespace whereas in xml schema, there is defined that it should be in default/no namespace (some ws-stacks with disabled(?) xml message validation can handle this) For elementFormDefault="unqualified" (default value) the generated message should be: ... <soap:Body> <ns1:getStockQuoteBySymbol xmlns:ns1 = "http://www.jboss.com/webservices/StockQuoteService"> <arg0>?</arg0> </ns1:getStockQuoteBySymbol> </soap:Body> ... and for elementFormDefault="qualified" it should be: ... <soap:Body> <ns1:getStockQuoteBySymbol xmlns:ns1 = "http://www.jboss.com/webservices/StockQuoteService"> <ns1:arg0>?</ns1:arg0> </ns1:getStockQuoteBySymbol> </soap:Body> ... I attached a patch which should fix this issue for WSDL files I have around (contains also a fix for test, which needs to be applied). There are still these TODO's: 1) I did not touch code where I can not get (in the other words only code I know I can reach was fixed - code coverage was used to find such code) 2) it may happen that message contains elements from more than one namespace - attached patch assumes that there's only one namespace (test case is needed for fixing this) 3) usage of XML Schema's attributeFormDefault attribute may cause similar issue - attached patch does not take this into account -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBDS-1602?page=com.atlassian.jira.plugin.... ] Brian Fitzpatrick updated JBDS-1602: ------------------------------------ Attachment: testerutils.diff -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBDS-1602?page=com.atlassian.jira.plugin.... ] Lukas Jungmann commented on JBDS-1602: -------------------------------------- Yes, it handles one level of namespace prefix - item 2 in the todo list from my last comment. If Bill doesn't have something for us to test, I prepare some test case tomorrow. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBDS-1602?page=com.atlassian.jira.plugin.... ] Brian Fitzpatrick commented on JBDS-1602: ----------------------------------------- Lukas, this is what soapUI spits out for that wsdl in jbds1602.jb. This looks a bit different than your example... <soapenv:Envelope xmlns:soapenv="http://schemas.xmlsoap.org/soap/envelope/" xmlns:test="http://test/" xmlns:x="http://example.com/attr/x" xmlns:y="http://example.com/attr/y" xmlns:a="http://example.com/ws/a" xmlns:b="http://example.com/ws/b" xmlns:oth="http://example.com/ws/other" xmlns:oth1="http://example.com/attr/other"> <soapenv:Header/> <soapenv:Body> <test:echo> <!--Optional:--> <test:arg0 x:C="?" y:D="?"> <a:A>?</a:A> <b:B>?</b:B> <!--Optional:--> <oth:OtherType oth1:myid="?" x:Y="?"> <!--Optional:--> <b:description>?</b:description> </oth:OtherType> </test:arg0> </test:echo> </soapenv:Body> </soapenv:Envelope> -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBDS-1602?page=com.atlassian.jira.plugin.... ] Brian Fitzpatrick commented on JBDS-1602: ----------------------------------------- Ok. I'm getting closer to a solution for the multiple NS's, but am not quite there yet. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBDS-1602?page=com.atlassian.jira.plugin.... ] Brian Fitzpatrick commented on JBDS-1602: ----------------------------------------- I am continuing to work on this and hope to have something by the 3.2.1 CR1 milestone. If not, it will have to be pushed to the 3.3 version. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBDS-1602?page=com.atlassian.jira.plugin.... ] Lukas Jungmann commented on JBDS-1602: -------------------------------------- I think it's OK to generate the namespace prefix on its first use basis (like you have it now) btw: it should be easy to resolve also (related) JBIDE-8770 now ;-) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBDS-1602?page=com.atlassian.jira.plugin.... ] Brian Fitzpatrick commented on JBDS-1602: ----------------------------------------- Ok... I think I have this working much better now, though it still doesn't handle the extremely ugly Ebay WSDL well. For the sample with all the ugly namespaces and nested/mixed schemas, I now generate this: <?xml version="1.0" encoding="utf-8" standalone="yes" ?> <soap:Envelope xmlns:soap="http://schemas.xmlsoap.org/soap/envelope/" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema" > <soap:Header> </soap:Header> <soap:Body> <test:echo xmlns:test="http://test/"> <!-- optional --> <test:arg0 xmlns:x="http://example.com/attr/x" x:C="?" xmlns:y="http://example.com/attr/y" y:D="?" > <a:A xmlns:a="http://example.com/ws/a">?</a:A> <b:B xmlns:b="http://example.com/ws/b">?</b:B> <!-- optional --> <othe:OtherType xmlns:othe="http://example.com/attr/other" othe:myid="?" x:Y="?" > <!-- optional --> <b:description>?</b:description> </othe:OtherType> </test:arg0> </test:echo> </soap:Body> </soap:Envelope> And the original WSDL reported for this JIRA looks like this now: <?xml version="1.0" encoding="utf-8" standalone="yes" ?> <soap:Envelope xmlns:soap="http://schemas.xmlsoap.org/soap/envelope/" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema" > <soap:Header> </soap:Header> <soap:Body> <stoc:getStockQuoteBySymbol xmlns:stoc="http://www.jboss.com/webservices/StockQuoteService"... <!-- optional --> <arg0>?</arg0> </stoc:getStockQuoteBySymbol> </soap:Body> </soap:Envelope> And the parts.wsdl associated with JBIDE-8770 looks like this with the SOAP header: <?xml version="1.0" encoding="utf-8" standalone="yes" ?> <soap:Envelope xmlns:soap="http://schemas.xmlsoap.org/soap/envelope/" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema" > <soap:Header> <squa:storeHeader xmlns:squa="http://www.example.org/ws/square/"> <id>?</id> <timestamp>?</timestamp> </squa:storeHeader> </soap:Header> <soap:Body> <basi:operationRequest xmlns:basi="http://www.example.org/ws/basic/"> <a>?</a> <b>?</b> </basi:operationRequest> </soap:Body> </soap:Envelope> -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBDS-1602?page=com.atlassian.jira.plugin.... ] Brian Fitzpatrick commented on JBDS-1602: ----------------------------------------- This is not a minor refit to the utility class formerly used to generate the sample request message. Instead, I gutted the older utility class and started from scratch, utilizing a few classes from the Web Services Explorer in WTP to help with processing embedded schemas and namespaces. As such, I'm not so sure this should be a fix for JBT 3.2.1 (JBDS 4.1) or JBT 3.3 (JBDS 5). I suspect there are too many changes in this patch to really use it in JBDS 4.1. However, it seems to fix JBDS-1602, JBIDE-8770, and the intermittent issue with the timer thread NPE. I should be able to modify the patch to work in JBDS 4.1 with minor tweaks... -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBDS-1602?page=com.atlassian.jira.plugin.... ] Brian Fitzpatrick updated JBDS-1602: ------------------------------------ Attachment: JBDS41.patch -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBDS-1602?page=com.atlassian.jira.plugin.... ] Brian Fitzpatrick updated JBDS-1602: ------------------------------------ Labels: new_and_noteworthy (was: ) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBDS-1602?page=com.atlassian.jira.plugin.... ] Brian Fitzpatrick resolved JBDS-1602. ------------------------------------- Resolution: Done -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira