[ http://jira.jboss.com/jira/browse/JBIDE-1771?page=comments#action_12399355 ] Anton Klimkovich commented on JBIDE-1771: ----------------------------------------- Reproduced in JBossTools-200802120240-nightly-ALL. "Curent text selection doesn't resolve to a file" message appeares instead of openning new editor with defined schema . Testcase1: EXECUTE: Create JSF 1.2 KickStart project EXECUTE: Open faces-config.xml EXECUTE: Make OpeOn on value of attribute xsi:schemaLocation ASSERT: Defined schema should be opened in a new editor. Testcase2: EXECUTE: Create JSF 1.1 KickStart project EXECUTE: Open faces-config.xml EXECUTE: Make OpeOn on "http://java.sun.com/dtd/web-facesconfig_1_1.dtd" ASSERT: Defined schema should be opened in a new editor. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBIDE-1771?page=comments#action_12405667 ] Snjezana Peco commented on JBIDE-1771: -------------------------------------- There are two issues related to this bug. The catalog directory of the org.jboss.tools.jst.web plugin isn't included in a build (see JBIDE-1971). Another issue is that the catalogContributions extension point isn't valid for a JSF configuration file. org.jboss.tools.jst.web/plugin.xml <extension point="org.eclipse.wst.xml.core.catalogContributions"> <catalogContribution id="default"> <uri name="http://java.sun.com/xml/ns/javaee/web-facesconfig_1_2.xsd" uri="catalog/web-facesconfig_1_2.xsd" /> <uri name="http://java.sun.com/xml/ns/javaee/" uri="catalog/javaee_5.xsd" /> </catalogContribution> </extension> should be replaced with: <extension point="org.eclipse.wst.xml.core.catalogContributions"> <catalogContribution id="default"> <uri name="http://www.w3.org/2001/XMLSchema-instance" uri="catalog/web-facesconfig_1_2.xsd" /> <uri name="http://java.sun.com/xml/ns/javaee/" uri="catalog/javaee_5.xsd" /> </catalogContribution> </extension> -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBIDE-1771?page=all ] Max Andersen updated JBIDE-1771: -------------------------------- Fix Version/s: LATER -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBIDE-1771?page=comments#action_12405929 ] Max Andersen commented on JBIDE-1771: ------------------------------------- I was using JBDS 1.0.0.GA which is probably affected by JBIDE-1971 and schemas are thus not in the build...but will work when running from a development runtime. btw. the fun thing is that in JBDS 1.0.GA the 2 urls in schemaLocation is highlighted independently where as when snjezana runs the latest svn the whole attribute gets highlighted....we are getting really different behaviors here. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBIDE-1771?page=comments#action_12405952 ] Victor Rubezhny commented on JBIDE-1771: ---------------------------------------- Max, Snjezana! Could you provide a screenshot where you have the following situation in JBDS 1.0.0 GA: "btw. the fun thing is that in JBDS 1.0.GA the 2 urls in schemaLocation is highlighted independently where as when snjezana runs the latest svn the whole attribute gets highlighted....we are getting really different behaviors here." My OpenOn highlights the whole attribute value, so if the URI's are highlighted separately then my OpenOn is not invoked at all. It seemed for me that I've fixed such kind of bug already... -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBIDE-1771?page=all ] Snjezana Peco updated JBIDE-1771: --------------------------------- Attachment: JBDSnightlyBuildAndCurrentSvn.gif -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBIDE-1771?page=comments#action_12406005 ] Victor Rubezhny commented on JBIDE-1771: ---------------------------------------- Max, and how these URIs are to be processed in this case? As a system ID (and when selected the OpenOn should find the appropriate file in the XMLLatalog) and as public ID (and when selected the OpenOn should open the URL in web-browser)... But the schema is to be the same for the pair of system/public ID... Seems that I misunderstand something... If you're right we have to have to cases when Ctrl-clicking on the two parts of the xsi:schemaLocation: 1. when ctrl-clicking on the first part (http://java.sun.com/xml/ns/javaee) the XMLCatalog is to be searched for the schema (JBDS 1.0.0 GA will not find any schemas as it doesn't have a catalog. The latest SVN version will find a schema in catalog) 2. when ctrl-clicking on the second part (http://java.sun.com/xml/ns/javaee/web-facesconfig_1_2.xsd) the URL is to be openned in web-browser (For both: JBDS 1.0.0 GA and the latest SVN version. The XMLCatalog is not to be searched in) What is the right algorithm to be used here? Snjezana, in the screenshot attached I see the whole xsi:schemaLocation attribute value is underlined. Is it from JBDS 1.0.0 GA or from the latest SVN? (The picture is how it forks for me in the latest SVN version) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBIDE-1771?page=comments#action_12406085 ] Max Andersen commented on JBIDE-1771: ------------------------------------- As far as I see it whatever was enabled in JBDS 1.0.0 GA/JBossTools 2.0.0 GA was doing the correct thing ...except for the " at the end. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBIDE-1771?page=comments#action_12406112 ] Max Andersen commented on JBIDE-1771: ------------------------------------- Victor, yes I know it was not our bug but the highlighting were working as expected, one url at the time. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBIDE-1771?page=comments#action_12406164 ] Max Andersen commented on JBIDE-1771: ------------------------------------- The best explanation i found for schemaLocation was http://msdn2.microsoft.com/en-us/library/ms256100.aspx Thus you can have multiple pairs and even also a single element pointing to a schema. As far as I understand the first tuple in a pair is the namespace id - that is a *possible* web remote location. So yes, opening a browser on this makes sense. The second tuple is a *hint* to the xsd validator/parser on where the physical schema that should be used is actually located. This can be both a local (e.g., canonical: "c:/myschema.xsd" or relative to the current document: "myschema.xsd") or a remote reference "http://java.sun.com/xml/ns/javaee/web-facesconfig_1_2.xsd"). Thus for this second tuple the following seem to make sense for me: 1) Look it up in the catalog contribution and see if a mapping/file exists and open it, if not skip. 2) Check if the tuple might be a local file canonical or relative to the current document, if found open - if not skip 3) If everything else fails open the location in the browser. p.s. are we sure the builtin link resolver doesn't already does the above? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-1771?page=com.atlassian.jira.plu... ] Snjezana Peco resolved JBIDE-1771. ---------------------------------- Resolution: Done Fixed in the JBoss Tools XML Editor. The issue still exists in the WTP editors: Faces Config and XML Editor, but it is a bug in WTP. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira