[ https://jira.jboss.org/browse/JBIDE-7234?page=com.atlassian.jira.plugin.s... ] Gary Brown updated JBIDE-7234: ------------------------------ Environment: JBTools 3.2.0.beta1 nightly build. Description: When generating a Java Bean skeleton web service, based on a WSDL definition, the port type implementation class has an incorrect annotation. The port type implementation has: @WebService(serviceName = "CreditAgencyInterface", endpointInterface = "org.example.purchasing.creditAgency.CreditAgencyInterface") but the interface associated with the implementation defines: @WebService(name = "CreditAgencyInterface", targetNamespace = "http://www.jboss.org/examples/creditAgency") The end result is that when accessing the WSDL for the endpoint, once deployed to the JBossAS server, the WSDL has an incorrect target namespace and service name - service name is 'CreditAgencyInterface' instead of 'CreditAgencyService', and the target namespace is autogenerated based on the Java package name of the implementation class. When the annotation in the port type implementation's annotation was changed to be: @WebService(name = "CreditAgencyInterface", serviceName="CreditAgencyService", targetNamespace="http://www.jboss.org/examples/creditAgency";, endpointInterface = "org.example.purchasing.creditAgency.CreditAgencyInterface") This fixes the serviceName attribute, and adds a 'name' attribute to be the port type. It also specifies explicitly the target namespace. Note: tried using jax-ws version 2.0 and 2.1, with same result. was: When generating a Java Bean skeleton web service, based on a WSDL definition, the port type implementation class has an incorrect annotation. The port type implementation has: @WebService(serviceName = "CreditAgencyInterface", endpointInterface = "org.example.purchasing.creditAgency.CreditAgencyInterface") but the interface associated with the implementation defines: @WebService(name = "CreditAgencyInterface", targetNamespace = "http://www.jboss.org/examples/creditAgency") The end result is that when accessing the WSDL for the endpoint, once deployed to the JBossAS server, the WSDL has an incorrect target namespace and service name - service name is 'CreditAgencyInterface' instead of 'CreditAgencyService', and the target namespace is autogenerated based on the Java package name of the implementation class. When the annotation in the port type implementation's annotation was changed to be: @WebService(name = "CreditAgencyInterface", serviceName="CreditAgencyService", targetNamespace="http://www.jboss.org/examples/creditAgency";, endpointInterface = "org.example.purchasing.creditAgency.CreditAgencyInterface") This fixes the serviceName attribute, and adds a 'name' attribute to be the port type. It also specifies explicitly the target namespace. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBIDE-7234?page=com.atlassian.jira.plugin.s... ] Lukas Jungmann commented on JBIDE-7234: --------------------------------------- - targetNamespace - the attribute is not mandatory, doesn't have to be the same as the one in endpoint interface and it is up to the developer whether he wants to set it or not in the implementation class, in any cases it is applied only to wsdl:service and associated XML elements and for the rest (wsdl:portType and associated XML elements) the targetNamespace from the service endpoint interface is used - name attribute cannot be added to @WebService in this particular case since JSR-181 explicitly states that if the ws implementation bean references a service endpoint interface, the @WebService annotation MUST NOT include the name annotation element. - see JBIDE-6495 and/or JSR-181, sect. 3.1 for more details - serviceName - used as the name of the wsdl:service, nothing more, perhaps here is some place for minor improvement All in all, current behaviour is, IMHO, expected and correct (as defined in relevant JAX-WS specifications) from tooling perspective -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBIDE-7234?page=com.atlassian.jira.plugin.s... ] Lukas Jungmann commented on JBIDE-7234: --------------------------------------- Well, I don't think WSDLs should be equivalent in terms of concrete implementation, but I can understand it may be useful if they will be. To get there, we should be generating proper default values not only for targetNamespace and serviceName attributes but also for portName. Only note that in abstract WSDLs only targetNamespace is defined (the rest will have to be "guessed") -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBIDE-7234?page=com.atlassian.jira.plugin.s... ] Brian Fitzpatrick updated JBIDE-7234: ------------------------------------- Fix Version/s: 3.2.0.Beta2 Ok, as there seems to be a workaround, I'm going to push this to the Beta2 release. Can I summarize that somehow you want the implementation class annotations to include the serviceName attribute and set the endpointInterface? So in this case: serviceName="CreditAgencyService" endpointInterface = "org.example.purchasing.creditAgency.CreditAgencyInterface" The endpointInterface is just the fully qualified class name of the interface class, so that should be easy to include. But for the serviceName, we may have to add a separate field to the JBoss Web Service Code Generation Configuration page of the wizard that currently asks for the Package name, specification level, etc. If we add a "Service name" field we might be able to come up with a suitable default for it... Lukas, any idea how we'd query the WSDL to get the service name before we start the whole JBossWS generation process? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBIDE-7234?page=com.atlassian.jira.plugin.s... ] Brian Fitzpatrick commented on JBIDE-7234: ------------------------------------------ Ok, I think I have this working. It will use the targetNamespace of the WSDL and the service name and generates this: package org.jboss.examples.creditagency; import org.jboss.examples.creditagency.CreditAgencyInterface; import javax.jws.WebService; @WebService(serviceName = "CreditAgencyService", endpointInterface = "org.jboss.examples.creditagency.CreditAgencyInterface", targetNamespace = "http://www.jboss.org/examples/creditAgency") public class CreditAgencyInterfaceImpl implements CreditAgencyInterface { public CreditCheckType checkCredit(CreditCheckType content) { return null; } } Are you at a point where you can test a patch? Or can I send you a generated project? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBIDE-7234?page=com.atlassian.jira.plugin.s... ] Brian Fitzpatrick updated JBIDE-7234: ------------------------------------- Attachment: ws.creation.core.patch -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBIDE-7234?page=com.atlassian.jira.plugin.s... ] Gary Brown commented on JBIDE-7234: ----------------------------------- Hi Brian - thanks that generated web service project worked great! -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBIDE-7234?page=com.atlassian.jira.plugin.s... ] Brian Fitzpatrick resolved JBIDE-7234. -------------------------------------- Resolution: Done -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBIDE-7234?page=com.atlassian.jira.plugin.s... ] Lukas Jungmann closed JBIDE-7234. --------------------------------- v. in jbds 4.0.0.v201011290917N-H507-Beta2 -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira