[ https://issues.jboss.org/browse/JBIDE-15597?page=com.atlassian.jira.plugi... ] Andre Dietisheim edited comment on JBIDE-15597 at 10/18/13 2:19 PM: -------------------------------------------------------------------- Hi [~mwigglesworth-redhat] I checked your branch today and merged into master. Cool to see things pretty stable and in an advanced state. When merging your reformatting in ApplicationConfigurationWizardPage (you're using 8 spaces vs. 1 tab for me for indenting) made things hard to merge. Taking the special care to ignore-whitespace helped and I could merge quite easily. I saw some minors in the UI; * Application configuration page: !app-config-page.png! ** Please include the env-var button in the advanced section. Env vars are imho an advanced topic and the page is already very crowded: ** When you import an existing application, are we populating the wizard with the existing env vars so that they are listed for an existing Application? ** When finishing the wizard, I could not spot the env vars on the app. I ssh'ed into it and printed env, none of my custom vars showed up. What am I missing? * Env var wizard: !edit-environment-variables.png! ** Please have the column headers and values left aligned. This is the default in all Eclipse. ** I'd also hide the Import/Export buttons since we dont have any functionlity for them so far: ** In this wizard we're adding/removing/editing variables, we're not talking to the backend yet. Thus It's not required to have jobs. Jobs make the wizard laggy, I'd remove them and operate on the local map without any backgroud operation (job). * Editing env vars on existing appilcations: ** We should provide the ability to add/remove/edit env vars in existing application. We're missing this right now, dont we? At least I couldnt spot any item in the OpenShift Explorer/Application context menu I wanted to push my merge into a branch that you could merge from, but I my merge was missing --rebase. This week was too exhausting for me, I had to stop here. Looking forward to get things done next week and rebase upon jbosstools-4.1.1.Beta1x. was (Author: adietish): Hi [~mwigglesworth-redhat] I checked your branch today and merged into master. Cool to see things pretty stable and in an advanced state. When merging your reformatting in ApplicationConfigurationWizardPage (you're using 8 spaces vs. 1 tab for me for indenting) made things hard to merge. Taking the special care to ignore-whitespace helped and I could merge quite easily. I saw some minors in the UI; * Application configuration page: !app-config-page.png! ** Please include the env-var button in the advanced section. Env vars are imho an advanced topic and the page is already very crowded: ** When you import an existing application, are we populating the wizard with the existing env vars so that they are listed for an existing Application? ** When finishing the wizard, I could not spot the env vars on the app. I ssh'ed into it and printed env, none of my custom vars showed up. What am I missing? * Env var wizard: !edit-environment-variables.png! ** Please have the column headers and values left aligned. This is the default in all Eclipse. ** I'd also hide the Import/Export buttons since we dont have any functionlity for them so far: ** In this wizard we're adding/removing/editing variables, we're not talking to the backend yet. Thus It's not required to have jobs. Jobs make the wizard laggy, I'd remove them and operate on the local map without any backgroud operation (job). * Editing env vars on existing appilcations: ** We should provide the ability to add/remove/edit env vars in existing application. We're missing this right now, dont we? At least I couldnt spot any item in the OpenShift Explorer/Application context menu I wanted to push my merge into a branch that you could merge from, but I my merge was missing --rebase. This week was too exhausting for me, I had to stop here. Looking forward to get things done next week and rebase upon jbosstools-4.1.x. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira