[
https://jira.jboss.org/browse/JBIDE-6403?page=com.atlassian.jira.plugin.s...
]
Vitali Yemialyanchyk resolved JBIDE-6403.
-----------------------------------------
Resolution: Done
I revert my change with thread class loader back.
here is fragment from our discussion:
vy:
> .. why this is not acceptable ..
max:
> .. it should load from the classloader that we will throw out not
the eclipse based one ..
vy:
> can you explain me this hypothetic situation:
> is a 3rd party plugin - is it right: if I call from my thread some eclipse code -
> there is no chance to call some code from 3rd party plugin in context of the same
thread?
max:
> not unless someone calls that 3rd party code
so the issue fixed.
Some refactoring in ConsoleConfiguration class
----------------------------------------------
Key: JBIDE-6403
URL:
https://jira.jboss.org/browse/JBIDE-6403
Project: Tools (JBoss Tools)
Issue Type: Task
Components: Hibernate
Affects Versions: 3.2.x
Reporter: Vitali Yemialyanchyk
Assignee: Vitali Yemialyanchyk
Priority: Optional
Fix For: 3.2.0.M1
Attachments: JBIDE-6403_JUnit_test_patch.txt
I propose two things to adjust in this class:
1) separate/move code for creation hibernate Configuration into other class - so
we'll get two 400 lines classes instead of one 800 with more clear logic;
2) replace Thread.currentThread().getContextClassLoader() with
ConsoleConfiguration.class.getClassLoader() - so imo we get more safe code;
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira