[ https://issues.jboss.org/browse/JBIDE-13636?page=com.atlassian.jira.plugi... ] Viacheslav Kabanovich edited comment on JBIDE-13636 at 2/25/13 6:40 PM: ------------------------------------------------------------------------ I have attached StrutsArtifacts.txt that lists occurrences of 'struts' in common, jst and jsf. 1. Most cases of loading classes from struts plugins are kind of extension points (e.g. adding create/import project actions to Web Projects view). If plugin/class is not available, it is ignored. These references to struts can be cleaned out. 2. Check for struts nature. These checks can be also cleaned out. 3. Wrong names of fields and methods, e.g. IJSFModelListener.isStrutsModelListenerEnabled(). 4. Some references from JSF metadata to Struts metadata that became dead code (e.g. action "Show/Hide Links") but were kept just in case if such a feature may be requested. This references can be cleaned out. 5. There are a lot of images in org.jboss.tools.common.model/images/struts folder and they are references form metadata files. Should we rename this folder? 6. Meta data for web descriptor defines icon paths with 'struts' in them, that makes hundreds of occurrences of 'struts'. That is easy to rename, being limited to *.meta files. 7. options_general.xml declares sets of icons with names "Struts Common", "Struts HTML", etc., and they are reused in jsf-palette.xml. They are names that user can see in Palette Editor in section "Icons". We may change "Struts" in these names with "Page" or another neutral word. 8. Options have folder named 'Struts Studio' which contains many items not related to struts. Should we rename it? 9. Code creating struts project that was kept in jst, like NewWebProjectHelper.getModules(). Now it is dead and can be removed. 10 Awkward problem marker name JST_WEB_PROBLEM = "org.jboss.tools.jst.web.strutsmarker". It was already once renamed from "org.jboss.tools.jst.web.ui.strutsmarker". We can rename it again into "org.jboss.tools.jst.web.problemmarker" and set current value to OLD_JST_WEB_PROBLEM which now holds the oldest value. I suggest a separate sub-task and commit for each of these items. was (Author: scabanovich): I have attached StrutsArtifacts.txt that lists occurrences of 'struts' in common, jst and jsf. 1. Most cases of loading classes from struts plugins are kind of extension points (e.g. adding create/import project actions to Web Projects view). If plugin/class is not available, it is ignored. These references to struts can be cleaned out. 2. Check for struts nature. These checks can be also cleaned out. 3. Wrong names of fields and methods, e.g. IJSFModelListener.isStrutsModelListenerEnabled(). 4. Some references from JSF metadata to Struts metadata that became dead code (e.g. action "Show/Hide Links") but were kept just in case if such a feature may be requested. This references can be cleaned out. 5. There are a lot of images in org.jboss.tools.common.model/images/struts folder and they are references form metadata files. Should we rename this folder? 6. Meta data for web descriptor defines icon paths with 'struts' in them, that makes hundreds of occurrences of 'struts'. That is easy to rename, being limited to *.meta files. 7. options_general.xml declares sets of icons with names "Struts Common", "Struts HTML", etc., and they are reused in jsf-palette.xml. They are names that user can see in Palette Editor in section "Icons". We may change "Struts" in these names with "Page" or another neutral word. 8. Options have folder named 'Struts Studio' which contains many items not related to struts. Should we rename it? 9. Code creating struts project that was kept in jst, like NewWebProjectHelper.getModules(). Now it is dead and can be removed. I suggest a separate sub-task and commit for each of these items. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira